Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 12:39:00 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <bryan.whitehead@microchip.com>,
        <edumazet@google.com>, <pabeni@redhat.com>,
        <UNGLinuxDriver@microchip.com>, <Ian.Saturley@microchip.com>
Subject: Re: [PATCH net V4] eth: lan743x: reject extts for non-pci11x1x
 devices
Message-ID: <20220928103900.bwtbtmfhnyhr5cnz@soft-dev3-1.localhost>
References: <20220928090311.93361-1-Raju.Lakkaraju@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20220928090311.93361-1-Raju.Lakkaraju@microchip.com>
Precedence: bulk

The 09/28/2022 14:33, Raju Lakkaraju wrote:

Hi Raju,

I think there is a 24h waiting period before sending new patches for the
same series, just to give time for other people to review it.

> Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not support
> the PTP-IO Input event triggered timestamping mechanisms added
> 
> Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External  Timestamp (extts)")

This still fails for 2 reasons:
1. Empty lines around fixes tag
2. The subject line is still wrong. It doesn't match the SHA.

I would do something like:
---
Fixes: 60942c397af60 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
---

As you noticed I have skipped Jakub's reviewed-by tag because I can't find
it where you get it. Because I can't see it that you received it in v2
and you already added in v3.

> 
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> ---
> Changes:
> ========
> V3 -> V4:
>   - Fix the Fixes tag line split
> 
> V2 -> V3:
>  - Correct the Fixes tag
> 
> V1 -> V2:
>  - Repost against net with a Fixes tag
> 
>  drivers/net/ethernet/microchip/lan743x_ptp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
> index 6a11e2ceb013..da3ea905adbb 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ptp.c
> +++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
> @@ -1049,6 +1049,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp,
>  					   enum ptp_pin_function func,
>  					   unsigned int chan)
>  {
> +	struct lan743x_ptp *lan_ptp =
> +		container_of(ptp, struct lan743x_ptp, ptp_clock_info);
> +	struct lan743x_adapter *adapter =
> +		container_of(lan_ptp, struct lan743x_adapter, ptp);
>  	int result = 0;
>  
>  	/* Confirm the requested function is supported. Parameter
> @@ -1057,7 +1061,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp,
>  	switch (func) {
>  	case PTP_PF_NONE:
>  	case PTP_PF_PEROUT:
> +		break;
>  	case PTP_PF_EXTTS:
> +		if (!adapter->is_pci11x1x)
> +			result = -1;
>  		break;
>  	case PTP_PF_PHYSYNC:
>  	default:
> -- 
> 2.25.1
> 

-- 
/Horatiu