Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp380960rwb; Wed, 28 Sep 2022 04:08:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ng3eUKNQlENM8TUq0Vs5npgkePRkI+reOIfhFncwjHqoDZ70q24hcmpwQoDx+f5OEFhJM X-Received: by 2002:a05:6a00:cd4:b0:541:3fff:35a4 with SMTP id b20-20020a056a000cd400b005413fff35a4mr33894282pfv.56.1664363324724; Wed, 28 Sep 2022 04:08:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664363324; cv=none; d=google.com; s=arc-20160816; b=UIeLADPJgshSAyqH3mt0dN9zFecsoCSbxLYumwpBHEb94JQLHjSyscssYGxnktnHAb 8ILjvBj50ro2+uGzMGK6xurhgl4lQBJWzgor+UeUxjD7MMy12tusHBLtmgBbwcv6piTP WiFnUaLM4GHnrSOYPbSTC+ggfVy6RGQElKqxDA5nwLGUenhf7pQxSSI8pXKc9CWiVqc0 eE8U5b+aCsT5ljbX0uH6ZflAKmoMCw9YueBwdytU2L3Fp4eMzk6/udoBPDYKnmBfXRbE NHDvvgHOft/lTi2/ZcuCQ0FKaQPu3fGY7x1XDS6aAYy522TVkGN8V3QsPsvGUFm5DhF5 ZCZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7H3Cu9ZcKiDmBJN1xXpiMO0npBxr1dEsmlboFfFoZw0=; b=D0nl6WlNtHTLrcdUK2WB50RitS7tmdz/KjcJuNznzFicUh6T3qn9CPYrMEdb4D6wDB DaUjnFSHwNHQLlWX0FUNuzx2njU6/adQMwgB7Rtcqda84zFn4WM8nkYNamUfxxwp1edU x0YSHVtnT8GukxKwCbawP0syFz1wZJgP4hs3sE+eGOg/+ACQBHLJWzF815SX8UISmrSm mYMh+HyxZozLKlDHwlGizT6r7Bhzq5/GbopC4aux73wvAceT6Ns80j2BvjdImlgLU+89 hvL3Y/EzoBUH0SH5u0SrjWNz9PJqhQ8kgWN4d3K/rdPe7VE5mthfhiV1xiHlKYghHtuo OfTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RwmNv2h0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s19-20020a632153000000b0043c07dae4ddsi5209772pgm.285.2022.09.28.04.08.31; Wed, 28 Sep 2022 04:08:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RwmNv2h0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233378AbiI1Kcl (ORCPT + 99 others); Wed, 28 Sep 2022 06:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232257AbiI1Kcj (ORCPT ); Wed, 28 Sep 2022 06:32:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78D5B7B2B1 for ; Wed, 28 Sep 2022 03:32:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15DBE61DF3 for ; Wed, 28 Sep 2022 10:32:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58A00C433D6; Wed, 28 Sep 2022 10:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664361157; bh=3K4mlyQdbYqKsgWLJ5hw03fCtg9ZzFhXnWwRGvxyuag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RwmNv2h0K/st1Qre0mHRPAal7LaGybr3AC9beIDaq16X562dbvaaw3FXDGb2bPcLK pc3lw7J2hgMjC9pgJIkeya1jdDZAkoMxmaIKt2juOiunhC9hDEUxrPa/fVYSrDZEOT akbw4SLwRJWVn/21IQ9I4a+QvBYN8jFfOboWEGFvo+1glArgdKT8aGFUPCpBZ5N/ub Fl+UILV3whae7wu6pGnj8KFiCSgTbEOjVOq3spHwa27jfqsb5ojdG+/Lr5vgB1oXfC uQIXuuP6d7KmAmZmubGdbLpZ2qZ67UK778+uKt0uuEymMDpanAId9eVKwa/KPOXLgJ h9kfVvzoLeTAw== Date: Wed, 28 Sep 2022 11:32:32 +0100 From: Lee Jones To: Peng Wu Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org, liwei391@huawei.com Subject: Re: [PATCH] mfd: htc-i2cpld: Fix an IS_ERR() vs NULL bug in htcpld_core_probe Message-ID: References: <20220913071659.94677-1-wupeng58@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220913071659.94677-1-wupeng58@huawei.com> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Sep 2022, Peng Wu wrote: > The gpiochip_request_own_desc() function returns error pointers on error, > it doesn't return NULL. > > Fixes: 0ef5164a81fbf ("mfd/omap1: htc-i2cpld: Convert to a pure GPIO driver") > Signed-off-by: Peng Wu > --- > drivers/mfd/htc-i2cpld.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯]