Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp382992rwb; Wed, 28 Sep 2022 04:10:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6KPIiG9QubcYHWLAQlvGH3OkYLTkN1B+Ui58+aBiaXMPXJJIzK3Bxb89iw1nRkJ0RsHZfN X-Received: by 2002:a63:8a49:0:b0:440:34ef:b2b8 with SMTP id y70-20020a638a49000000b0044034efb2b8mr1959525pgd.233.1664363416086; Wed, 28 Sep 2022 04:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664363416; cv=none; d=google.com; s=arc-20160816; b=sY2d3yuH6yK+Er9vxHoAgcmhh4QnWA/PIFYd2z46lPBnKmsoJrje7QwSZ5cpusSL1V HKjJz3fzORH+OpowUF6dbaL/EcCP7m2B/TM781zu+Sa0HkYviLpmEAhlqhebeDX3liOo z+O/EOuTfCqOpalKBTHPNcp3WKOix4861vfMVZKZNpn8VOJcKXM0kXD7n0mRJUf4ILJ4 IPRM4pztybR2PWeV/qbzMCeLtrA2Y0YWNxv/oyfwM8hCM5IXq5qIE2XSEKd1/dPVH5jj vG7CovNQrSfIuyLeMXLafa8zgas3Wbws9qR/Rn9xcVLA2qX/e4lR6A3FRN3dxnYyS/NI h0hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TvC/ALrxAJSA8jgElYrPaDlRpGjWvJ+S5PU3u9AGQW0=; b=iHxT5ToMnCmUgQi1c6gV12E9Fb/r3BXZuA4D7ydAnAmxWDhQ+2RZ+LD1WmJ3fzUHre QhMerrthppkSLpfFXVPS4G18DIE/drRJkl6xfT099sHw85mN2R78AaMMNul6rLnMxuwZ VMMUor4im0VVaI9j6MSOpQiyB7EQuriXAxffCtOdCFcJQQXMpQwJ5lN/GfuI50j6PbDd or8mlEom4u9+cNFoKhlmDpx3upNT5F8H29944Cv8ktWPETr4L1qZQv9kVjhK75voLhia 1zOE9hdUg5ZilXq/hO+sYooqkUkmeqtmluJGgFOrsjp6//RtyKfIj4u+EgTKd+sN/EsL tNzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=wC+q4gRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q185-20020a6343c2000000b0042da7e85aa1si4924932pga.530.2022.09.28.04.10.04; Wed, 28 Sep 2022 04:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=wC+q4gRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234124AbiI1LBr (ORCPT + 99 others); Wed, 28 Sep 2022 07:01:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233117AbiI1LA4 (ORCPT ); Wed, 28 Sep 2022 07:00:56 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 096218C46B for ; Wed, 28 Sep 2022 04:00:29 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id u69so11906663pgd.2 for ; Wed, 28 Sep 2022 04:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=TvC/ALrxAJSA8jgElYrPaDlRpGjWvJ+S5PU3u9AGQW0=; b=wC+q4gRayIrrojd5NNz/4k7eSkzCZifqS791bKfvn1KPZjMCq4khGbNFBM+HJO9Moh SDZIxqn2z1ZKYCLxC+8vBo+XConeT223VVXe2zkEJ3WNxA47YbRu87WrN1Xu0y76Y4XU WHH7KC6eNBVqibeF+Y+M7JWgrw0pPmjVRDWLSvzU2XUb5Jm/cJSyUSwvOmgOhPEiNOTS jHAY5J9OTHvpi4EMLOq6zkJ+Al16ABpJ0+awGZonyn0TdixlwEhZzu/OtcwnRHT2Chr/ tyDl8tzD+WlEFr9PKwgHpJyh5RB/1G1+t7YHi3WFxpkjrrCGfOTY216lm4YjBX6ZrOfK bqpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=TvC/ALrxAJSA8jgElYrPaDlRpGjWvJ+S5PU3u9AGQW0=; b=o+8A0385nzx9Pha3zAwRytmwvq7WqVm1mwq+pUzgwPooiJGmAn/9Y2q9qdIz1XTOOV aUTl9cUjczbAzDiySZqrZyBbdutVpF8FvR97yyC+LtYvXzc8cmXLfp5OiKS9N2gKnmNT IMMJIkb/yNCy944gFc3UStXGo7jHVfNMK4apsVB8EXr0O4DWHTv7BKaQMt5Dx/oA/E40 E3S7l2AJcVR9RtooTKW5ccNpjLgz74yIcoP9x92lE2BuSeK3RCqOiMYoMWHkWMgLCI/2 r6ILswgYDUxo2gAip5NMzFlhVRlpbq0pfQzQrAdH/zEE7ZoM/kE5pVrr2mSIFwkIRqmB bwuA== X-Gm-Message-State: ACrzQf2sKYYccfR2xMIsJ84/dboCKNZlua3379Z4J3C2r29KgJWux+A8 Ob/I2ceHT/7obRTRz8JrG5a2+Os5cGB2Iw== X-Received: by 2002:a63:4408:0:b0:439:befa:3d47 with SMTP id r8-20020a634408000000b00439befa3d47mr27860398pga.64.1664362829108; Wed, 28 Sep 2022 04:00:29 -0700 (PDT) Received: from C02F63J9MD6R.bytedance.net ([61.120.150.77]) by smtp.gmail.com with ESMTPSA id b13-20020a170902d50d00b00177efb56475sm1539524plg.85.2022.09.28.04.00.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Sep 2022 04:00:28 -0700 (PDT) From: Zhuo Chen To: sathyanarayanan.kuppuswamy@linux.intel.com, bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com, fancer.lancer@gmail.com, jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: chenzhuo.1@bytedance.com, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ntb@lists.linux.dev, linux-scsi@vger.kernel.org Subject: [PATCH v3 4/9] scsi: lpfc: Change to use pci_aer_clear_uncorrect_error_status() Date: Wed, 28 Sep 2022 18:59:41 +0800 Message-Id: <20220928105946.12469-5-chenzhuo.1@bytedance.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20220928105946.12469-1-chenzhuo.1@bytedance.com> References: <20220928105946.12469-1-chenzhuo.1@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org lpfc_aer_cleanup_state() requires clearing both fatal and non-fatal uncorrectable error status. But using pci_aer_clear_nonfatal_status() will only clear non-fatal error status. To clear both fatal and non-fatal error status, use pci_aer_clear_uncorrect_error_status(). Signed-off-by: Zhuo Chen --- drivers/scsi/lpfc/lpfc_attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 09cf2cd0ae60..d835cc0ba153 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -4689,7 +4689,7 @@ static DEVICE_ATTR_RW(lpfc_aer_support); * Description: * If the @buf contains 1 and the device currently has the AER support * enabled, then invokes the kernel AER helper routine - * pci_aer_clear_nonfatal_status() to clean up the uncorrectable + * pci_aer_clear_uncorrect_error_status() to clean up the uncorrectable * error status register. * * Notes: @@ -4715,7 +4715,7 @@ lpfc_aer_cleanup_state(struct device *dev, struct device_attribute *attr, return -EINVAL; if (phba->hba_flag & HBA_AER_ENABLED) - rc = pci_aer_clear_nonfatal_status(phba->pcidev); + rc = pci_aer_clear_uncorrect_error_status(phba->pcidev); if (rc == 0) return strlen(buf); -- 2.30.1 (Apple Git-130)