Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220928110509.13544-1-ilpo.jarvinen@linux.intel.com> <20220928110509.13544-4-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20220928110509.13544-4-ilpo.jarvinen@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 28 Sep 2022 14:10:44 +0300
Message-ID: <CAHp75Vd6OJ68BbaYt21hPpOpDbvT9pow6PSDhedGULjikGhoNg@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485_mode()
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Jiri Slaby <jirislaby@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Sep 28, 2022 at 2:05 PM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> Add to rs485 documentation that serial core prepares the struct
> serial_rs485 when uart_get_rs485_mode() is called. Remove the wrong
> claim that driver must fill it by itself.

the driver

...

>     The device tree can also provide RS485 boot time parameters
> -   [#DT-bindings]_. The driver is in charge of filling this data structu=
re
> -   from the values given by the device tree.
> +   [#DT-bindings]_. The serial core fills the struct serial_rs485 from t=
he
> +   values given by the device tree when driver calls uart_get_rs485_mode=
().

the driver

Feels like this should be before the previous patch and actually have
a Fixes tag.

--=20
With Best Regards,
Andy Shevchenko