Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 12:30:11 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>
Cc:     linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        UNGLinuxDriver@microchip.com
Subject: Re: [PATCH RFC SPI for-next 2/2] spi: microchip: pci1xxxx: Add
 suspend and resume support for PCI1XXXX SPI driver
Message-ID: <YzQwQwL4NOTMMe18@sirena.org.uk>
References: <20220928034336.2939265-1-tharunkumar.pasumarthi@microchip.com>
 <20220928034336.2939265-3-tharunkumar.pasumarthi@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="22Z4F81dhKsw65X1"
Content-Disposition: inline
In-Reply-To: <20220928034336.2939265-3-tharunkumar.pasumarthi@microchip.com>
Precedence: bulk


--22Z4F81dhKsw65X1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 28, 2022 at 09:13:36AM +0530, Tharun Kumar P wrote:

> +	for (iter = 0; iter < spi_ptr->total_hw_instances; iter++) {
> +		spi_sub_ptr = spi_ptr->spi_int[iter];
> +
> +		/* Store existing config before suspend */
> +		store_restore_config(spi_ptr, spi_sub_ptr, iter, 1);
> +		spi_master_suspend(spi_sub_ptr->spi_host);
> +		writel(reg1, spi_ptr->reg_base +
> +		       SPI_MST_EVENT_MASK_REG_OFFSET(iter));
> +	}

This saves the register configuration before suspending the device,
meaning there may be in progress transfers changing the device while the
save is going on.

--22Z4F81dhKsw65X1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmM0MEIACgkQJNaLcl1U
h9D/AAf+LQT7PEYJ8TrU3S/DzYnr+TF7s6GXgvJfvmIQHm08SLGYRxkSuXpqUIqg
smWC06LcwszgB+BznAeh4TR/k/J4BHWzFhmh2JTNqlFXLLrIEQdbr/1yAtr1p/xM
cX1StsHfAy9l0XsSxUogUA4FUWvZpCapn+Gd8+dWt2a9nhZF256Gta6uMmZF4Cqr
gL0SPqR6JZ8GsGjwl9hgm20sXF8Uvi0eXMS/TGRrCh+JH84uKBTh8HygtpURdZBh
DolaJujlrvj8ADj1klAtYHPfpGNxfxd+uihx6oz0H9ouis/mifJvUpWt2L1YmGP6
saMkA9dVg664heUoaS6rAmGVAl1CDg==
=l/HG
-----END PGP SIGNATURE-----

--22Z4F81dhKsw65X1--