Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp448945rwb; Wed, 28 Sep 2022 05:06:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6r9M5nFYga2XE6KabW+yQ07Vg/qOCWSYleJBsEAvF6TxDATihJeoJr8ZaStqODTIHFYjuh X-Received: by 2002:a17:907:1b1c:b0:72f:9aac:ee41 with SMTP id mp28-20020a1709071b1c00b0072f9aacee41mr27133644ejc.56.1664366775954; Wed, 28 Sep 2022 05:06:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664366775; cv=none; d=google.com; s=arc-20160816; b=MVOQQGqns7oMY+mEIWms5XDWFKFQMwxoI/u8AR2nPruPrG7rEmAlFHmxLw1eZUYhxn 8Nm4+0gMOcDkxDGcEbjc3DHymr2qMYpFyL4qbulyXQl1I5YcuV11hNzKAxBSf4UvJ/wA dFDQ8esEDDsv0gfJFbibiT04kvTbMuNESC/pnCH1OfHcZrU2YsQf8gBZmRp/XzNQpnMy bk7LLRf8h7iw9250XQVPqUA1ejUc40I8udypcfrkeFO/zsJpKHUk03yhE62Dr5ZuxhDS /WToMfo/yWnpf2RUvhCgay0HU9U9w0CupmYdo0OdxD7IujLNQUl2MKu/rIB6k2GwbwvP V0Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pYWIjI2zG6qx8PsHipWo2k/Bj8E69alY2jmp4fMvkIs=; b=CIyVM2Fqm26wsaOuKCeiCb+ynSubClX9kqd13Op96x+vGgSaUHObpGw0NQJ6lifmB8 JGLWehzrGVKC1xXDyUzeb8JGFU01YhIXvfN1AxCDQwRWH4VHhQoHv40m1m/fo24nLB95 7dt9MzrTRhyWb+ILl/zxmsg9i+fPAkslFOqC5nWjgATEtBnXk7dHIEP4nTc2CLbA98Zx y3W+w798S5pCK6iN7RmrPfGKaFjqXSeyb1vfWcW0QaiX3cwDYrmevtZNPuni8t8f5zfY mmRsLhvwKpgcvqLJifZ/l5wmDCE34nyMi8S1vtYtyV1D8KRSrEFoD9v7sbM2o2SykH2E /Vuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=eEu5aM3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj2-20020a1709069c8200b0076c593c2d58si5435308ejc.479.2022.09.28.05.05.36; Wed, 28 Sep 2022 05:06:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=eEu5aM3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbiI1Li5 (ORCPT + 99 others); Wed, 28 Sep 2022 07:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233448AbiI1Liz (ORCPT ); Wed, 28 Sep 2022 07:38:55 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14189103; Wed, 28 Sep 2022 04:38:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ACAE81F8A3; Wed, 28 Sep 2022 11:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664365133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pYWIjI2zG6qx8PsHipWo2k/Bj8E69alY2jmp4fMvkIs=; b=eEu5aM3Q2HILLqqyiC30YRVrS5v1Z9lVjKfTJGXvx5Yt6gAGhiY0jYQMSLwApMmmUJ0ySe QHjPXTkEuUkOd1aZWjW6bDk0hh0xkgbmy1FM7U59KznTpM34r7dvbAtrPayJoCOy4q6yvw IaBQjeUZtHXa8cEXZ5xrDTEzuVPHF6Y= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 718ED13677; Wed, 28 Sep 2022 11:38:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nUF/Gk0yNGPlKAAAMHmgww (envelope-from ); Wed, 28 Sep 2022 11:38:53 +0000 Date: Wed, 28 Sep 2022 13:38:52 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Tejun Heo Cc: Ming Lei , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Marco Patalano , Muneendra Subject: Re: [PATCH cgroup/for-6.1] cgroup: Make cgroup_get_from_id() prettier Message-ID: References: <20220923115119.2035603-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2022 at 07:31:58AM -1000, Tejun Heo wrote: > Ming, Michal, you guys' changes to cgroup_get_from_id() combine to make > cgroup_get_from_id() a bit too ugly, so I applied the following patch to > cgroup/for-6.1. Please take a look and lemme know if I broke anything. The cleanup looks good. Just for the record, I understand the refernced fix is persisted as > df02452f3df0 ("cgroup: cgroup_get_from_id() must check the looked-up kn is a directory") Regards, Michal