Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 14:15:54 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Joe Perches <joe@perches.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2 4/4] pwm: sysfs: Utilize an array for polarity strings
Message-ID: <YzQ6+mX+75KBW9O7@orome>
References: <20220826170716.6886-1-andriy.shevchenko@linux.intel.com>
 <20220826170716.6886-4-andriy.shevchenko@linux.intel.com>
 <5ba98dbd91dc981ec7384484b2a498805abef6b0.camel@perches.com>
 <CAHp75VfY5RgAju5ASvAp565oF6VmYYiuowNsPTGSm=+1iFJ98A@mail.gmail.com>
 <2e158f8dc433b6b78d47d209495bed678d92369a.camel@perches.com>
 <CAHp75Vc0NtYcuSUP106V54U6EBYsj3LMx2FDJT4_pfB3gAtpPQ@mail.gmail.com>
 <25705469f329005a4ff699d1f45a12dcb575adc0.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="K7V/mrz7OYoGtLJP"
Content-Disposition: inline
In-Reply-To: <25705469f329005a4ff699d1f45a12dcb575adc0.camel@perches.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--K7V/mrz7OYoGtLJP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 28, 2022 at 02:19:22PM -0400, Joe Perches wrote:
> On Sun, 2022-08-28 at 20:40 +0300, Andy Shevchenko wrote:
> > On Sun, Aug 28, 2022 at 4:46 PM Joe Perches <joe@perches.com> wrote:
> > > On Sun, 2022-08-28 at 09:40 +0300, Andy Shevchenko wrote:
> > > > On Sunday, August 28, 2022, Joe Perches <joe@perches.com> wrote:
> > > > > On Fri, 2022-08-26 at 20:07 +0300, Andy Shevchenko wrote:
> > > > > > Code is smaller and looks nicer if we combine polarity strings
> > > > > > into an array.
> >=20
> > > > First of all, please remove unnecessary context when replying.
> > >=20
> > > I am _very_ aware of context.
> > > I specifically left the code in.
> > >=20
> > > > > It's less robust though as PWM_POLARITY_NORMAL and _INVERSED
> > > > > are now required to be 0 and 1.  As the only 2 values in
> > > > > an enum they are, but that's not really guaranteed unless
> > > > > you read the enum definition.
> > > >=20
> > > > So, what do you suggest here and in many other similar places (yes,=
 ABI
> > > > implied) in the kernel?
> > >=20
> > > Leaving the code alone.
> >=20
> > It's good that PWM maintainers look at this differently.
>=20
> The enum is not userspace so it's not ABI.
>=20
> The PWM maintainers are free to do what they want but I
> prefer obviousness over compactness.

I do agree with Joe, I don't see any benefit in this.

Thierry

--K7V/mrz7OYoGtLJP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmM0OvcACgkQ3SOs138+
s6E2qA//efIhd72suhbp3wVU26ZYv3vUeU5PabYxkAYaKzVAwSJHsrbXFzBz6APi
X798wCLXzPfS12kYUC+pvu5CBEFvPuhjT3un37OLqgtdBOmcwJNodT/kQKy6rDcP
EeOx0Nsd0i9JWPvROazR2gXlYHGL1hrfnKUslbPX20zkLc2Ed4UCHmJc8pQMWdal
tltnqg8zyLe8qAmRKtUXqqzSD2jMNjntkHtAr/digrTbwejtAe+NEJlqgjQx0/EA
hCGrl48IVq8ZGnoAtFl3THxMEMuh3FZM0eULmDpkA1FsFgYzyIjbJGUoJHv+1N1O
E+FCXF0QmeL1T6uVxTnPG2kPyR63V7GdtvacROmTXRGsSfnQFewO/biLWnClUzF0
50rnYGZnL3pLnlfIxtkQ9hKyC0IU0yS3Nmda6wq3Bm4u8H9ABeOta6tHc3re3pG3
ftrZhHoRGF7IKl1IgEVcZ3zvYiNW25aZJFlo8vTLMrXlLWVLKiqqgTnwtA6tH+Yb
7N2KNbaWeYtbP/SgrBvWORQGMG2d5wRKT3JosZIVtrxvtKIKl78mrVcRPbEx5RvN
vWTI97/AYJloDRy+ltdoJO5gK0Xr6SAtFymnt2bfhLNc0fkZypA22Ztgn3qw/a/z
BQq2TAwX2m6je5HxNA5T1Xi6+55R8gDLuUOaV7lt4OWxdnmgB50=
=2Pm5
-----END PGP SIGNATURE-----

--K7V/mrz7OYoGtLJP--