Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 14:27:42 +0100
From:   Jules Irenge <jbi.octave@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     abbotti@mev.co.uk, hsweeten@visionengravers.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] comedi: Convert snprintf() to scnprintf()
Message-ID: <YzRLzkltH1nwroNc@octinomon>
References: <YzHxcb5VzWeSNKo0@fedora>
 <YzKS/3z2cQsFFfxD@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzKS/3z2cQsFFfxD@kroah.com>
Precedence: bulk

On Tue, Sep 27, 2022 at 08:06:55AM +0200, Greg KH wrote:
> On Mon, Sep 26, 2022 at 07:37:37PM +0100, Jules Irenge wrote:
> > Coccinnelle reports a warning
> > Warning: Use scnprintf or sprintf
> > Adding to that, there has been a slow migration from snprintf to scnprintf.
> > This LWN article explains the rationale for this change
> > https: //lwn.net/Articles/69419/
> > Ie. snprintf() returns what *would* be the resulting length,
> > while scnprintf() returns the actual length.
> > 
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  drivers/comedi/comedi_fops.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
> > index 55a0cae04b8d..e8a0142d5894 100644
> > --- a/drivers/comedi/comedi_fops.c
> > +++ b/drivers/comedi/comedi_fops.c
> > @@ -396,7 +396,7 @@ static ssize_t max_read_buffer_kb_show(struct device *csdev,
> >  	mutex_unlock(&dev->mutex);
> >  
> >  	comedi_dev_put(dev);
> > -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> > +	return scnprintf(buf, PAGE_SIZE, "%u\n", size);
> 
> Ick, no, you should use sysfs_emit() if you really want to change these
> functions to "do the right thing".
> 
> thanks,
> 
> greg k-h

Thanks for feedback. 

I just sent a different version.

I will appreciate any more feedback.

Thanks,

Jules