Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     John Garry <john.garry@huawei.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "jinpu.wang@cloud.ionos.com" <jinpu.wang@cloud.ionos.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
CC:     "hare@suse.de" <hare@suse.de>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxarm@huawei.com" <linuxarm@huawei.com>,
        "ipylypiv@google.com" <ipylypiv@google.com>,
        "changyuanl@google.com" <changyuanl@google.com>,
        "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH 1/6] scsi: libsas: Add sas_task_find_rq()
Thread-Topic: [PATCH 1/6] scsi: libsas: Add sas_task_find_rq()
Thread-Index: AQHY0zapIGo+Met9mEGqTMQhhuqFnw==
Date:   Wed, 28 Sep 2022 13:17:31 +0000
Message-ID: <PH0PR04MB74164CE477846FFDB843D5419B549@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <1664368034-114991-1-git-send-email-john.garry@huawei.com>
 <1664368034-114991-2-git-send-email-john.garry@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z/4ntsQOGCJ9rrUKXzvLM6X9pCjdovXlndRGylt1kYY57t+20MLYbsl1tYMe?=
 =?us-ascii?Q?CdfbcRSqO5aotPn3izOclr8cCoeTWAGylxffupi1NHgFUHTxqB/PhepH0Ijv?=
 =?us-ascii?Q?VLHG7yudCHkJPfEVHSt9kVpTSaWPX7wz9XfCdX6oRCRsxmfou1fK3OGx7+Gm?=
 =?us-ascii?Q?XATDSepG6h6t2gDznJpHSkefPVl7vA5BJQcf6G9Cp/coMLf6AGWEGoyKhhC0?=
 =?us-ascii?Q?P6UAFkg2MYeAtBois7atJ2cPvC/6PKv+QpXoR6nJsOauJlRltHIX+1FDSwVS?=
 =?us-ascii?Q?kiEfHQvc1nSVgd8fItkpkJoazdA1A+rJ4rajlfltOcNown8WKnkjDcwJLVdK?=
 =?us-ascii?Q?xDxNa8/F8rxdyrQ4dgJj1UYl8c82QXVSf5ny3eA1i4hyMANSCL+/r6V7NrT6?=
 =?us-ascii?Q?QI+kD3ByqTqbn+1Oh2l64GpqKbE82p7xAJdLc0zkyuGNpE/ZvtLwXWenLjJV?=
 =?us-ascii?Q?83LXDHT8Fp9xttobsEtPHIYrr4pdZvdLCeG3RI0Kk3hcqePKqKOpaXeIcWbv?=
 =?us-ascii?Q?QaVcn8VSwRn27QAa/H04053xOP+HOORvP2sULutHTB/8Ho58P+Ss3Hs5PlZb?=
 =?us-ascii?Q?FitRyqiv+yOGfhnhREpzVkl3viJsxaxtGDnFaPx5TipSQ1BcBMoymej9tvpt?=
 =?us-ascii?Q?aKx4pmNY014sa0m62SJ5Q25uYqenrDL0BprEEAdaSOWIZi81TfVrE4OkDff7?=
 =?us-ascii?Q?qWsrKaaVSmKI5wqCcwSN2VxZMwLWKNG1vzNCViPAH8tbD4DAe9ojECxHU7x/?=
 =?us-ascii?Q?4UBRd11yertUxbLJyw1SSpxsVwiFe+AgwjpZEEtif+Bn+1ZDxy9pOfoQ5PQW?=
 =?us-ascii?Q?tSDZ5i5I43cYLBH++jYvbd6+P+ZhEnJHWj3mELkqs+1jZPG5KcYXUehfBEQW?=
 =?us-ascii?Q?MtfDGXNmxefKTvXHC3+wBNMxJL2Z7dtZgcK5z3z8CD8sSNYiV6qafmafiE/t?=
 =?us-ascii?Q?DZM0azY2Envsf6QsQC8yqv79uPC/WRXpIPaW/MpFfbuPzna7JwKj1iokLuyW?=
 =?us-ascii?Q?HvZOCep0LORPv0mTu9fZqZSzTm4UU0GD/LPwjl/l9QM19CztSs7ZwgiqRGr9?=
 =?us-ascii?Q?SmD7yBX7YdNlRocxoG5Tj698B5WVxYQT1wwpILgfuTTw/e9W0XAP+dThPmY/?=
 =?us-ascii?Q?L7BLD9ECgs33nViiYWo3UH5x0kBakRjV1+/vBWk0u06/jXdWHE2gs5G4Up93?=
 =?us-ascii?Q?59wptl0zkEfJ+7p0to2Lebn84GhNitLDQAk8lO3Yfl0zW0kU3XqYbylKsRO0?=
 =?us-ascii?Q?vAWcAFZx6LlWAEtUcwsdNbudpEUQSCf2aLjJsvjpwzjkGEzm5WZxWaVSwVBl?=
 =?us-ascii?Q?4ftzeyGilpoFv3E24LCt16A62modQZjDQDTjPyqSGLrtBZ8pEkNj2ThVa91B?=
 =?us-ascii?Q?0X6Bzn3a908ZSx16OK4ipvzJJY0rISfCo+MWLoaBE/P012ICQ6dJRlb7g13H?=
 =?us-ascii?Q?EcsyYlxjRZguxTT/TVVOSozioiFe8L8ZKyRYrZ2ONOPXwnb/Lb4mSRV3ef+N?=
 =?us-ascii?Q?5FS5YlBIPhQOOH6Xjoa4LLM2HPEVJEw+pipkIVeSEcGXOjqH4jvaBOAjzKOU?=
 =?us-ascii?Q?rqOtjc1/R+N1jYgxDScsF5R5ARpWE7jm4ijtTda4cK4oRgMrDRh7/1AQ9Mzn?=
 =?us-ascii?Q?yio5VSVb7tA4KQLwxpLbDMebaPTZ0izhcYIGXhAFcAkK0iipv0rtSc+f1/15?=
 =?us-ascii?Q?2bSPwCNW+3wupfNneozfIg1J8aI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e50e74c-67c5-4790-7a35-08daa153ccb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 13:17:31.4574
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1GrbS6TEh7IuO0REs5kVhG4e4MCCO2zdba3tidrrAzUH8aGGjr1dgIWkqYmD3bEEwzfsQEUv8jjRj4hFiQQp9sF+v0y5O4cqu1ZdN+NYeJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5711
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28.09.22 14:34, John Garry wrote:=0A=
> blk-mq already provides a unique tag per request. Some libsas LLDDs - lik=
e=0A=
> hisi_sas - already use this tag as the unique per-IO HW tag.=0A=
> =0A=
> Add a common function to provide the request associated with a sas_task=
=0A=
> for all libsas LLDDs.=0A=
> =0A=
> Signed-off-by: John Garry <john.garry@huawei.com>=0A=
> ---=0A=
>  include/scsi/libsas.h | 22 ++++++++++++++++++++++=0A=
>  1 file changed, 22 insertions(+)=0A=
> =0A=
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h=0A=
> index f86b56bf7833..bc51756a3317 100644=0A=
> --- a/include/scsi/libsas.h=0A=
> +++ b/include/scsi/libsas.h=0A=
> @@ -644,6 +644,28 @@ static inline bool sas_is_internal_abort(struct sas_=
task *task)=0A=
>  	return task->task_proto =3D=3D SAS_PROTOCOL_INTERNAL_ABORT;=0A=
>  }=0A=
>  =0A=
> +static inline struct request *sas_task_find_rq(struct sas_task *task)=0A=
> +{=0A=
> +	struct scsi_cmnd *scmd;=0A=
> +=0A=
> +	if (!task || !task->uldd_task)=0A=
> +		return NULL;=0A=
=0A=
Is anyone actually calling sas_task_find_rq with a NULL task?=0A=
That doesn't make a lot of sense from an API POV for me, having=0A=
the only argument allowed to be NULL (and not being a *free()=0A=
kind of function).=0A=
=0A=
> +=0A=
> +	if (task->task_proto & SAS_PROTOCOL_STP_ALL) {=0A=
> +		struct ata_queued_cmd *qc;=0A=
> +=0A=
> +		qc =3D task->uldd_task;=0A=
> +		scmd =3D qc->scsicmd;=0A=
> +	} else {=0A=
> +		scmd =3D task->uldd_task;=0A=
> +	}=0A=
> +=0A=
> +	if (!scmd)=0A=
> +		return NULL;=0A=
> +=0A=
> +	return scsi_cmd_to_rq(scmd);=0A=
> +}=0A=
> +=0A=
>  struct sas_domain_function_template {=0A=
>  	/* The class calls these to notify the LLDD of an event. */=0A=
>  	void (*lldd_port_formed)(struct asd_sas_phy *);=0A=
=0A=