Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ae48706e-e628-766e-8a74-e322b96eeb6b@redhat.com>
Date:   Wed, 28 Sep 2022 16:27:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] mm: rmap: rename page_not_mapped() to folio_not_mapped()
Content-Language: en-US
To:     Kefeng Wang <wangkefeng.wang@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Cc:     Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org
References: <20220927063826.159590-1-wangkefeng.wang@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220927063826.159590-1-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27.09.22 08:38, Kefeng Wang wrote:
> Since commit 2f031c6f042c ("mm/rmap: Convert rmap_walk() to
> take a folio"), page_not_mapped() takes folio as parameter,
> rename it to be consistent.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>   mm/rmap.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 2ec925e5fa6a..df228602cf0e 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1801,7 +1801,7 @@ static bool invalid_migration_vma(struct vm_area_struct *vma, void *arg)
>   	return vma_is_temporary_stack(vma);
>   }
>   
> -static int page_not_mapped(struct folio *folio)
> +static int folio_not_mapped(struct folio *folio)
>   {
>   	return !folio_mapped(folio);
>   }
> @@ -1822,7 +1822,7 @@ void try_to_unmap(struct folio *folio, enum ttu_flags flags)
>   	struct rmap_walk_control rwc = {
>   		.rmap_one = try_to_unmap_one,
>   		.arg = (void *)flags,
> -		.done = page_not_mapped,
> +		.done = folio_not_mapped,
>   		.anon_lock = folio_lock_anon_vma_read,
>   	};
>   
> @@ -2150,7 +2150,7 @@ void try_to_migrate(struct folio *folio, enum ttu_flags flags)
>   	struct rmap_walk_control rwc = {
>   		.rmap_one = try_to_migrate_one,
>   		.arg = (void *)flags,
> -		.done = page_not_mapped,
> +		.done = folio_not_mapped,
>   		.anon_lock = folio_lock_anon_vma_read,
>   	};
>   
> @@ -2297,7 +2297,7 @@ static bool folio_make_device_exclusive(struct folio *folio,
>   	};
>   	struct rmap_walk_control rwc = {
>   		.rmap_one = page_make_device_exclusive_one,
> -		.done = page_not_mapped,
> +		.done = folio_not_mapped,
>   		.anon_lock = folio_lock_anon_vma_read,
>   		.arg = &args,
>   	};

I'm wondering if we should call it "folio_unmapped()". Anyhow

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb