Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp682381rwb; Wed, 28 Sep 2022 07:52:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM64GVo4d0orw9JYjuwDFUxTzp1OH/FAovugHHtYrylTf0gNpYIbEBq3YyALQC4WsNHo67Gc X-Received: by 2002:a17:903:41c9:b0:176:b9df:c743 with SMTP id u9-20020a17090341c900b00176b9dfc743mr210420ple.162.1664376764037; Wed, 28 Sep 2022 07:52:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664376764; cv=none; d=google.com; s=arc-20160816; b=xRStm8qSa7KcrXEICoxWKirYTYchfL/Vut1V9xSVlBGZYQEksHRyp/hgaNC6CopFs1 A3+ALoRcYU5SaaL+4/8A8uqFQXpu7rtiIaNlfrv9fLjNZEisXaWWl3dJPkZcC/i4X0ko rn42nVo7AW5u6MAzKST+Tj2P0eyXBX1r0+OZiYXr3qD21Z4I8v3+Qw7Rq5BTnetkrlHI wuZc9ZNaMzsucpM+sf2TEsihRqg8LPdYPNZcoiXDI9gTlFB24E096qTXYFU9AJzjkdhD D2mZkanvLN9GBzlJiusiWLhvndOI5HcERGN5cCJt0eCKPie6+Hc20Qlahw9EIHAi5zpE fjqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=CbzFSxJkM1Scz7I3rjC3ZF0jcJs5LYZVzMElwREpYZU=; b=PcR5HB3rh/80Y2YKTY3jwslS29zi40fnLO2s+SmQI3VzbFeYFiufJb5uxi/Kw+laco vfQkhE7zorf/iwM4NXhFDHQzXjWoOBLkbbGNAswY0BQKp7iyB00MxyIT/8VX+AEHLia6 lvb9yjttNzBJHZk10Xow6Zz/grd89vn/+c2h+qOcaz/3rOCsPCGFkuuWw+iy2K+BLM6c ytT/EeuN4i/KATCAuoQz2TFloTVwHbvgFrdnN6YIVqwSYJay1g0GMKGgY87leMj9Vxyt XvIi4Ie92SJYWmAWfWxmiuLqCTPfrSJI7v1ohCXAq2xmFBcxnV+Ll1uovgA0YClvoc2k 6rpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OLUgtvoV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a056a00158100b00534de5a9e5asi3674946pfk.329.2022.09.28.07.52.32; Wed, 28 Sep 2022 07:52:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OLUgtvoV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234290AbiI1OQK (ORCPT + 99 others); Wed, 28 Sep 2022 10:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234284AbiI1OQI (ORCPT ); Wed, 28 Sep 2022 10:16:08 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53AA862A8C for ; Wed, 28 Sep 2022 07:16:07 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id i26so20564026lfp.11 for ; Wed, 28 Sep 2022 07:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CbzFSxJkM1Scz7I3rjC3ZF0jcJs5LYZVzMElwREpYZU=; b=OLUgtvoVpmT65VJruvf4qFV8n58qZbD9+3hPgSDX6L2a/doi2j5Ur5Z/xMBi/3Dl0K 4QKSg9LPVATngQWBjGMyHo5FfnQRkfcXumQOJmONyRFR3qUtCRqiN+l7r7SzcxBPoYuw UqBe9b2SOlgAIcRYWCJtE0oD+9xrw5yfCRVFn4rVYFJjudycAG/mK3j5XbxWKc6y88yq AhF3gcNzDxJh/1YFvP6fc3l1PzrmK5cdyQV1uq2maU9yAP1HnFvH44TMcjELhzmygPDC QSxOMisI2mOYosCz33fTvhBk8n50bQFskdrQyjIsUWoZbZMfD4sOkV1ZBnhr+buh0HJt AgEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CbzFSxJkM1Scz7I3rjC3ZF0jcJs5LYZVzMElwREpYZU=; b=mOIdQNLMCXkeCjUbR7ZPzmdE0+kbUxmT4S9mVjsQu1miu0LwBwhHwV727HhbDNJqaZ JuOA93acPG7OVofmuZPiJ5mwHxIKFmH+OKptXS7XI72JVFdWy0TMg1CkdyzDkv4Bvezl 48r0GYBjKDrCSQ0lDFcq2kD/Y4rqGBW8SpMVjzy2WwoUbBl4WCcScp41o2/YMjtLdort zk8UY/T8BfKjDCCG/t3nef5Z566RMmsvZc/YK2Ll6GnOvIwgUDqoBPpJ9J+TO7rS6Bhw kXNcOfbqvTpz3D1r4byamvMWt5wA1RrwbI4KWoKnXpVj3j6FKHokZYhprOvQwqNotDcu kcXw== X-Gm-Message-State: ACrzQf1TpgHM9jywVOdaTDMk11MYHkKE75/xpspirqnv3QLwt9tYt9K3 kyjol6LhRJ1foD86uluShnk8OA== X-Received: by 2002:a05:6512:3b0b:b0:49a:d44b:428 with SMTP id f11-20020a0565123b0b00b0049ad44b0428mr14325599lfv.0.1664374565421; Wed, 28 Sep 2022 07:16:05 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u20-20020ac25194000000b00498fd423cc3sm481496lfi.295.2022.09.28.07.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 07:16:04 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 16:16:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Content-Language: en-US To: "Lin, Meng-Bo" , devicetree@vger.kernel.org Cc: Stephan Gerhold , Nikita Travkin , Josef W Menad , Markuss Broks , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, "Lin, Andy Gross" , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski References: <20220928110049.96047-1-linmengbo0689@protonmail.com> <20220928121717.102402-1-linmengbo0689@protonmail.com> <20220928123816.104641-1-linmengbo0689@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220928123816.104641-1-linmengbo0689@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2022 14:39, Lin, Meng-Bo wrote: > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: > > Samsung Galaxy J5 2015 (SM-J500*) > Samsung Galaxy J5 2016 (SM-J510*) > Samsung Galaxy J3 2016 > - SM-J3109/SM-J320Y/SM-J320YZ > - SM-J320N0/SM-J320ZN > - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL No need to repeat it in every commit. > > Add a common device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - UART (on USB connector via the SM5703 MUIC) > - WCNSS (WiFi/BT) > - Regulators > > The three devices (some varints of J3, all other variants of J5 released > in 2015 and J5X released in 2016) are very similar, with some differences > in display and GPIO pins. The common parts are shared in > msm8916-samsung-j5-common.dtsi to reduce duplication. The same. > > Signed-off-by: Lin, Meng-Bo > --- > ...6-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} | 10 ++-------- Thanks for using proper format options. However your patch is not bisectable - kernel is broken here. Best regards, Krzysztof