Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 16:40:02 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
Cc:     Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Use PCI_CONF1_EXT_ADDRESS() macro
Message-ID: <YzRcwkAqoiqr0VhB@orome>
References: <20220928121911.14994-1-pali@kernel.org>
 <YzRbnjb6UVwrj/li@orome>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wgdOBF4sKJ52vuXE"
Content-Disposition: inline
In-Reply-To: <YzRbnjb6UVwrj/li@orome>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--wgdOBF4sKJ52vuXE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 28, 2022 at 04:35:10PM +0200, Thierry Reding wrote:
> On Wed, Sep 28, 2022 at 02:19:11PM +0200, Pali Roh=C3=A1r wrote:
> > Simplify pci-tegra.c driver code and use new PCI_CONF1_EXT_ADDRESS() ma=
cro
> > for accessing PCI config space.
> >=20
> > Signed-off-by: Pali Roh=C3=A1r <pali@kernel.org>
> > ---
> > Please look also at this related patch:
> > https://patchwork.kernel.org/project/linux-pci/patch/20220911113216.148=
92-1-pali@kernel.org/
> > ---
> >  drivers/pci/controller/pci-tegra.c | 11 +++--------
> >  1 file changed, 3 insertions(+), 8 deletions(-)
>=20
> I had to go chase down the patch that introduces PCI_CONF1_EXT_ADDRESS.
> It would've been easier if this had been part of the series that
> introduced that, or if you had provided a link to that patch here.
>=20
> Anyway, looks like this is equivalent to the existing inline function,
> so:
>=20
> Acked-by: Thierry Reding <treding@nvidia.com>

After looking at the linked patch, perhaps revise this one more time and
remove the comment above the removed helper since it's now just a
duplication of what the PCI_CONF1_EXT_ADDRESS comments say.

Thierry

--wgdOBF4sKJ52vuXE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmM0XMIACgkQ3SOs138+
s6E4vg//aq29as5dOoYD/iQAcoZLxojhmIhteyPO4CN2K78Xar4DLaMbECiCLAIU
ZX+hyODe6/XkzWHm8m5WKD+ewDgmwxUMWoTYN7UI7FM0WPqt3vtEXV0tUAvGIzUn
a2Y5u3ohXIm3j1hHwVMsXi7HMeVGrvsDoiULfNOApoaXooDHWP3fd3VGS9BZuMEb
GOJ9WeFIaCWuN8gk0gjWUbf4ZV7Jk7N7XmD/Kef7AjKWbkAeAJWsNTfM0Fj8oPFq
p7S6xMbRfO7/S/QUGlbwxKmSX6iP7jtlhRGfDvDP6XMo/UPB7T0jCVpIhOjShb2t
BDVQg85fx6dMFECM+DLvlxPMmFvReICDqeLPj4K+RW0y0DWEBLHZ89WiugtxrRWV
EcJYu3X5DKW1AdW3csYTmuOd8YLPSnHn453Aa5wNIhoqLGUQ4i1jTJWxER3fHSrO
zul5uHhgsJMRPSDgntpi0ivKSBtaOmnyJ9QTs7diagWzwOGmDfyiofOgzzsTMnlK
2jmYOx30AUT5zKNdycYNH7kqinOssJ5N4f6AfOdXec9S4/5EYNvtXiGjFaQrXRaM
2ZJuGOrSs2cvqDSdJzZhE/YDBX0GR5jdx+R+Z9qjpKhYbyROzr3g27PUPESY1lB9
yJOep9O4OJn1SavBg4KONqUCYQOZUvekFGnNzbG4JycCsipd50M=
=q/hC
-----END PGP SIGNATURE-----

--wgdOBF4sKJ52vuXE--