Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 15:45:40 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Wayne Chang <waynec@nvidia.com>
Cc:     heikki.krogerus@linux.intel.com, Sanket.Goswami@amd.com,
        singhanc@nvidia.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: typec: ucsi_ccg: Disable UCSI ALT support on
 Tegra
Message-ID: <YzRQBEeLorfC8KAL@kroah.com>
References: <20220928131615.3286936-1-waynec@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220928131615.3286936-1-waynec@nvidia.com>
Precedence: bulk

On Wed, Sep 28, 2022 at 09:16:15PM +0800, Wayne Chang wrote:
> From: Sing-Han Chen <singhanc@nvidia.com>
> 
> Firmware built for Tegra doesn't support UCSI ALT
> command and has known issue of reporting wrong
> capability info.
> 
> This commit disables UCSI ALT support when reading
> the capability on Tegra.

You have a full 72 columns to use, no need to make it shorter :)

> 
> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 5c0bf48be766..fde3da0605f5 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -122,9 +122,14 @@ struct version_format {
>   * Firmware version 3.1.10 or earlier, built for NVIDIA has known issue
>   * of missing interrupt when a device is connected for runtime resume
>   */
> -#define CCG_FW_BUILD_NVIDIA	(('n' << 8) | 'v')
> +#define CCG_FW_BUILD_NVIDIA_RTX	(('n' << 8) | 'v')

Why change this here?  It's not needed, just add the new command
instead.

And what commit id does this fix?  Is it needed for stable kernels?  If
so, how far back?

thanks,

greg k-h