Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp731166rwb; Wed, 28 Sep 2022 08:24:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4xmo0TGBJ0u3E25TYLbsRdLiD3h6NYU18UyxIrbwvnkT+rH5jImPASE0cnePzc8Gpt0H5y X-Received: by 2002:a17:902:b944:b0:179:fdb0:1c39 with SMTP id h4-20020a170902b94400b00179fdb01c39mr370442pls.98.1664378689364; Wed, 28 Sep 2022 08:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664378689; cv=none; d=google.com; s=arc-20160816; b=mGYE/h/c6hOT8uYTupOfM7rcSsjNmJwsZIdTqnFJZbdLwuUtgatghJBNGT16bv8Md0 dIdPnrGnEkPFV35dxqopXnAzcrJ90XAYG7nWmKxUJ/ggXT1gI8CVebRjgDRa0qWtlxTp k3kniEMkNkFF6M3JM2aLNKR6cdxYSJUEljn/PcmhcVDQK4ha0yPd2FonICRPO4JXrv7L yuGIOk0CgK8bKnsaGMgfL11Oc2M+VIcPwmlo1WeCabWXNChiVx7nBMHtV1azXY+GTiPY tgIPVb3oMaMpl/qTC7mrtSW3YTvvjQU4IXDSg0crwXxqb8V6n/BCdFeZ7QapXQEqMQk4 +leg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8DnDko/nUiaNQfilebzmtyXvqhSN9KVnALbnVAuYDqY=; b=e7X/XNrvqIvIh1d31KHMsyMXUVsNvOrIpXXIF9juROW6CvrET1MXSep5ykJuAkEnsl tHbrFGtPq9mu0qSpyU/Jzxuj2pMnAHnXi9S8SIGaeO52R2j6CeT4DZhv0ZXGmggzZTTR LJzU34IpzG0/R0Ei4BlD9oEXNG4FAS3DYKlAWmaRdigr0I3UQ0Xoj0xEH+pbbdtFKG11 0KJtyTLfirfmM6loP9B6WPxEnLb/u4/4DKpidx/Edq7/ttsHWXmOnWjHhi7EsGmqaTT1 HVYzZEstP72Xhp8nfgq7k5ROVi+U40UzA/9dbyeJMdoW8f02VR1CRujXbWX4volUfDEB O+CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WgvQ11R+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y18-20020a1709027c9200b001782ecb6189si5136784pll.142.2022.09.28.08.24.38; Wed, 28 Sep 2022 08:24:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WgvQ11R+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbiI1Oif (ORCPT + 99 others); Wed, 28 Sep 2022 10:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234418AbiI1Oid (ORCPT ); Wed, 28 Sep 2022 10:38:33 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A74E1AE211; Wed, 28 Sep 2022 07:38:31 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id c30so16391241edn.2; Wed, 28 Sep 2022 07:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=8DnDko/nUiaNQfilebzmtyXvqhSN9KVnALbnVAuYDqY=; b=WgvQ11R+E2jsOCPT8ZNGJjq2pseCnFfA1rrwcat2ovY/RqY6+BNQ7i5E83cuRSedBe fXZ4WpYRCddesrDjbvOu+snt1NOyX8KTgiS6p3AuUzOmOGZlyB35e1XKyx3gXwGrxXUZ xHmOm5yClT7SHgmmZakm0WWiWCMxmjc184Nh7XQ0XCe5tLmeXNml9Og2T9m6KKlWNZg2 QMSO066GUcY4K0PY0X2SgVFgC+i+yyHURlMepAAkd9X73P6Y2v9MT7/zcKZlVJNdgNt1 BZXO3fvTN8pnQWSjkFrTXMgrjX+VtClkUUGfKg03eVoL540aoE7LSriP9D0v/i91w51f tPmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=8DnDko/nUiaNQfilebzmtyXvqhSN9KVnALbnVAuYDqY=; b=7AgFrpjrMsjY1KwU3WXpFf4eE1PCFLDBmnDSRoF/TQH9qBrxLM9IKAq311p/38nE60 5Kwao3uJ85jbeJUfFtL4RzEdvoMO9dxlrdmvjN/g5kmC+lN9Cnao3XhAUy69RerRkCEx p0e7OTv5+xPT302VSPMPUmIVeFKv/yvhxlUVmN1VhodBTbcpXRzUwwxrfPsL5J/Kjyod PO5TnmzWZGcJuySV0xg8dR6KbkZvLsPpM+IHG8Yf5XjTzJlDLqRAv2uKixRlyJgesgPW ySvUS1xoEy2VL2x4lLQCKrZTnx3tNkie56lO1trsAdWLif4lxAWUW6GYKY50kp6VUoUL l2Ag== X-Gm-Message-State: ACrzQf2HJPRwtFH75lzpIiSMIh0znZFnBdw7lq1nSZNeLujvHKmEhSar MhrYmKxGGnc3QizX1wvsm2c= X-Received: by 2002:aa7:da08:0:b0:456:ea2b:3ce3 with SMTP id r8-20020aa7da08000000b00456ea2b3ce3mr24742806eds.181.1664375910066; Wed, 28 Sep 2022 07:38:30 -0700 (PDT) Received: from orome (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id x2-20020a1709060ee200b0073dde62713asm2493593eji.89.2022.09.28.07.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 07:38:28 -0700 (PDT) Date: Wed, 28 Sep 2022 16:38:27 +0200 From: Thierry Reding To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jonathan Hunter , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: tegra: Update comment about config space Message-ID: References: <20220911113216.14892-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PBUmyu+1rqqoAJH+" Content-Disposition: inline In-Reply-To: <20220911113216.14892-1-pali@kernel.org> User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PBUmyu+1rqqoAJH+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2022 at 01:32:16PM +0200, Pali Roh=C3=A1r wrote: > Like many other ARM PCIe controllers, it uses old PCI Configuration > Mechanism #1 from PCI Local Bus for accessing PCI config space. > It is not PCIe ECAM in any case. >=20 > Signed-off-by: Pali Roh=C3=A1r > --- > drivers/pci/controller/pci-tegra.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Perhaps this should be rolled into the PCI_CONF1_EXT_ADDRESS patch? On the other hand there's really no use in keeping this comment around after that other patch because the documentation for the new macro lays out the details already. Thierry --PBUmyu+1rqqoAJH+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmM0XGMACgkQ3SOs138+ s6EUKw//e6+EBVbBjmdErmRkedqQRSc8/R4Y7cyWp8xtevza46OFYc837j7g+Lmp wqru1VugD6Zz0+t/ppR/84mjEr5EcsOnXJmbvz0QCq0oGUkvUfYULtMUpLPCy59n pbLQ/buBsGaE9kbGs0QWE+A1dBr7AWigRv5osD0ahl7OkkIuXSfYA5j0EgkTfslf jSoIrw4jyfiXTF01FMdb1Qsnq3qcOYsoCgwXXRoarhoVtS/NvN71hUQbohBrV675 Y/C8zwngKIx0EO1X9VmcxpyWtgdTG5HgbdTS0eN7QckLFyATCoz1FsZ8tPwwAWix iY3iV5lpjCr7JCC7rNj1tTtNpdfaqpnb/sRDNLKu2E2RDomueKkO+YzRTMLqTacF 6tEZk+W1evdPfTnfc/Oo6IIEEGhbMViQS4sYKiNiHG0NxjWoy/I0mt/JJ5uAapY6 0LMD+hqHTl+E0VMsd0Q0n9bMMW/qloZKW8Fgm6P8Eu9WtXQ3W7EnR76q6/Zn1a9Z 3u27DfG39rebzY0mAAHbqZDz70kU9XxHXrH1TJ6YPytyKBg5Oqwcp66IJ1B8qDqr Xy1sthcegoYWjpaIHRCN5R7eTX8LKQnqdqtNfBb4GnGoCFzXwB430Mdfao5w+wBZ 79PqcMXD/v03WiUhthfZor8sA8gxb9R5BBp8hU92D6MTeqR4LIw= =KBC4 -----END PGP SIGNATURE----- --PBUmyu+1rqqoAJH+--