Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fef52129-a2be-58a9-3725-a4fd345661c4@quicinc.com>
Date:   Wed, 28 Sep 2022 20:37:37 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] clk: qcom: gcc-sm6350: Update the .pwrsts for usb gdscs
Content-Language: en-US
To:     Luca Weiss <luca.weiss@fairphone.com>,
        <linux-arm-msm@vger.kernel.org>
CC:     <~postmarketos/upstreaming@lists.sr.ht>,
        <phone-devel@vger.kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220928132853.179425-1-luca.weiss@fairphone.com>
From:   Rajendra Nayak <quic_rjendra@quicinc.com>
In-Reply-To: <20220928132853.179425-1-luca.weiss@fairphone.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/28/2022 6:58 PM, Luca Weiss wrote:
> The USB controllers on sm6350 do not retain the state when
> the system goes into low power state and the GDSCs are
> turned off.
> 
> This can be observed by the USB connection not coming back alive after
> putting the device into suspend, essentially breaking USB.
> 
> Fix this by updating the .pwrsts for the USB GDSCs so they only
> transition to retention state in low power.
> 
> Cc: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Similar to sc7180 & sc7280 patches that have been applied recently:
> https://lore.kernel.org/linux-arm-msm/20220927170516.zrkzn3xl7oedzi4l@builder.lan/T/
> 
> @Rajendra Nayak: Maybe you know a bit more about the internals of
> sm6350&sm7225. As described in the commit message USB just stops working
> after suspend, with this it comes back after wakeup from suspend and
> continues working. If any details in the commit message are somehow
> wrong or I can add something, please let me know!

ah right, this seems like the exact same case as sc7180 and sc7280,
the only additional thing to mention perhaps is that these SoCs
only support CX RET (I don't know but I am guessing they don't support
CX PowerCollapse since you said your change worked) and hence there are
no cxcs entries populated.

> Thanks for fixing this on sc7180&sc7280!
> 
>   drivers/clk/qcom/gcc-sm6350.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index 69412400efa4..9b4e4bb05963 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2316,7 +2316,7 @@ static struct gdsc usb30_prim_gdsc = {
>   	.pd = {
>   		.name = "usb30_prim_gdsc",
>   	},
> -	.pwrsts = PWRSTS_OFF_ON,
> +	.pwrsts = PWRSTS_RET_ON,
>   };
>   
>   static struct gdsc ufs_phy_gdsc = {