Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp750150rwb; Wed, 28 Sep 2022 08:38:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45/fmkWvZ7PdA5OqH8+nxShBD4vUBPYgWKhPpnlYEswsOaVP9EGRHVN2EKKsXVG5P9+l/I X-Received: by 2002:a17:907:a40f:b0:782:666c:95f7 with SMTP id sg15-20020a170907a40f00b00782666c95f7mr26933181ejc.731.1664379537891; Wed, 28 Sep 2022 08:38:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664379537; cv=none; d=google.com; s=arc-20160816; b=TqV8aZMo4IaXvIHqbpQwZb1fLbmANJ+D8ljKcbggta6aasAP95GZLGRvw4C5O9hAMB TW/QZktf0TUMEyIwlvgxtKpY71Ll/16DQeCdBOpvV7tAjCiQxLbo64litbcqD22D2JsC o08arZeVdLYfkaj0DBaOIaybjdidiizKFpa/H6GwIEs+H5uYvZvJxuBio8rJ+YORuqX9 VUPM5OPfeNPc2OWvc6vSzmEvtwYoW3iyUgvL4gQImAG1RGKqBTyP91ZM+eVtvg4mwKy1 qTZwB0c2rSTSwaB1aYo4lGDTRNvrN0OY57na4cGQSHU0TupaaBIdu8+jcKfPImiyg/TG SOKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Z5021MP1akYx7neUqLr5qMs7h+HvHIkKeCKcPGSgbhc=; b=uiYPR/Hv6JW8j03d+I2QUZH7cyrCwhE+jylN69xhHg24CAFzrr09VgpaJWgFvsi0I7 tDOP/zxAXKO3LZad3HkAqhXfrd8kXuo2yL3nHTxtdpmZdI1hGzJX8RpErr/CcXoj1ODI qxi0i2nG3fPTy3j18Z5oLxofLSSXFCGWhYlmZUL50xiJ4w1Zif1/3ywXlcMKw2R6YO9x FFohNT0QjRApZgxo0IeqszeC7/zVbR2oJZurY3Irr8IxPvWAW7xyCEucuHFBxuexFprk Oq1qcUYpTXVGEDYXcVZ89AQZ6l7kXtJMG0zgRUw6Fr55XMobjjwoQfVQvX7MPVQCay0Z XceA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a170906721000b0078281504806si4376490ejk.162.2022.09.28.08.38.31; Wed, 28 Sep 2022 08:38:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234037AbiI1P2b (ORCPT + 99 others); Wed, 28 Sep 2022 11:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233820AbiI1P2J (ORCPT ); Wed, 28 Sep 2022 11:28:09 -0400 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B55C88B5; Wed, 28 Sep 2022 08:27:52 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id bk15so12606035wrb.13; Wed, 28 Sep 2022 08:27:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Z5021MP1akYx7neUqLr5qMs7h+HvHIkKeCKcPGSgbhc=; b=r0HzMbJP7JoTurQw8kPB+v/mi3d4sqAlXmwD2lZ/uZ2CWi8Novbk5wGu6c+EMSI0Iw uHGwXUPe40qgloD5JOAEAKhMq7vlLYMWHU7/XcXjrLIcXuZOlwrBdtpgMrew05ZbDaUb Z2Wp0eDfIJiorcRcy0t+H4OFa7DHk47m+ofW4holLRCQPNdBBfE3r09FoH/FGFlFgkYy Kw8QEUvWRA993oqP5be8clsqd6UnLnytnNmcpUX7c4kAs2HKziU45qhScCCVMkbo9oQ9 ENWcB4xuFcX61a5RrBDoQwDsqoyDNj3GwRzbxWNR4BmSF2lIKEmAp2e5MxYoFIjXleMq Y8QQ== X-Gm-Message-State: ACrzQf2Ictbli9SMJ92k++HF6yU1Ig2v9FiYtyLsqo4ziq7Yj+iC9jJ9 DZedG1xIoz190fyDQHAIJQqu31NOo48= X-Received: by 2002:a5d:4741:0:b0:22c:c1a2:812d with SMTP id o1-20020a5d4741000000b0022cc1a2812dmr5779270wrs.220.1664378871204; Wed, 28 Sep 2022 08:27:51 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id m67-20020a1c2646000000b003a342933727sm2030782wmm.3.2022.09.28.08.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 08:27:50 -0700 (PDT) Date: Wed, 28 Sep 2022 15:27:48 +0000 From: Wei Liu To: Miguel Ojeda Cc: Wei Liu , Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Matthew Bakhtiari , Boqun Feng , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron Subject: Re: [PATCH v10 08/27] rust: adapt `alloc` crate to the kernel Message-ID: References: <20220927131518.30000-1-ojeda@kernel.org> <20220927131518.30000-9-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2022 at 05:25:55PM +0200, Miguel Ojeda wrote: > On Wed, Sep 28, 2022 at 5:10 PM Wei Liu wrote: > > > > Missing safety comment here? > > The standard library does not provide safety comments for all blocks, > and these are essentially copies of the infallible variations in the > library, which I kept as close as possible to the original. > Okay, that's fine then. Feel free to keep the RB tag.