Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp792739rwb; Wed, 28 Sep 2022 09:08:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6I02FYbGXobzKhZSsC0TQzUO58JacDA2yJwiNLEcGzDzRJnZU6ykhoniMSvcouRbMOoMym X-Received: by 2002:a17:907:3fa1:b0:782:e53:7ab7 with SMTP id hr33-20020a1709073fa100b007820e537ab7mr28408211ejc.144.1664381339282; Wed, 28 Sep 2022 09:08:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664381339; cv=none; d=google.com; s=arc-20160816; b=Pi9kCqnUHAsfRM7FP3/GDq0MnmFcLkk9jJeSxj2QxBTANNgIQoJH6EIEn6rMu0JZK1 D6lRB/JYhD+MDT68xZ5aZxN4oHKRJbCOhhuYEGR67g4VhjnXBUooZWu1zP47QnDmcaAR idE2x3SZEh4kDvPZvgfXx4b8eY568NckPIOMDAf7YGay1iBz6ruBcVwmc5YIoufaW9A9 XpYKWzjmB0DiSL221slF09CNZa8v3S/kqAFxHZOCaq2JjWrMVvD2N7aDBCs7v2zRtMme pB1ak8k/aAHLGCZWaI7uQT3r8JZIO8oDcQH9MX3EoKak5Z1PUFEubm4Tzd23lXnUzNpt XACw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=K+jbjc09DvdLJcy4Thzzh2ay02sErQC/GfQnNm8hrTg=; b=vvkKi35Q8EHh8cS3UC2F9vRcEHjJ9C4hIopGTWcB/qXEmAsjgo4cLkLBdJztci6hJY MWI+gW/sf1KC477krJy6EF1WtSdERWnN5xzklDTTQXbeyJP2jkzTJE5z5cC5tJxJRdT/ TllHCx39QfSNcv577dgHQcGsT7FRh+iyHjhTOzDudAQRh3UYh6+WXeSDKqcTzSkGhRnD zaJQqJPSb7byqK3SH85pb/xwj0sdFOMDu88bT9nD776oiWng+B24cnH2s9rJXvur9vkC lDsQanl26p0E9VNDZRLidnyCSUgXaGFBTvl87ORgqjeaSduITRNUhd7uvVthbNSXfxwy VjDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=A6DnVDZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q27-20020a056402249b00b00442785a4226si5320576eda.258.2022.09.28.09.08.32; Wed, 28 Sep 2022 09:08:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=A6DnVDZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234000AbiI1P1B (ORCPT + 99 others); Wed, 28 Sep 2022 11:27:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234222AbiI1P0g (ORCPT ); Wed, 28 Sep 2022 11:26:36 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2C735F7EC; Wed, 28 Sep 2022 08:26:06 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id p10so398487iln.4; Wed, 28 Sep 2022 08:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=K+jbjc09DvdLJcy4Thzzh2ay02sErQC/GfQnNm8hrTg=; b=A6DnVDZE9AoTQrtk6g5BKxUQfRkdjGz/YL1tMBBRR8CgRRdjwxe14GLF+Hi3nx/hkR xAMPgcQUGisNxmIkdq0rSZNza7G4JBpG4HZrY8FYAWHP79G5jz+Ne4SpkIRgaN8tvOms L/sy8WzVAvfuB2mWWCkblqFYQdbo6DuK1W3dGP1Ib7KI5OPZYwXdTSHximEqs4p6Ki0O PGl5FDmZQ2tMHVOvkAv5mera/NMB0HsFAfve9Cm96FDCbamMQZPg7IELcKWb6sEw2J+N qRDTTKM3pDiJlUkZ0O3ifqC9vN+L1g9brWa4X/ftSTUnRnme2FDiUKu1hrJEPtpB0rLj 7L9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=K+jbjc09DvdLJcy4Thzzh2ay02sErQC/GfQnNm8hrTg=; b=PaTwj533J7/QBE0cjvCbUM5zFyPhnTA4e8xJrQ2P5gsaSEr/rn9+n8vs92lexM2vvC jD9W2fXqq+11qd8YrojOZSao59LS1zz3DM6YmrvOc/Hq3jTgtirpcIKX/IY614QkX1CS Rag5RGCMtH66AOoA9J/25ikwXp0YybTI/xCfKmY/bvN9Di0E9RcPcJgG4yJSv1WvjMVX pF6tLdBtSPXik24Y1axJHZzkPhvG23ACCRks6bRu7DqwKbcf6QY0llkre1vFsexc8iWQ gIk+DyscS7Vkn2bgQkHEEcsG2Zrns9N0Kb0EGzfuMfClIY1AW3aL4cGXk2d4dDHLZKXC rLPg== X-Gm-Message-State: ACrzQf2t2s7SpuTo/Gxwy++Q5AwBVjys1tIsvKrUGthDBUsAmLrs+Nkr +G7pIB9UuhvgoUOKzIev/sgHzr24l1f7yuofCUFGiLDSpzg= X-Received: by 2002:a92:c569:0:b0:2f5:927d:b61a with SMTP id b9-20020a92c569000000b002f5927db61amr15790847ilj.151.1664378765811; Wed, 28 Sep 2022 08:26:05 -0700 (PDT) MIME-Version: 1.0 References: <20220927131518.30000-1-ojeda@kernel.org> <20220927131518.30000-9-ojeda@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Wed, 28 Sep 2022 17:25:55 +0200 Message-ID: Subject: Re: [PATCH v10 08/27] rust: adapt `alloc` crate to the kernel To: Wei Liu Cc: Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Matthew Bakhtiari , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2022 at 5:10 PM Wei Liu wrote: > > Missing safety comment here? The standard library does not provide safety comments for all blocks, and these are essentially copies of the infallible variations in the library, which I kept as close as possible to the original. Thanks for taking a look! Cheers, Miguel