Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0841d1f-fcc1-f307-7e2d-b9cce534455d@intel.com>
Date:   Wed, 28 Sep 2022 08:48:41 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.3.0
Subject: Re: [PATCH 3/5] selftests/resctrl: Remove duplicate codes that clear
 each test result file
Content-Language: en-US
To:     "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
References: <20220914015147.3071025-1-tan.shaopeng@jp.fujitsu.com>
 <20220914015147.3071025-5-tan.shaopeng@jp.fujitsu.com>
 <bdb19cf6-dd4b-2042-7cda-7f6108e543aa@intel.com>
 <TYAPR01MB6330988D96E4CD00C9A03DAA8B559@TYAPR01MB6330.jpnprd01.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <TYAPR01MB6330988D96E4CD00C9A03DAA8B559@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGxqbVRaN0gvL2lIbXpyN0dhUi9xZXhvM3Y4ODF3TXhSU251MW1TZ2pzcG9z?=
 =?utf-8?B?WFRoSzQySmgvR21uZUcyTWZjV1UwV2h4NWNyOUlkYk9zSWh6VVNseTBPMkNJ?=
 =?utf-8?B?bWd5SUEzRnovSG1iOTBwYVZRbFFuWTZrbGRtMXREVGlXeWFjc0ZGT09UN0lz?=
 =?utf-8?B?di9ZZXNNRlI0M1RKeEE1UE0xWFQ5R01JV0VxYXlHK0hybitLb2cyZlNtUDJJ?=
 =?utf-8?B?VDVtVzZHYWU5YVpjTDEvK2pyUFNWQXliamxBRjlhbEcvRmo0Uk5SaFZtN2VP?=
 =?utf-8?B?UnlhR1h4eXZxUlhCOTM2WEhFam1lRmdrdDdlL3lobmZuSkNNOC9LS2RHM05a?=
 =?utf-8?B?OTErT3pDWkZldnBack1xRGp0UU1BNWF4YTd6QTh1eHNPUWsrTTdEbFRqeHBR?=
 =?utf-8?B?S1Ftb0s1akV2UU54L0FYd2VSdG9nTEIwQVpPU3dreVp0K0EwOStFbGdSM3RW?=
 =?utf-8?B?UE1iUENRcGJ0OHVnamxnNVAwaE84MnpsalNIYml1ZEVyMmhtekJydjhWTkMr?=
 =?utf-8?B?NjNLUHJpZURzeVBXZm43UnFVd0xldmpWdytkRWE3d1hzRTBlaXJUQm1YakxY?=
 =?utf-8?B?cnI3LzFPdWpqSXk0K0NEVGpMRnBPcUNxenE2SnF6SlNYVlhLejNLa2gvWjJS?=
 =?utf-8?B?M1p1ZWFVd2V1UlRZaldBckJuTXpoUkFVT0Y0RSt5SUZwRDI4U2xWWEJDOTRy?=
 =?utf-8?B?WjlkVVdIN1pHdUcxcFRzSC9jSjMwekxFK3FaZnFWRlR2eEJaTzFDc1pRajNW?=
 =?utf-8?B?SVhjcGU5Z1EwNU9RYit0MnRSWmtVQlZtK2FBM1QyR3FGS1J0bnhaUHJyT0xU?=
 =?utf-8?B?RVRwUmdYbHRJWk9BcjF3WlpnV0p6clFjWFRpN3JYUXl5dkg1OGthcnlQZnAw?=
 =?utf-8?B?UFNvYkVGQkVPVzVhV0taSUordVN5K3ZPWm9NUENnUkE2NEVSbndqY2lwNzFp?=
 =?utf-8?B?dGNCZlBDb1Y4eElMcWQ5dWVwT2FiMlMxT21xVUJyVDRVV1pBczlaZWFkRkJC?=
 =?utf-8?B?YUVDekJ1a0ZBZ3VrZkZzTkkrc2VMb2tnZURpUG43N3kxN2NvaytCaXNWTloz?=
 =?utf-8?B?Mkd5TXpsUk00MHNPaVhPSkJ5aW5sWllNdlVRNzVhUVQ2dFBOYWVkN09RaVRO?=
 =?utf-8?B?NC85dXNjWkUvWmxmYWsvc1VXSUFjWUZqQUFLMjkwN2JSSEE5c1p6SzV5WXYx?=
 =?utf-8?B?VlRGZjNqbVVuVWxOWnJkNXpvemJwMkxsYzdOd3pCb2Q4UHFUZ2Fjem5vbkdM?=
 =?utf-8?B?WU1tRnUxWHVzT093cm9NUFczclBya3BqRXhLVllwQmY5SnBFTk5ZTTAvWml2?=
 =?utf-8?B?ZGZESXNCcDB3SE8wSlNaa2NoVUJzZXN4dWtQZmpxWHIrVHVFNmtabFlCMDFy?=
 =?utf-8?B?anhjNkU1SlBXclBYT1I2S3dSVUpUTUdXSXJMdUhHb0orYUxmZUNTVlh4cm5u?=
 =?utf-8?B?QSs0dGJCV0ozb3M4cjhCdWxrcU93cGtJanBRb1hXUGlxZEREL0NXOFI5d3NG?=
 =?utf-8?B?cjdxcHFTUU9oNjZHV214bGFWL2R3UU1zeVhrb3ExaWtDYlZtTzJDMkRyMXVw?=
 =?utf-8?B?ZG5Kdm9iMmExOEFaRkIzZTFFUUdUd29LeWJoT2puR3RPbWVZVC9CZXRGV3hs?=
 =?utf-8?B?VHRmZmw2ZmxHbzN2SmhoakZVVjdmRFBQSDFTK2xsSTdYWi9hVkZzRWZIZ1py?=
 =?utf-8?B?RlV2MFBVVExkTFBSYlh1c0pwYmZpQzN3bkpqQjd0OFlhQVpiTEhQMzMyN0kx?=
 =?utf-8?B?QVh1d3ZVeENLQlBsYm16eTVKMEZpcjdjS1N5ajZOYnduQ1hNZ3V1ZkpIMkFE?=
 =?utf-8?B?Nmk4NEM2S2ZkbVdZc3c4Wnlla2EzUGUrdjgvbmd4MjRpQ1BRK0lSZmNleG5h?=
 =?utf-8?B?WHk1R29FQkYrYVA0L3ZzTlFDSDcwYlFoZFpoN1JUcFVHSUwyMGtGbEc0SXF1?=
 =?utf-8?B?OHUvSCs1QS90VXl0enE2bFBYdURweE53dWNLTnhVUjhDRUR1ekwrZW0reG1r?=
 =?utf-8?B?ZjBpWElCeDB0UmN2SjE1bGs3Zis0bnl5Q01SL1VyM04xb0NSdGtHWFd2aHM4?=
 =?utf-8?B?QSsyR2pwTkdaZXJLQWtoVGVDMldZc29ZZm9zQlBvcFFGZ0J0K0Z1NHhXcHYx?=
 =?utf-8?B?YVlOWURVSU80NDZ1UGVxajhubEZzL0lsc20vY1c2OGpGSW9XbGdKQUN0RUZi?=
 =?utf-8?B?dnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4246948d-84e4-48d4-4ed8-08daa168ebc8
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 15:48:43.2352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rkHXcupSxqJ8o+995ND930EIgqSo1Vzxn+dwqmBv+7a7MfLVTyGmQhUgBSy2zDKegHL23T4VvPks/XpB3PcGxenvf7aUVGUEuCrYMMno9yw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5930
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 9/27/2022 2:01 AM, tan.shaopeng@fujitsu.com wrote:
> Hi Reinette,
> 
>> On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
>>> Before exiting each test function(run_cmt/cat/mbm/mba_test()),
>>> test results are printed by ksft_print_msg() and then temporary result
>>> files are cleaned by function cmt/cat/mbm/mba_test_cleanup().
>>> However, before running ksft_print_msg(), function
>>
>> before -> after?
> 
> I think it is "before".

hmmm ... if cmt/cat/mbm/mba_test_cleanup() was run before
ksft_print_msg() then there would be no test results to print, no?
The current implementation runs cmt/cat/mbm/mba_test_cleanup()
after ksft_print_msg() ... albeit twice.

> 
>>> cmt/cat/mbm/mba_test_cleanup()
>>> has been run in each test function as follows:
>>>   cmt_resctrl_val()
>>>   cat_perf_miss_val()
>>>   mba_schemata_change()
>>>   mbm_bw_change()
>>>
>>> Remove duplicate codes that clear each test result file.
>>>
>>

Reinette