Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alex Zhu (Kernel)" <alexlzhu@fb.com>
To:     David Hildenbrand <david@redhat.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Matthew Wilcox <willy@infradead.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "riel@surriel.com" <riel@surriel.com>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH 0/3] THP Shrinker
Thread-Topic: [PATCH 0/3] THP Shrinker
Thread-Index: AQHY0wWiHnM2ldg5NkO9z8Pn4WWMYa305SCAgAAh24A=
Date:   Wed, 28 Sep 2022 16:22:34 +0000
Message-ID: <73C02F96-49C7-4C1F-AF10-F6A61F1D68A4@fb.com>
References: <cover.1664347167.git.alexlzhu@fb.com>
 <c4462af8-80a5-6cb6-8bfc-0e7ff1da6856@redhat.com>
In-Reply-To: <c4462af8-80a5-6cb6-8bfc-0e7ff1da6856@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KYqxgSEZKY+ITuoS2uqORK4VmhkXjojfcJs6yO99aDXz9Xk2iQ8ueE4In9l+?=
 =?us-ascii?Q?eWwyQFPa335Q9TVGSJ9Q7q6H5mFoJpIol9rTubgkrum4kgIrwqc1FdUZ8NN4?=
 =?us-ascii?Q?o6aHgxwVrenN8USTnWLzM6OrRSMxWdRpJoHgQTlcoW7wgJt/AHZFs5ULYJis?=
 =?us-ascii?Q?vU3zfh5etza79A/NoRuGLVe01AosomhNHLXl1ylsxbJ7+q+R1IAuxO9Xdoxu?=
 =?us-ascii?Q?JlzIarEz98YslcOvRFXFigWiU65nP9kjxe5c8X9q2uL2Zd6buGqjAp1Xbp4B?=
 =?us-ascii?Q?buomHeV6c+0ciM+KUF4GpruAhwEkn45RP28lV5qhwOeMWZEzprrKeV3504Ul?=
 =?us-ascii?Q?Cxz6PYtZmHnkYHR10CCB2G3yS5JNFIu7mOYoEBBX3NW0j5J8Ag1O4kSQiZm9?=
 =?us-ascii?Q?5ASWmj+OwO8XU0zMQAyiqmtXZSKZUKwvoS1wsSZfElp3371R1K39z1kjkf6O?=
 =?us-ascii?Q?CTbnN9gTI60/d4mmpR9yd/OZrujRb2kR2NlvJCc24VGtWk4vIZ4KKIsHdH0X?=
 =?us-ascii?Q?V9LLABxgD9+fHeVcMF8Hjc6xaHW9yNNoQFGvA3Yll+7VBiMQUdPASr64Fgvd?=
 =?us-ascii?Q?EFwvwZdRQMEvOtX443bKKX/Rak8rLFweENkiq8DxR8pSSFL5sXupimxlih32?=
 =?us-ascii?Q?AYsmpAv8lc7GRUJeF5A5+SZdB2Whk5DJD8c8Ir5jBT7UbZXV9Rh/78kyo3vB?=
 =?us-ascii?Q?HOK7YAxpLw1VMuYW1Hh/T0Nx7f+d4ZA6jxxmknKvNR3pb8bxl9ybS3iQEAg8?=
 =?us-ascii?Q?UJEzj/Ou7NjfDRIc7JRe5KHaKbp5E1ncA1dMFKsUsFyuznxtgRX+RXpMIuE7?=
 =?us-ascii?Q?hVq2VpwT8wjMJw9FoC5FSY39dakmpw8oEEjI788yXT8le/FTBB/t0VuCnW1B?=
 =?us-ascii?Q?27YYxgSQZyvK420RmNaxyHrrU4RnvdjjXxrxVxHN3+TIkZhJ+sUik8rdimwm?=
 =?us-ascii?Q?t4qHG05s9ZRv4a4hySPMvgohKn5mmxKdCGK2+bb+QQ42ttMXDPNLaPJb1RDL?=
 =?us-ascii?Q?6iBt5nhe1TbmLObJt3i4i8UN+vZbwTzhD4LmTDYR4hzhf1FwfVYvn486l7qY?=
 =?us-ascii?Q?eFSEwVnbjmwrlxQXSsKlwevcwn7Y/AKYZw3nxe9O5/gI1tPZrmLfaUk0st1V?=
 =?us-ascii?Q?cS9pZqd1GO8txX4iFkP11rrpTHfA/wlrR//JIg+VVg5WP9W20v2MqDo8kO6M?=
 =?us-ascii?Q?Nu/t4gF5XDre/QVXlc8WgRH/8FY22DxyexyJ41y9ud3JyquWXAxlKEy6ze85?=
 =?us-ascii?Q?S8j+r+EYhZZwcRAQrbdzS4rwCfDHICjZlgtMQma+DEDNR9F6sbGtR7AKwREu?=
 =?us-ascii?Q?jsqPbjhU1Si4TW+kc8BdWQxidUl7oyrJZDCxUGCvrMG+QJyehcsekqsnuj/4?=
 =?us-ascii?Q?GGWkuIOnraiGujbTwM9fRwRWxtazGh8FuKNHorJ4sBRSpptLSxhaR+AR/Jd3?=
 =?us-ascii?Q?/O5IQul9UMernV8h/83jJ/LdeVyGigX0JPTgjh70EfQqOmnQRqtwGVnWQODR?=
 =?us-ascii?Q?OUFQod9CMUSj1cfXCP0VaXBuHEw9C9MZlpXWstFvreZiwqlPKIui/az6YVN0?=
 =?us-ascii?Q?p3Sw7t9a9DmBTkhd6LjVb75KgmaaWf9efrCUsn7aYF7it+LcShP6mFcDbFn5?=
 =?us-ascii?Q?UI3h/luUlY24srVW98rVhBQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F94155F438281F409E5BAEE71169560A@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR15MB1734.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62360618-bfe1-4cee-16a9-08daa16da6d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 16:22:34.8549
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ijjixC0bEqff9kYqplGacedvUkifzWM51/1lH8G9PHJbl2d4212F1wUd7VxMjLxn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3430
X-Proofpoint-GUID: i4W5bj3yOKBhNd5WIywyArZSM4PY4r5t
X-Proofpoint-ORIG-GUID: i4W5bj3yOKBhNd5WIywyArZSM4PY4r5t
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-28_07,2022-09-28_01,2022-06-22_01
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry about that. The diff to the RFC:

-Remove all THPs that are not in the top utilization bucket. This is what we have found to perform the best in production testing, we have found that there are an almost trivial number of THPs in the middle range of buckets that account for most of the memory waste. 

-Added check for THP utilization prior to split_huge_page for the THP Shrinker. This is to account for THPs that move to the top bucket, but were underutilized at the time they were added to the list_lru. 

-Refactored out the code to obtain the thp_utilization_bucket, as that now has to be used in multiple places.

-Multiply the shrink_count and scan_count by HPAGE_PMD_NR. This is because a THP is 512 pages, and should count as 512 objects in reclaim. This way reclaim is triggered at a more appropriate frequency than in the RFC. 

-Added support to map to the read only zero page when splitting a THP registered with userfaultfd. Also added a self test to verify that this is working. 

-Only trigger the unmap_clean/zap in split_huge_page on anonymous THPs. We cannot zap zero pages for file THPs.

Thanks,
Alex