Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6648ece7-0a8e-2217-0c5a-5d58dd5a012c@nvidia.com>
Date:   Wed, 28 Sep 2022 20:03:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Add Tegra234 SOC support
Content-Language: en-US
To:     Wayne Chang <waynec@nvidia.com>, balbi@kernel.org,
        gregkh@linuxfoundation.org, thierry.reding@gmail.com
Cc:     singhanc@nvidia.com, linux-usb@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220928135502.3458833-1-waynec@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220928135502.3458833-1-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkhuUHBWdDNjcGkrNjIzeEhnUlcvbllQanY1V1VoTHRMRlgyWW94ZWljMFJ2?=
 =?utf-8?B?NzI1TmRMa2UxdnBWTFU4SUUwM3JzeFlJN1FxajNMOGY2UjB1bGVVZkt1RXBF?=
 =?utf-8?B?S0RiaTlubGlzS1piZGlSem9abUFtYjJGWmxMajVYQmx1M2JNWE1CNVRKR0VB?=
 =?utf-8?B?UEU3N1ZWZmNWd01aS2NUSE1XdVV5d0hES1pXdEFyaVlPRU5XMk1oQ3lVNDZQ?=
 =?utf-8?B?THNUcGZrYTZ2b1dqOEkrZ2ZFczNwNGt4cThjTWU0bFdEbTU3c1NqaW93cmR3?=
 =?utf-8?B?RldkR3dYSzl6M1pTYzJJRmRDZGNGTTY1UFRuWTRuOEFFN3VKWWZsdVZBSS8v?=
 =?utf-8?B?K0t5eUlLOW81QVFyVGtNeTJwZzVwS3I5VlMvRUZDd2pTdXVjeThDcER4czlJ?=
 =?utf-8?B?Mk9SS0U5anVXSi9wV0E3YThwZzdJUUJCWlFSZmFOZW1JSm9mWjh1L2ZuZ2R6?=
 =?utf-8?B?blZoYXUwQXBjbXFRQngwejZCb0lkNkF6Mkg3dlpKbnBVSWhERmtTMTRtRnI1?=
 =?utf-8?B?a0tIRkd4c2hSTTQ1YXZwZlBCWXRWaWdNWjN0SjgvNTl3RzJySHBaSUlCb3Fm?=
 =?utf-8?B?SDlPTmNDZ1ptYTU5MHZZMHZBcnJIOEdyZHpyWjZFS3ozYmkzbW10bTJBa1Bo?=
 =?utf-8?B?aWYzREJJcVBQaFNYVm8wWmw1elV5UnF1N0U0R0VyaytDKzlHZmRkTmZaTEk3?=
 =?utf-8?B?SjdpamFROXVlTHBYa3d6SDlDWUZQTk5kRWxQOVpPYWNvSWprdlhCUXJ5NVJs?=
 =?utf-8?B?Smk1ZXpwbGlnQlBVejFxWWU2RTQyYUVNdjgxekFlSkFCLzNnQ0plUFlhSlBQ?=
 =?utf-8?B?c3RVZWNXcS9yODR6VWN0NWovSlU0ck1DTEF5TXZZd2dDVjI5cmtRSnY5bGc2?=
 =?utf-8?B?TmVWZzloZll0a1lMWW9rN0NvQ1JqcFVUZ29PNStRN01YTUdQSnI5SVl3TnFt?=
 =?utf-8?B?ZFQvTS8yU0VOWjkxazFxS0Mwdk5zYkVCMUs3U1JyVUdzV1JyV0c4QS9XbFp3?=
 =?utf-8?B?QkI3NFhDOXVUbyt2UzhvcE9RM0tCSktsWUVhS2lZYktENm9keUM0ck55WGVV?=
 =?utf-8?B?SEFJdzNPdit1SVlEaHF5VFRad3poazVQYlVvMHFhRENCYlZKeWZDc0xXSVdW?=
 =?utf-8?B?OFpSRlpnYkh4emVaTFV0ZWlsd0twelpCbS9CK0RTVWxzSTl3S0hIL2NtZ2hS?=
 =?utf-8?B?cjV2Qi80UHhOQUl3bVRKaFdPdE42MktoNit2dUQzM0lGT0RFUmw5a3MzTTNH?=
 =?utf-8?B?dkxFRXEySEhLak4yU2JDV0V6bHpTckxGNytUb2RHTjhXU3BCb1dkYmd0dzhQ?=
 =?utf-8?B?aHpQaHJMRmd1RjFTcmJKQzFGaVpjQk0rV01XOVFGS3krb2pjVm5ZTStQTDVn?=
 =?utf-8?B?K3d2VWVBRmtRUDlaZkJWTkNFRGI0UlVRTVk3SkZKT1hidDQ5Qm41NXFta3pE?=
 =?utf-8?B?bldEcnZBdXFucDIrN29NMFRBQXFXWDU5RG93SWRCR3BVQXF5VXBXbnRVOGlC?=
 =?utf-8?B?MXd4NEJJa0hnM0dCSlp3N3pWUVRrSFdEWnBPdStoWnM2SU45V0RoWEVJbGQz?=
 =?utf-8?B?N0tOYXhSakpJVUJaLy9sTjZXS2dYUGlpMzVBa0hmM0tMYVFXSXFTV1duSStN?=
 =?utf-8?B?K1VpODB2dkRQcEFHUmRpRlovNjBOb1RMVGIyMHpoVldEaHE2djJOQU56VjFj?=
 =?utf-8?B?ZmllU0xZYU8yY1E3RENkVnpOdi90U3A5TEhZYW5YK0JlT0dJVFZSdmZDWmNl?=
 =?utf-8?B?R2pROE54QWJ4M0VCWm5xNXMvZ2N3bWd2aUswM04rek8wZzl3dEpvc01lcExy?=
 =?utf-8?B?dmt3Vitwem5MY29qZm5LWXVXUUROcVFXVjY2N1dkU2xYeDZqZHA4R1gwclBI?=
 =?utf-8?B?UTBzOWkvbXViSFBMOHoyb2tOV1JKNklOQURySVNaN0ZpeGg4akVycE1pUS9l?=
 =?utf-8?B?Z3VreXFUaVpWMmhTVFhYVUVHL05WV0NienUxT3YveXd5NkE2WkFoeEJIcnVC?=
 =?utf-8?B?N1UwcXlTRWpuakJ2ejc4bDlXRUh1eXA5cXB0aEl0aHI4S2pYa1c1NWFqU2xv?=
 =?utf-8?B?V1pZYStWam5PMmh5dFB0bUpLY0FHQlZjbjJzbGhWc3dDK2s1RDF0a2xWZUJD?=
 =?utf-8?B?a1BvcVdwS1drdnVoRDBnMzFab1B5SjlaUEZ6UTN4bkk3S3J6bGJ6dUw1bkZJ?=
 =?utf-8?B?QTdmQ3JXdzByZ0VCZDlwZDBXRVY2NTVJQm40RVZXOTR1QmNmaVZRSFpvdHFX?=
 =?utf-8?B?SUlkNVk5dkhLTTF3NFNtRHg3Z0NRPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb0a8b8-2b1c-4921-f096-08daa18434ee
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 19:04:02.5612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6x/37Tq82K7iTW0prpfZbRMglQnrIHiomm23UMPjtYgFkMHeFT7FO9Es/o03+bn/x3kW05ZWwFJiHveT+lbTQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4883
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 28/09/2022 14:55, Wayne Chang wrote:
> From: Sing-Han Chen <singhanc@nvidia.com>
> 
> This commit adds XUSB device mode controller support on Tegra234 SoC.
> Tegra234 XUDC is very similar to the existing Tegra194 XUDC.
> 
> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
>   drivers/usb/gadget/udc/tegra-xudc.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index 3c37effdfa64..53277aa5a270 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -3656,6 +3656,19 @@ static struct tegra_xudc_soc tegra194_xudc_soc_data = {
>   	.has_ipfs = false,
>   };
>   
> +static struct tegra_xudc_soc tegra234_xudc_soc_data = {
> +	.clock_names = tegra186_xudc_clock_names,
> +	.num_clks = ARRAY_SIZE(tegra186_xudc_clock_names),
> +	.num_phys = 4,
> +	.u1_enable = true,
> +	.u2_enable = true,
> +	.lpm_enable = true,
> +	.invalid_seq_num = false,
> +	.pls_quirk = false,
> +	.port_reset_quirk = false,
> +	.has_ipfs = false,
> +};
> +
>   static const struct of_device_id tegra_xudc_of_match[] = {
>   	{
>   		.compatible = "nvidia,tegra210-xudc",
> @@ -3669,6 +3682,10 @@ static const struct of_device_id tegra_xudc_of_match[] = {
>   		.compatible = "nvidia,tegra194-xudc",
>   		.data = &tegra194_xudc_soc_data
>   	},
> +	{
> +		.compatible = "nvidia,tegra234-xudc",
> +		.data = &tegra234_xudc_soc_data
> +	},


The device-tree binding documentation is missing for this compatible 
string. Please send a patch to add this compatible string to the 
appropriate binding doc.

Thanks!
Jon

-- 
nvpublic