Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 21:09:53 +0200
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arch@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH v3 1/7] kbuild: hard-code KBUILD_ALLDIRS in
 scripts/Makefile.package
Message-ID: <YzScAYUStPbp9o0i@bergen.fjasle.eu>
References: <20220924181915.3251186-1-masahiroy@kernel.org>
 <20220924181915.3251186-2-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="yisc45JTu+esueRF"
Content-Disposition: inline
In-Reply-To: <20220924181915.3251186-2-masahiroy@kernel.org>
Jabber-ID: nicolas@jabber.no
Precedence: bulk


--yisc45JTu+esueRF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, 25 Sep 2022 03:19:09 +0900 Masahiro Yamada wrote:
> My plan is to list subdirectories in ./Kbuild. Once it occurs,
> $(vmlinux-alldirs) will not contain all subdirectories.
>=20
> Let's hard-code the directory list until I get around to implementing
> a more sophisticated way for generating a source tarball.
>=20
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

> Changes in v3:
>   - New patch
>=20
>  Makefile                 | 2 --
>  scripts/Makefile.package | 5 ++++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/Makefile b/Makefile
> index 57cf4a5bea6d..eb4bbbc898d0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1129,8 +1129,6 @@ KBUILD_VMLINUX_OBJS +=3D $(patsubst %/,%/built-in.a=
, $(drivers-y))
> =20
>  export KBUILD_VMLINUX_OBJS KBUILD_VMLINUX_LIBS
>  export KBUILD_LDS          :=3D arch/$(SRCARCH)/kernel/vmlinux.lds
> -# used by scripts/Makefile.package
> -export KBUILD_ALLDIRS :=3D $(sort $(filter-out arch/%,$(vmlinux-alldirs)=
) LICENSES arch include scripts tools)
> =20
>  vmlinux-deps :=3D $(KBUILD_LDS) $(KBUILD_VMLINUX_OBJS) $(KBUILD_VMLINUX_=
LIBS)
> =20
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index 5017f6b2da80..8bbcced67c22 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -29,7 +29,10 @@ KDEB_SOURCENAME ?=3D linux-upstream
>  KBUILD_PKG_ROOTCMD ?=3D"fakeroot -u"
>  export KDEB_SOURCENAME
>  # Include only those top-level files that are needed by make, plus the G=
PL copy
> -TAR_CONTENT :=3D $(KBUILD_ALLDIRS) .config .scmversion Makefile \
> +TAR_CONTENT :=3D Documentation LICENSES arch block certs crypto drivers =
fs \
> +               include init io_uring ipc kernel lib mm net samples scrip=
ts \
> +               security sound tools usr virt \
> +               .config .scmversion Makefile \
>                 Kbuild Kconfig COPYING $(wildcard localversion*)
>  MKSPEC     :=3D $(srctree)/scripts/package/mkspec
> =20
> --=20
> 2.34.1

--=20
epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
=E2=86=B3 gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

--yisc45JTu+esueRF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmM0m/gACgkQB1IKcBYm
Emmz6A/9GudZhGDEuiScPxyeaDy8UnaNrQ46o6QWmCK7meL9JifsDg33A+C/w2E5
4wTarbibMH1Z2NUx5R8KYUiNFdKHvQmj5tGb5bvUBeEfbBXKFPnINEPRLy5pZd4M
MI0AI/bEmfJBRh9p32D1PpmIQaytKbb+0z8VoVV5rluWWXl8d/QFxxn8sTO3s+21
MYCXrSRP8Jj4qbdZ27uCkCvLHBaKoBLZpzMx7vJSpgmDjIy0rOsbCtNLmilI1bOt
uMOh8ND3sSRQ96Olg7VPsanP3axjpP9DN1FmY8DRAjA2//115mN884P2+hIlEu6j
LiXZXhcyIqyR6nUqC6fhqRKWCaB3FcYBFTT2QE1UJwJcwLAA9TvXkC2nYr8Bn8+B
gDWykOU/s/mws4GBnVSqO85DQkT/9PW1JgD0Xam4gxT+Sl5ETHCWkf8s0w397+vN
jLHyvY9VKUGsqLe0WmKEfScohzVaNV4eKAqCP0jndr8mSpGFQ2ONuYHUPo3NwTGY
rbhjzvE6UEnS0JVaX/BXZtE/tg14MK0jq/lPVbcmEQdFXoRPZdelMGC8i2nuaeeL
sgZ42vXFLJs1qYU5JMB2QxUKlMi3k5KLHZ9i5IEGCFXSdOvDZ6Wx3A1pO1JiimaL
5tD0/FWrjjA3baDGLEDqS/TWQLEoCDmxlDguSl710B6sjYNXfe0=
=RsJ9
-----END PGP SIGNATURE-----

--yisc45JTu+esueRF--