Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f568c82c-738b-c5ec-5059-36659b3f5b44@froggi.es>
Date:   Wed, 28 Sep 2022 18:20:23 -0230
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] x86/split_lock: Restore warn mode (and add a new one) to
 avoid userspace regression
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>,
        "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Cc:     "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "kernel-dev@igalia.com" <kernel-dev@igalia.com>,
        "kernel@gpiccoli.net" <kernel@gpiccoli.net>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Paul Gofman <pgofman@codeweavers.com>,
        Pavel Machek <pavel@denx.de>,
        Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
        Melissa Wen <mwen@igalia.com>
References: <20220928142109.150263-1-gpiccoli@igalia.com>
 <SJ1PR11MB6083113884DD0B3031FE372CFC549@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Joshua Ashton <joshua@froggi.es>
In-Reply-To: <SJ1PR11MB6083113884DD0B3031FE372CFC549@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/28/22 17:54, Luck, Tony wrote:
>> So let's revamp the idea of having another option/mode for the split
>> lock detector, which is hereby called "seq" (based on the original
>> "sequential" naming in [0]). Also introduces a Kconfig option to give
>> the option of Linux vendors have a choice what mode should be their
>> default. While at it, fix/improve the documentation about bus locking.
>>
>> [1] https://github.com/doitsujin/dxvk/issues/2938
> 
> Why not just use the workaround suggested in that bug report:
> 
>     "so manual switching from default setting to split_lock_detect=off helps as workaround here"
> 
> If you add this extra mode, I'm going to argue that the kernel default
> should be "seq" rather than "warn". So these game players will need
> to add a split_lock_detect=off (or warn) option.
> 
> Has a bug report been filed against the God Of War game? Probably worth fixing,
> the performance penalty for split lock is only going to get worse as numbers of
> cores keeps increasing.

It's not just about God of War specifically.
There are many old titles that will never, ever, get updated to fix this 
problem.
These titles worked perfectly fine and were performant before.

I completely understand that split-locks are bad, and developers should 
fix their code, but applications paying penalties like this really 
doesn't make sense for the Linux desktop.

If server-oriented distributions want to set their default to `seq`, 
then that's completely fine, and I would completely encourage them doing 
that -- but I really don't think the Linux kernel should be essentially 
breaking compatibility with these applications by default and throwing 
desktop Linux usecases under the bus.

- Joshie ????✨

> 
> -Tony
>