Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Armin Wolf <W_Armin@gmx.de>
To:     hdegoede@redhat.com, markgross@kernel.org
Cc:     andriy.shevchenko@intel.com, rafael@kernel.org, lenb@kernel.org,
        hmh@hmh.eng.br, matan@svgalib.org, corentin.chary@gmail.com,
        jeremy@system76.com, productdev@system76.com,
        mario.limonciello@amd.com, pobrn@protonmail.com,
        coproscefalo@gmail.com, platform-driver-x86@vger.kernel.org,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] platform/x86: dell-ddv: Minor style fixes
Date:   Thu, 29 Sep 2022 00:15:01 +0200
Message-Id: <20220928221501.3823-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Fix some style issues found during review to improve
code maintainability, no functional changes.

Tested on a Dell Inspiron 3505.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
Changes in v2:
- change commit message
=2D--
 drivers/platform/x86/dell/dell-wmi-ddv.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x=
86/dell/dell-wmi-ddv.c
index 6ccce90f475d..699feae3c435 100644
=2D-- a/drivers/platform/x86/dell/dell-wmi-ddv.c
+++ b/drivers/platform/x86/dell/dell-wmi-ddv.c
@@ -1,13 +1,12 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * dell-wmi-ddv.c -- Linux driver for WMI sensor information on Dell note=
books.
+ * Linux driver for WMI sensor information on Dell notebooks.
  *
  * Copyright (C) 2022 Armin Wolf <W_Armin@gmx.de>
  */

 #define pr_format(fmt) KBUILD_MODNAME ": " fmt

-#include <acpi/battery.h>
 #include <linux/acpi.h>
 #include <linux/debugfs.h>
 #include <linux/device.h>
@@ -21,6 +20,8 @@
 #include <linux/sysfs.h>
 #include <linux/wmi.h>

+#include <acpi/battery.h>
+
 #define DRIVER_NAME	"dell-wmi-ddv"

 #define DELL_DDV_SUPPORTED_INTERFACE 2
@@ -52,7 +53,8 @@ enum dell_ddv_method {

 struct dell_wmi_ddv_data {
 	struct acpi_battery_hook hook;
-	struct device_attribute temp_attr, eppid_attr;
+	struct device_attribute temp_attr;
+	struct device_attribute eppid_attr;
 	struct wmi_device *wdev;
 };

@@ -153,8 +155,9 @@ static int dell_wmi_ddv_query_string(struct wmi_device=
 *wdev, enum dell_ddv_meth

 static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *=
index)
 {
-	const char *uid_str =3D acpi_device_uid(acpi_dev);
+	const char *uid_str;

+	uid_str =3D acpi_device_uid(acpi_dev);
 	if (!uid_str)
 		return -ENODEV;

=2D-
2.30.2