Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85faab48-13d0-1e6b-302b-b74d4d7acb95@renesas.com>
Date:   Wed, 28 Sep 2022 16:14:19 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add bindings for Renesas ProXO
To:     Rob Herring <robh@kernel.org>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-clk@vger.kernel.org, sboyd@kernel.org,
        mturquette@baylibre.com, geert+renesas@glider.be
References: <20220923205251.1387-1-alexander.helms.jy@renesas.com>
 <20220923205251.1387-2-alexander.helms.jy@renesas.com>
 <20220926230438.GA3128861-robh@kernel.org>
Content-Language: en-US
From:   Alex Helms <alexander.helms.jy@renesas.com>
In-Reply-To: <20220926230438.GA3128861-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGY1QVI5S1A3OGVzS2FQNTJUalJxTlYxbnRsVVI1UUNMWlRmVGtzajJBc3p4?=
 =?utf-8?B?VmpjbGV1UWJjdHFCbjNUV0pxUkR5bUtZWmMreUZvS0x2aEZpOGRXZkgvWk1U?=
 =?utf-8?B?anpOWlg2VExiTmROcTJ3RTlRdng5ZVQ0YjVoT1VoVTBsTzE1d3JDNytjaisw?=
 =?utf-8?B?UzZLMFVnem9ZNDNmTzBTcE5xS2gyY1RmV1E4NVZWOW1lNmNWc2YycGtRYTJ1?=
 =?utf-8?B?SzduVVdZdklYbTRXUDNqcDZxTUZtUXFTVXdwY3VVTU5YdlRLSHZLaG9LQ2ZD?=
 =?utf-8?B?N3BiZmkvUW0rK0QwbG4za3gyRGt5L2FEYlBoeXNCMk9kcVM5a01uQ3poNWZ5?=
 =?utf-8?B?ekVNdTMyc05ZaUFUSng3b1hmWk1ManhjNzVsVCtVMnB0UWJrbmNKVDUwVlps?=
 =?utf-8?B?NmVRRE1JRlk4S2NYTWVGNldaWHNHMU5GVDd0Mk9SWWJCNmc4cHNLb3A3THhG?=
 =?utf-8?B?NzVhaVFFTVM4Zmp3RmJnTWM5WGRWVlRZVldaYXk5T3VCcGE4WVhMRnIxbGps?=
 =?utf-8?B?WmJXVDgyNERBWlJOcmVwTkkrK3lwZC9oK1UxdG91dDcyVW1oeEVBb0ltd0hE?=
 =?utf-8?B?bzBSTElIcGp5d2ZqOVdxTHRYa0Q2c2lRbTRnM0V1bHViRUhkNG5UY1hxVEc5?=
 =?utf-8?B?UFcyMTA4b2c1bEsraWpiNUVid2Z2UUpqakRSMXZkM1R4TGxyeVBkSGJGSXI1?=
 =?utf-8?B?NGN5Yjk0cGxDUUlVT2R1S3RycTR0YjZFOGdiR3IrMFFxWThGODN4cmpac29h?=
 =?utf-8?B?aTBKZWs5Q0NjLzBDOGhUMEtMaExoZXFETXJwdXV1ZEwxa1laY3JjR1BoVitp?=
 =?utf-8?B?QnBHb1hkVDlBeVQxc2ZlRGRJOG1OKzNUV0FVM3JkVzBWdlVYckhxZUNOeXho?=
 =?utf-8?B?c01Mc2krdjREYmJEeVBYUkxMRGFPNnp2ODhRS1BpVzArdnMrcndiOFJFbkZU?=
 =?utf-8?B?d0F3K2FnWW5jT2NvdXZ4TFptcHpzOWZxanBKY29YZVcweEphWU0yZG9nSkJK?=
 =?utf-8?B?VVdHTiswYTFLMzlWSzYzNjRMdHd2UEJ2Z1R4OUxsaFY2Uk50TFp3YnlKWk1Q?=
 =?utf-8?B?dDcxMnkwMm15Rjdsbkt1dlh1VGFRcEc0QzBHTG1HWkNmQWREeEFqV091MmtV?=
 =?utf-8?B?ZWlCNFQ5RjRsNlpkd2lRRzZmNHlsQWI4elQ5SzgvaW9DUkluVjVDV0c4cTRu?=
 =?utf-8?B?bUQydGtXZVgwQStvZmZwSDFORkI4UFNJRnFVMnd4ZU03UG9vaEEyVThwK2dG?=
 =?utf-8?B?Sy9oR0FNc21XS0UxNWt0RkJrbFdoU3dFNm1VdWRlV1Q5ZkRKNS95NmhQb014?=
 =?utf-8?B?TGIyaUZSRVBwanorR2puY0xzb3puVXNXak1pWGMwOTNwRmNsTDlMRjMwbnZo?=
 =?utf-8?B?dTk0TStrRU54UmRSeVhGOFl1b3g1WjBMaGNmbjNZbHh3aTVaYWdlKzYrdjB5?=
 =?utf-8?B?YjZqUUQ3dVE3MG5oSno5dmI2ZUtHNENaMEZINHpjZkJ1bGVsaUE0dlhNVmd5?=
 =?utf-8?B?M29CQVdBbmNveTlvNjNqZlA0N25tSm9McUtDanJtUk5OdkYzMnNLVlVKK1dQ?=
 =?utf-8?B?TjBNUTBORG9IRFlhaSsxZ0xDVjkxWGg1NzdES3ZaODlQeHZVQmZ3emFyMzNu?=
 =?utf-8?B?cXJGVW5ILzRMUHhFbDZKeThiNVArRmlmb2lIc3lFRXpTSnp2d09YcnBDYTh2?=
 =?utf-8?B?Rk9UZEpXVndqSHV6Qm8vbG4vekdCNEIwUStGZ3E4NytTZUc1a3FXVlJONnR3?=
 =?utf-8?B?TWpSMCtjWFdIeGFhNUJOMisrcm5VUjR3MHhKSCtTNjE3Y3JVOTQzNG55YWZn?=
 =?utf-8?B?R2FMUDhSYU5mTUZkTk9ZblZPS0plZVZZQ09zZW9sVWZyblM5Y2tXSGxzV2J0?=
 =?utf-8?B?TWUxbW1ZcDBUdHhURHNOb0RzMS9YK3RrMmdNTVhZcmhLZEUwa2M2eGNLU1pj?=
 =?utf-8?B?ckRoUnJDZkpHU1NvUVEvd01WYjYyYU9JVUg2Z2JmeXdIRnVObnh2ZVYySVN1?=
 =?utf-8?B?M3VmZFhxeUptNFdvTWNSYyt1QVRjcWd4RFN6WmtUVjN2WDBSU2RQT3R6RStW?=
 =?utf-8?B?MmVYTmdzcG15c1NpZXh2TGdMVndOYTBKU0dOV015WitNcUw3QWV3Uk85TGVV?=
 =?utf-8?B?THBFeWlKZk8vZ3NidWlkdjJHQzhGRWxtVnVEZHhVSkRDN0ZiYTkwNTc1dk54?=
 =?utf-8?Q?aopIuDF+mQSxRseWe7Dc1xc=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78e2c611-07ee-4788-ebb7-08daa1a72f64
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB3892.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 23:14:25.6224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h3o6x1mgQ9jJgFhHzwxPIMPYgHfXzvg9V+DHdWbbUFj4hPD5G9wlyHsSN6Lz0ZFdCEYhNPyafwAG8nwXDVjFIhtSGAGqycV45tOBfgS6FO8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB10380
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/26/2022 4:04 PM, Rob Herring wrote:
> On Fri, Sep 23, 2022 at 01:52:50PM -0700, Alex Helms wrote:
>> Add dt bindings for the Renesas ProXO oscillator.
>>
>> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
>> ---
>>  .../bindings/clock/renesas,proxo.yaml         | 49 +++++++++++++++++++
>>  MAINTAINERS                                   |  5 ++
>>  2 files changed, 54 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>> new file mode 100644
>> index 000000000..79d62f399
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Frenesas%2Cproxo.yaml%23&amp;data=05%7C01%7Calexander.helms.jy%40renesas.com%7C6b2973fc747e49d4353308daa0137e97%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637998302827553694%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=Xk7KWuuUfUfA0xv4oUSEOzvhEMpE5YWKad9YVXsJbXg%3D&amp;reserved=0
>> +$schema: https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Calexander.helms.jy%40renesas.com%7C6b2973fc747e49d4353308daa0137e97%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637998302827553694%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=%2F1uyeDB3%2F9iLv1soU8V2NtEaaeoFkpwI%2FG7cSaZCKbo%3D&amp;reserved=0
>> +
>> +title: Renesas ProXO Oscillator Device Tree Bindings
>> +
>> +maintainers:
>> +  - Alex Helms <alexander.helms.jy@renesas.com>
>> +
>> +description:
>> +  Renesas ProXO is a family of programmable ultra-low phase noise
>> +  quartz-based oscillators.
>> +
>> +properties:
>> +  '#clock-cells':
>> +    const: 0
>> +
>> +  compatible:
>> +    enum:
>> +      - renesas,proxo-xp
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  renesas,crystal-frequency:
>> +    description: Internal crystal frequency, default is 50000000 (50MHz)
>> +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> 'clock-frequency' doesn't work here?

If 'clock-frequency' is commonly used to describe and internal crystal
frequency then I can change it but in my opinion 'crystal-frequency-hz'
is a better name for this parameter as it isn't really a clock, just the
internal crystal that is inside the package.

> 
> Anything else needs '-hz' suffix.

I will add the suffix in the next patch.

> 
>> +
>> +required:
>> +  - '#clock-cells'
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      proxo: clock-controller@55 {
>> +        compatible = "renesas,proxo-xp";
>> +        reg = <0x55>;
>> +        #clock-cells = <0>;
>> +      };
>> +    };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 350102355..d52a8a5d2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -16080,6 +16080,11 @@ S:	Supported
>>  F:	Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
>>  F:	drivers/iio/adc/rzg2l_adc.c
>>  
>> +RENESAS PROXO CLOCK DRIVER
>> +M:	Alex Helms <alexander.helms.jy@renesas.com>
>> +S:	Maintained
>> +F:	Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>> +
>>  RESET CONTROLLER FRAMEWORK
>>  M:	Philipp Zabel <p.zabel@pengutronix.de>
>>  S:	Maintained
>> -- 
>> 2.30.2
>>
>>