Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1347166rwb; Wed, 28 Sep 2022 17:25:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4T0Q8y3gMOi+McL5+u13Yq0qg6JPYS+cG6CQq/ctYCBxTfJT0hAK1ntvH24LPSvloVpyTI X-Received: by 2002:a17:90b:4d12:b0:202:e772:fa09 with SMTP id mw18-20020a17090b4d1200b00202e772fa09mr13535129pjb.30.1664411127801; Wed, 28 Sep 2022 17:25:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664411127; cv=none; d=google.com; s=arc-20160816; b=LuG5BYVCZzqLIpkmUurASaucdPjZc9mv3TPKi/PRht/sNJ6EvzQjPet9IM70wgxjmG AtGf6eLSDoJIwuV9nkOZGNdfDHTyoijiFyh30iO9yhGRhi0JLZQvC29t3IkgMWrtgL9l OxAEBi5rV/Szva5BF/+qlvHfHuE+YDcSmT3qfRHAMvBX1YNF2aTItFcFvpUOZMSgVWr4 P+vAnmmPzFrWle8libGNB/jjFHjIyUYth5zYnRrbLpS0/uuQ3YTNgzYVMcEyuGjRh4Te 5WeAplp4LbQ+Sd5etVVuXBBVI1z1W7b5gRN61ttf1/PdkGcy4KS0WuCBvsusURtdGY89 8JEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=LjaUXBIlmXcjGmqVHUKWhe2O7/mvO/3uzoLRWvl8Fwc=; b=hR2DvAv9+eYpYKbsfMdteobTX1NhT9xz6BMTbvOcM1jo3Pg05ruy+1bFAhG6CE2Zrn M2B0vycK+yB5cwEzRSdLZd+Uaol5OR8kPGq/gZ+mhCxUl7zXrS0qmM96QxJPUiyJ/z/V WDkYsVkoEDQ3YzRtjdkn/T1OqiIBaxTSD8lrIuXtASCtpDTrDRwn5zi+s+g/txueSgg5 mKL8ajiF2ceZUSKguiGycQzCoMHz5cZs69Y91EwQ903cFfvNuxvoqK5k99/ZQVbPFtI8 ACmeOFbT15gJaNcakmFR73ZYVM5Yzf63vwzD99kWsVlnFN6uRkakSSELuICb8EzNYDkv nvTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="F/BqVPcn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w3-20020a63c103000000b00434cc1d3b6asi6250397pgf.68.2022.09.28.17.25.14; Wed, 28 Sep 2022 17:25:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="F/BqVPcn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232599AbiI2AQK (ORCPT + 99 others); Wed, 28 Sep 2022 20:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231419AbiI2AQH (ORCPT ); Wed, 28 Sep 2022 20:16:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14FF9118DCF; Wed, 28 Sep 2022 17:16:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A441860F09; Thu, 29 Sep 2022 00:16:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02029C433B5; Thu, 29 Sep 2022 00:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664410566; bh=LjaUXBIlmXcjGmqVHUKWhe2O7/mvO/3uzoLRWvl8Fwc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=F/BqVPcnqizMU7KgAVnJNReZBIbYfdEyBVavrodWlHIfOdE5EVKa2mMI9WCMkx1vI JzVPkEwkaWEq9ZceEDFaIncjzonNpye3UF2Ca+WlQN3dkIdfUBfirhZpZuQSeASQJj 7Y4mSDHbLg++dPZl5s4IbJNMhHxtP3o3WDXIkPnPcRcYEW+bpmGnRHB/fhOveZ28eZ gt4jb+cucpuSatdKKWKGSMcU7w77lNdhZbDD9i46tLkpKnOVEQVsGrYiZ0kVNrUT+q vwZdNMu5ipy5RpuoCkXgZHB4e84MVfHh9xGAx3AW5iSYhNR5N6XQf+7OtQZYmhAaSK n5gZj0sJ/gYiA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: Subject: Re: [PATCH RESEND v2 2/5] clk: mxl: Remove unnecessary spinlocks From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-lgm-soc@maxlinear.com, Rahul Tanwar To: Rahul Tanwar , linux-clk@vger.kernel.org, mturquette@baylibre.com Date: Wed, 28 Sep 2022 17:16:02 -0700 User-Agent: alot/0.10 Message-Id: <20220929001606.02029C433B5@smtp.kernel.org> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rahul Tanwar (2022-09-21 23:24:25) > This driver is now switched from direct readl/writel based register > access to regmap based register acceess. Regmap already has its own > lock to serialize the register accesses across multiple cores. >=20 > Hence, there is no need for additional spinlocks in the driver. > Remove all spinlocks which are no longer required. Can you confirm that the driver doesn't do a read, modify, write (rmw) sequence where during the modification another CPU can rmw and corrupt the previous "read"?