Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1401773rwb; Wed, 28 Sep 2022 18:27:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7BagaXQoWKh+H+T0KQAXxZCsH/0NHAgIzO+HZfYnRiqrzIjGZE7Nef9RQ8cxDWwHoS3wET X-Received: by 2002:a05:6a00:804:b0:544:9d05:60a2 with SMTP id m4-20020a056a00080400b005449d0560a2mr913807pfk.57.1664414824383; Wed, 28 Sep 2022 18:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664414824; cv=none; d=google.com; s=arc-20160816; b=KBoV73N9mRtoWAio0QZh7Df6HqejnP7fTHaBt3EbJFex8+cOUxND3n5IxWnwNB4wLq UCxFFmLVX5zmVNTr7/ZbnUeoRjNw3r7ynr/zSuUBFypjnigoWA+cMr/Nsiyo+EdAd379 cd1cutVO2BR9RydhSTvgeV6LrE3QOlxSWj76GxPa5j6DhsV7GRatMvZNkPwmwp9KDznH LdokKneNO0jQcYwidZns7Hj6crdE7WaDCO71mL0Nh2A40E+66IKHCMCE9iyMVr9zmjXa Wmts3cKuEhENoPKgQCMmzFbLE2QEg+zy4cyc+YjwNkvT57JMTJm7hrGMI42FKK3qiex1 vc7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=PyA6JBZ/HLPJA0MSYRFOgBZKQs1v6t/7oG2AsVljbwA=; b=MxnvCE7E4+A5/vXx5K9sDWNTVrj7ApTjHkqVEBuRqaxGMXcLorXQ0G7YBkqXsmQaEI gYUHS8WYs4U0DHREytDeSZAcSXxgCdXpFKCXcd6q4TsNcEhqkTNC1OqvtJCjMkobGkXH S3mPlX0tFDZ3fDIQK+DYmbZNyBP8R6ko2z0LDC0LaQ1cGEh2IDphToOl67llXETuWWq7 iNigpYeaIasKPjwm6PqURD3h6pgyw8nZUFRKo99r4vEfHvZtmuYqVI0zbOpmoc666nTj MYefL7rBUAau5fsXOHFqZwvZOeshcM27/WY9icYIsi9ShKh423sGPRSSHoExtBDC5lnS Csrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cnoIUXNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a654308000000b0042b57ff2893si6714003pgq.195.2022.09.28.18.26.53; Wed, 28 Sep 2022 18:27:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cnoIUXNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234023AbiI2BUh (ORCPT + 99 others); Wed, 28 Sep 2022 21:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbiI2BUf (ORCPT ); Wed, 28 Sep 2022 21:20:35 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AB60B2871 for ; Wed, 28 Sep 2022 18:20:34 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id j16so74160lfg.1 for ; Wed, 28 Sep 2022 18:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:from:to:cc:subject:date; bh=PyA6JBZ/HLPJA0MSYRFOgBZKQs1v6t/7oG2AsVljbwA=; b=cnoIUXNM7y0Bx6E39zrU9pROCXP+TwDSRNusZ4S6UPUgk7lla7MB/QQzbc5dwyEX9P 8fNXAUPeBK6so/28gYHdEMd4sVI5/q/0+poZEl+j+NGzdhZrT4Oh6Fn8OK1RvlrO3tRc faslcLLDDm6RV50iLLmFD/Kgz4ASmJmz2C1cQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:x-gm-message-state:from:to:cc:subject:date; bh=PyA6JBZ/HLPJA0MSYRFOgBZKQs1v6t/7oG2AsVljbwA=; b=EowXKjpYVBPr5judpAPOlVGV6VfMA2NS9an/vn7oZeGKHshSytEcgel7tpgNeL/5YB uXlyDvHL4HgS7C3ztCVzrDtPxi8gQAoq/t/R5aNUbKR9bhsjVuEGKZVveAEHAKKUzDml ugETH66QHPUt8psbD1B/0EwHTzDfia0ZVJQRB+Fp+9Oubgv99kv1FWWifAIGDQTtns/7 RNhnTnnKuusGj6XvGLhSC3zt7hmi4VODO6N0+wV2VrfsSWQYDx2krDO4uUZGZYCJtXld MMTSNgQzRnt0+YDEhovXHCrc2N8r3WgfOo4azSeAYVBb18R5XckhdZcPxJpJdjSLiB4a Wi2w== X-Gm-Message-State: ACrzQf1iR7OneDONsSQnrU8ZOwYLwXH/0xtvXeWW28wExElcvSo0EFuP M1LARuj+PB+8IJ94utRtsk7OxIR5yzzbq55ccEcc+A== X-Received: by 2002:a05:6512:1151:b0:4a0:50f2:9509 with SMTP id m17-20020a056512115100b004a050f29509mr327722lfg.297.1664414432376; Wed, 28 Sep 2022 18:20:32 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 28 Sep 2022 21:20:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <52039cd1-4390-7abb-d296-0eb7ac0c3b15@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Wed, 28 Sep 2022 21:20:31 -0400 Message-ID: Subject: Re: [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API To: Lee Jones Cc: Lee Jones , Satya Priya Kakitapalli , Mark Brown , Bjorn Andersson , Rob Herring , Liam Girdwood , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_jprakash@quicinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lee Jones (2022-09-28 03:20:30) > Wouldn't it make more sense to simply separate the instantiation of > the 2 I2C devices? Similar to what you suggested [0] in v9. That way > they can handle their own resources and we can avoid all of the I2C > dummy / shared Regmap passing faff. > > [0] https://lore.kernel.org/all/CAE-0n53G-atsuwqcgNvi3nvWyiO3P=pSj5zDUMYj0ELVYJE54Q@mail.gmail.com/ > You can continue reading the thread[1]. My understanding is it's one chip that responds on two i2c addresses, thus we don't describe that as two i2c device nodes in DT. Instead we describe one node and use the dummy API to make the second i2c device. [1] https://lore.kernel.org/all/Yk3NkNK3e+fgj4eG@sirena.org.uk/