Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=message-id:date:mime-version:user-agent:subject:to:cc:references:from:in-reply-to:content-type; 
  b=jBEi5o0Dapas/Y3gTqXE7Urbrun/d0qv8B5NLr4wFxdJ0rOe2Lz+DQJQj6goKU8avYvEGgH5FLsE
    PpeXkUD5h8gP87WSkaDoDynZJh1244+Yl+Pf6AfK0KpWbtVy0nQb  
Message-ID: <6104df01-4190-5c18-ddbf-6694e1e14900@zoho.com>
Date:   Wed, 28 Sep 2022 21:49:00 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] btrfs:remove redundant index_rbio_pages in
 raid56_rmw_stripe
Content-Language: en-US
To:     wqu@suse.com
Cc:     Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220929014402.2450-1-hmsjwzb@zoho.com>
From:   hmsjwzb <hmsjwzb@zoho.com>
In-Reply-To: <20220929014402.2450-1-hmsjwzb@zoho.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/28/22 21:44, Flint.Wang wrote:
>   The index_rbio_pages in raid56_rmw_stripe is redundant.
>   It is invoked in finish_rmw anyway.
> 
> Signed-off-by: Flint.Wang <hmsjwzb@zoho.com>
> ---
>  fs/btrfs/raid56.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index f6395e8288d69..44266b2c5b86e 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -1546,8 +1546,6 @@ static int raid56_rmw_stripe(struct btrfs_raid_bio *rbio)
>  	if (ret)
>  		goto cleanup;
>  
> -	index_rbio_pages(rbio);
> -
>  	atomic_set(&rbio->error, 0);
>  	/* Build a list of bios to read all the missing data sectors. */
>  	for (total_sector_nr = 0; total_sector_nr < nr_data_sectors;
Hi Qu,

	I am doing some experiment on the destroy RMW. It seems the index_rbio_pages in raid56_rmw_stripe is redundant. We will do it in finish_rmw anyway.

Thanks,
Flint