Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220927051513.3768717-1-zhengjun.xing@linux.intel.com> <YzRaAxFrg56uph+W@kernel.org>
In-Reply-To: <YzRaAxFrg56uph+W@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 28 Sep 2022 19:11:15 -0700
Message-ID: <CAP-5=fVgsMzx6F=rgy9kyfWS=Gj3hvtLTJmTzf6+O954x4oY_g@mail.gmail.com>
Subject: Re: [PATCH] perf test: Fix test case 87 ("perf record tests") for
 hybrid systems
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     zhengjun.xing@linux.intel.com, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@intel.com, jolsa@kernel.org,
        namhyung@kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, ak@linux.intel.com,
        kan.liang@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 28, 2022 at 7:28 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Tue, Sep 27, 2022 at 01:15:13PM +0800, zhengjun.xing@linux.intel.com escreveu:
> > From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> >
> > The test case 87 ("perf record tests") failed on hybrid systems,the event
> > "cpu/br_inst_retired.near_call/p" is only for non-hybrid system. Correct
> > the test event to support both non-hybrid and hybrid systems.
> >
> > Before:
> >  # ./perf test 87
> >  87: perf record tests                                   : FAILED!
> >
> > After:
> >  # ./perf test 87
> >  87: perf record tests                                   : Ok
>
> Looks sane, applied.
>
> Ian, consider providing your Acked-by,
>
> - Arnaldo

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

>
> > Fixes: 24f378e66021 ("perf test: Add basic perf record tests")
> > Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > ---
> >  tools/perf/tests/shell/record.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index 00c7285ce1ac..301f95427159 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -61,7 +61,7 @@ test_register_capture() {
> >      echo "Register capture test [Skipped missing registers]"
> >      return
> >    fi
> > -  if ! perf record -o - --intr-regs=di,r8,dx,cx -e cpu/br_inst_retired.near_call/p \
> > +  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
> >      -c 1000 --per-thread true 2> /dev/null \
> >      | perf script -F ip,sym,iregs -i - 2> /dev/null \
> >      | egrep -q "DI:"
> > --
> > 2.25.1
>
> --
>
> - Arnaldo