Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: pcvMHEJ5FJnbS63FavhmAp7d8i/dtA0ix6BBbJx+DIqNVAPBSWY1i0/xR9wu5vVa3kmKHmkcEC
 bglO5VHrgMMDb6bQNGSZnhC3zCROq1jxRKmCvl1+CPjYAttx7v8cYGHiUsAigy+s7crAJ60ZhF
 xkpwdYW8jYjAAP25uuhODHxcOmuUWN4EAlEgzquH14U3wZeGe9KJg6lh1/UxW5vs67oEC2kMDs
 X1d5vp+m5XCzN8zOjPdxioIsDQdrkO33HBWEElvmCogVVwFPbySoF11aXsLbg6e2kYXCHTvxmy
 2iv0N0fqot3sA8jpTUYmm2T4
IronPort-SDR: Bs9YIeuAwrDO5y00lbbiAq823ZbBlGZzTZDPd7+9JPZsgEUl8NnYnInJ6EZxnq6A1fFAaevEZF
 Q+AVf20EgA1GYupZNd2hg5GB+i4fgy7XAidwXEeMppEnMDFLAOxs6opA0q3ovCURD5359/UPDx
 moBdg1gxQ7YjqtnJiWH0FT2ickAyKArR0GuHszGJMrj2m6Brxlto/m+fjOMIMTPZwjvIJOvpwf
 /fkVK4fAi+mdY5x3KL7WzhWaR22E9yFNYNvzDdZmLwRKWQdaLEp3LMX7dIaHdQiiJ+3vQa2pVp
 Dck=
WDCIronportException: Internal
Message-ID: <0c0306d7-2645-874a-9745-8aa5dcfeede1@opensource.wdc.com>
Date:   Thu, 29 Sep 2022 11:09:35 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/6] scsi: libsas: Add sas_task_find_rq()
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com,
        damien.lemoal@wdc.com
Cc:     hare@suse.de, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com,
        ipylypiv@google.com, changyuanl@google.com, hch@lst.de
References: <1664368034-114991-1-git-send-email-john.garry@huawei.com>
 <1664368034-114991-2-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1664368034-114991-2-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/28/22 21:27, John Garry wrote:
> blk-mq already provides a unique tag per request. Some libsas LLDDs - like
> hisi_sas - already use this tag as the unique per-IO HW tag.
> 
> Add a common function to provide the request associated with a sas_task
> for all libsas LLDDs.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>  include/scsi/libsas.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index f86b56bf7833..bc51756a3317 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -644,6 +644,28 @@ static inline bool sas_is_internal_abort(struct sas_task *task)
>  	return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT;
>  }
>  
> +static inline struct request *sas_task_find_rq(struct sas_task *task)
> +{
> +	struct scsi_cmnd *scmd;
> +
> +	if (!task || !task->uldd_task)
> +		return NULL;
> +
> +	if (task->task_proto & SAS_PROTOCOL_STP_ALL) {
> +		struct ata_queued_cmd *qc;
> +
> +		qc = task->uldd_task;

I would change these 2 lines into a single line:

		struct ata_queued_cmd *qc = task->uldd_task;

And no cast as suggested.

> +		scmd = qc->scsicmd;
> +	} else {
> +		scmd = task->uldd_task;
> +	}
> +
> +	if (!scmd)
> +		return NULL;
> +
> +	return scsi_cmd_to_rq(scmd);
> +}
> +
>  struct sas_domain_function_template {
>  	/* The class calls these to notify the LLDD of an event. */
>  	void (*lldd_port_formed)(struct asd_sas_phy *);

-- 
Damien Le Moal
Western Digital Research