Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wayne Chang <waynec@nvidia.com>
To:     Jonathan Hunter <jonathanh@nvidia.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>
CC:     Sing-Han Chen <singhanc@nvidia.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Add Tegra234 SOC support
Thread-Topic: [PATCH 1/1] usb: gadget: tegra-xudc: Add Tegra234 SOC support
Thread-Index: AQHY00H+9TYmCRLY+UOYcWsbtNAXmw==
Date:   Thu, 29 Sep 2022 03:46:41 +0000
Message-ID: <PH0PR12MB55006EF3D20D3A85062FAF85AF579@PH0PR12MB5500.namprd12.prod.outlook.com>
References: <20220928135502.3458833-1-waynec@nvidia.com>
 <6648ece7-0a8e-2217-0c5a-5d58dd5a012c@nvidia.com>
Accept-Language: en-US, zh-TW
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lZ6MlyAGLB/XlbDeaUOJhvx2GfbB3ZWqfI5loDoKGbhH9OwdOzH6neCMVkUL?=
 =?us-ascii?Q?tNqt1pt9LTRMGib3JYVRycqkPEgY2oN6BXpFaJqzzWlkJdRaa/5Tt9EWbDSG?=
 =?us-ascii?Q?lxsfqHBnYnsSf0a1vpme+dmXiPyN5zq0K9JmLg4cr9+ml5HmSsx2QEXAgZKE?=
 =?us-ascii?Q?Vg73Jz0PpWKE3fmfqCrEwmDXWtDVsJ21oYKZ5OSMWtgOEg2p6w2DybTavGT3?=
 =?us-ascii?Q?rhWq/JtOXsWXJQywdhrKCKmUjVEvwFWTlLcHTV+v6RIL9Vpd4jAQC2AWIvk+?=
 =?us-ascii?Q?+JSLSD4BAC9GFhXZ6o9oSk3qhkQdLLtgQ183G0ie1eliicCAZZw6CMrjxH6g?=
 =?us-ascii?Q?i5vD5iy8eQ1QAwyAHa1v6rispif3gJ1/opQXlgNKQLiSKwHSXAfH4/AQwIM7?=
 =?us-ascii?Q?WNUqjZoUxEmfkWXTot1pMUFTrL1u/a+QvdNA5k0xTp0+3/Opl3Fhn57A8zEO?=
 =?us-ascii?Q?Zt+MbVzxzlPx4e79NcQkDVrsml0NUIVL8KhqTAigH+irx56tRLW6OB1RybkU?=
 =?us-ascii?Q?ZSXPomTebj7ybakC0KBGmHRTHf6aAfNvqC8+H6rXff1EVdXVhetIJYgEcw8i?=
 =?us-ascii?Q?h6I9KE82l1bXPOkLkihn79Vrwg1ctah9Oh6es6CjnG7jFc2hQYrH0GM0xCno?=
 =?us-ascii?Q?gDSvj4rdRbt2cAWEiCH1pKjcFRaD+/ICGPFgG6Dj3dgy0/47v0lhF1d1yE6d?=
 =?us-ascii?Q?2uctxD5IJGvb0YQKTVf0OaXs4Y+6wygWQy/ghV9qbtGCXHGolMtMQ8Q+X9mX?=
 =?us-ascii?Q?b83n5C5lOTOxGkPt/oGVFhS73m0PMCU1W/WhYioUDaodUuvS9NS8EzA/lRbE?=
 =?us-ascii?Q?fMWROMiUH5+HjWWYs12x/JUL5oxU8tZ5Xal485PohwsRmiTxa1oq70y6jG1I?=
 =?us-ascii?Q?F31Ag6jzNGXWY9vvLRDSefK3kEuVXBg4LtlSrptlvuCZRTgQaVQ3zWCXj+th?=
 =?us-ascii?Q?ZzgsJq3lMXsnueHBxtizkntn2ACwr6LMbC9t3IetfGlhB+O4aujExAHV1Qkd?=
 =?us-ascii?Q?KSwXW8XItQgSZYXdP9rXd+mixoP4k7OCznao3pqoAHtEr9dJfFvptDxolWnZ?=
 =?us-ascii?Q?w3jd+MwDERx56gYJSfy1cpHD5nVocyctP2hGI8IGZDvdyebSycUM60bBv+uI?=
 =?us-ascii?Q?e1MCoocOrNc4W8l2BuOnmmcDI/EIcM0rd2V9vU8FLRVZ1uGxH4XbXYtOD6yf?=
 =?us-ascii?Q?MFBej8EI2dnktdF3C6eEWql5YDTLGreoRRu6CNN5vVvStOuFZNHK0NK3yQhw?=
 =?us-ascii?Q?heWnQEqg/2FPZnNumUDp4jbbEpWYJF3VYHwiS4+iqzbvnKp8r0O8M/gKHugO?=
 =?us-ascii?Q?Q6IE9rAZU+SqfDZ/aQHDofhXEGXtPZb/sC3e5r0iSO0tXjMtdtC96CPq9mdS?=
 =?us-ascii?Q?JPdc3tcrI2P+euIpY9Pp1YDp1d5HxYqL/Q0BbxLs2dQspBlPzgdQDSkCBQ98?=
 =?us-ascii?Q?ys9y4y2tKMRGzo1cU26jfi8fdqLnaec2pd6mnGllRwH8iPb10xhgv3ClzmIl?=
 =?us-ascii?Q?ja7nLWVkTTnCNBAOmUBG0G/jU3l+lx56js1mxkYCEa6x2HgYaFX3fschRo2G?=
 =?us-ascii?Q?F1+PzWe0bJzmej5ZpQlv5NIWzLxs9JiPY/3x6KGs?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5500.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b147112f-2f9d-4c23-dcd0-08daa1cd38b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 03:46:41.7688
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8UANfzB34zW6UgXyI7Z9jg0U+rhl521YaffM+R7xzb3syOo17AAL4f8b+VIF7V3N3qGZ6U/caHU+XtPacynWaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6689
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jonathan,=0A=
=0A=
Thanks for the review.=0A=
=0A=
On 9/29/22 03:04, Jonathan Hunter wrote:=0A=
> =0A=
> On 28/09/2022 14:55, Wayne Chang wrote:=0A=
>> From: Sing-Han Chen <singhanc@nvidia.com>=0A=
>>=0A=
>> This commit adds XUSB device mode controller support on Tegra234 SoC.=0A=
>> Tegra234 XUDC is very similar to the existing Tegra194 XUDC.=0A=
>>=0A=
>> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>=0A=
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>=0A=
>> ---=0A=
>>    drivers/usb/gadget/udc/tegra-xudc.c | 17 +++++++++++++++++=0A=
>>    1 file changed, 17 insertions(+)=0A=
>>=0A=
>> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/ud=
c/tegra-xudc.c=0A=
>> index 3c37effdfa64..53277aa5a270 100644=0A=
>> --- a/drivers/usb/gadget/udc/tegra-xudc.c=0A=
>> +++ b/drivers/usb/gadget/udc/tegra-xudc.c=0A=
>> @@ -3656,6 +3656,19 @@ static struct tegra_xudc_soc tegra194_xudc_soc_da=
ta =3D {=0A=
>>    	.has_ipfs =3D false,=0A=
>>    };=0A=
>>    =0A=
>> +static struct tegra_xudc_soc tegra234_xudc_soc_data =3D {=0A=
>> +	.clock_names =3D tegra186_xudc_clock_names,=0A=
>> +	.num_clks =3D ARRAY_SIZE(tegra186_xudc_clock_names),=0A=
>> +	.num_phys =3D 4,=0A=
>> +	.u1_enable =3D true,=0A=
>> +	.u2_enable =3D true,=0A=
>> +	.lpm_enable =3D true,=0A=
>> +	.invalid_seq_num =3D false,=0A=
>> +	.pls_quirk =3D false,=0A=
>> +	.port_reset_quirk =3D false,=0A=
>> +	.has_ipfs =3D false,=0A=
>> +};=0A=
>> +=0A=
>>    static const struct of_device_id tegra_xudc_of_match[] =3D {=0A=
>>    	{=0A=
>>    		.compatible =3D "nvidia,tegra210-xudc",=0A=
>> @@ -3669,6 +3682,10 @@ static const struct of_device_id tegra_xudc_of_ma=
tch[] =3D {=0A=
>>    		.compatible =3D "nvidia,tegra194-xudc",=0A=
>>    		.data =3D &tegra194_xudc_soc_data=0A=
>>    	},=0A=
>> +	{=0A=
>> +		.compatible =3D "nvidia,tegra234-xudc",=0A=
>> +		.data =3D &tegra234_xudc_soc_data=0A=
>> +	},=0A=
> =0A=
> =0A=
> The device-tree binding documentation is missing for this compatible=0A=
> string. Please send a patch to add this compatible string to the=0A=
> appropriate binding doc.=0A=
Thanks. Sent out the change to add the compatible string to xudc binding =
=0A=
doc.=0A=
=0A=
https://lore.kernel.org/all/20220929034221.3817058-1-waynec@nvidia.com/T/#u=
=0A=
=0A=
> =0A=
> Thanks!=0A=
> Jon=0A=
> =0A=
=0A=
thanks,=0A=
Wayne.=0A=