Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d4e4a362-fbf2-7eea-e021-16ae7782e06e@bytedance.com>
Date:   Thu, 29 Sep 2022 11:47:13 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread
Content-Language: en-US
To:     maobibo <maobibo@loongson.cn>,
        David Hildenbrand <david@redhat.com>,
        akpm@linux-foundation.org, muchun.song@linux.dev,
        =?UTF-8?B?6ZmI5Y2O5omN?= <chenhuacai@loongson.cn>
Cc:     chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Muchun Song <songmuchun@bytedance.com>
References: <20220926115621.13849-1-zhengqi.arch@bytedance.com>
 <b5823e18-6139-c16e-a2df-1aa3e88927fa@redhat.com>
 <c41a3cb6-aef9-d8a9-ab0b-b9c8013ee1d8@bytedance.com>
 <e5cd4c46-71fd-8edb-098c-2ac839d5c5d2@loongson.cn>
From:   Qi Zheng <zhengqi.arch@bytedance.com>
In-Reply-To: <e5cd4c46-71fd-8edb-098c-2ac839d5c5d2@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/9/29 11:27, maobibo wrote:
> 在 2022/9/29 11:07, Qi Zheng 写道:
>>
>>
>> On 2022/9/26 22:34, David Hildenbrand wrote:
>>> On 26.09.22 13:56, Qi Zheng wrote:
>>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
>>>> if PTE entry exists") said, we should update local TLB only on the
>>>> second thread. So in the do_anonymous_page() here, we should use
>>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread.
>>>>
>>>> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
>>>> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
>>>> ---
>>>> v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/
>>>>
>>>> Changelog in v1 -> v2:
>>>>    - change the subject and commit message (David)
>>>>
>>>>    mm/memory.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/mm/memory.c b/mm/memory.c
>>>> index 118e5f023597..9e11c783ba0e 100644
>>>> --- a/mm/memory.c
>>>> +++ b/mm/memory.c
>>>> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>>>>        vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address,
>>>>                &vmf->ptl);
>>>>        if (!pte_none(*vmf->pte)) {
>>>> -        update_mmu_cache(vma, vmf->address, vmf->pte);
>>>> +        update_mmu_tlb(vma, vmf->address, vmf->pte);
>>>>            goto release;
>>>>        }
>>>
>>>
>>> Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache].
>>>
>>> So it looks good to me, but a confirmation from Bibo Mao might be good.
>>
>> Thanks, and Hi Bibo, any comments here? :)
> 
> update_mmu_tlb is defined as empty on loongarch, maybe some lines should
> be added in file arch/loongarch/include/asm/pgtable.h like this:

Seems like a bug? Because there are many other places where
update_mmu_tlb() is called.

> 
> +#define __HAVE_ARCH_UPDATE_MMU_TLB
> +#define update_mmu_tlb  update_mmu_cache

If so, I can make the above as a separate fix patch.

Thanks,
Qi

> 
> regards
> bibo mao
>>
>>>
>>
> 

-- 
Thanks,
Qi