Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 13:59:07 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <jon@nutanix.com>, <kevin.tian@intel.com>, <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v3] KVM: x86/vmx: Suppress posted interrupt notification
 when CPU is in host
Message-ID: <YzU0KyTx2SPRadTm@gao-cwp>
References: <20220928111604.180284-1-chao.gao@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220928111604.180284-1-chao.gao@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zq2e6N/Lf2FciTN4SzL1DRmro/nQCHLRLZgT+/pTeQfewAobbGtu9KoO9ZHp?=
 =?us-ascii?Q?LD43+4VRv86KioTD9DxjvRgHs5i9HVzJ/7gy6/AW9Dv9YkhFFegfJy0kR2EK?=
 =?us-ascii?Q?Djbw8umlaUaSwXkH9Equ3/0htkZzOFSGlQQpUqeR6IfKRBP9y7Wx47AQfUhk?=
 =?us-ascii?Q?iEnZm8tCNRrJxb4GZS2kOYdAyicq2Nnx5W28sLRM4qi/ZkA90biTIUKCeVHo?=
 =?us-ascii?Q?8pr0DXdD9KXMKa9Fa1+V28/MKbLFblQhlbNRWT4zPk792EgRD+H4VMJHo5FW?=
 =?us-ascii?Q?qUL4zTIf4WCzsYgRLN/20LJ4PAKxgQHrsZHgeXoy5JCevDNYqXIJDWw4FgUO?=
 =?us-ascii?Q?8cKzJ2I7xVpBOODac6HGmwjSv36ARc1Nbj1zU3jhHvokCYEcwXXWtQyrz9fT?=
 =?us-ascii?Q?5Ain/BM8t7kCrj+FUedLcNrtcjiFiitIoPHlhWSBX3d5NmK1p05sAmU9dLqv?=
 =?us-ascii?Q?6qGfjuEWes5Bk3xRvzpcV1w18eUUElv2f4BSW1ZvoLZKGO1wevwMaOvSv3Yy?=
 =?us-ascii?Q?JMnMA/sBVtf/3NKjCJJ0V7uIzVsVJgBNIE7RRBYI5s3iEYkHLLzhQKF+bIY0?=
 =?us-ascii?Q?G6MgnzS17Bi5oOZEb2ulHmx0zvcRF/Odml4jxYI7R5M6nTE2XPOGuWAL9eGI?=
 =?us-ascii?Q?0fzf4Pg47lrG58EYI1EDid57fbkL6AcOlYy+zvis6jj6ITtbkr5B+sl+D60d?=
 =?us-ascii?Q?AVmKxlFzakdbrDCy+rDmXYRTMO4uqJPtjCmZ1I7JISl+rayg/zBdFiipZyiN?=
 =?us-ascii?Q?LM/vUvz0EeNOL/B/vBbS9aRIdcNU9yIQcU2qT0zsHblp1/IYjU5bNXv5vX1M?=
 =?us-ascii?Q?R86Pf9OjNUC1ME5PT7bHTq5mbgJehNwZWlJzxAjfzUeFEZ89EaEPJ3UC7J/m?=
 =?us-ascii?Q?+i64TbTP1CZ8KT1RYdiQ5fx3zR4auB3vK7mGDpmO7nDIaTjekIo2Lsrugr57?=
 =?us-ascii?Q?sLu3V+EI5PJhPjl67G5msUEHRRKaNoq6+zrssaDYJKO5jdnGvVYeYSvt9y1Y?=
 =?us-ascii?Q?F+vm/586QEQ7RLml2wETlE3o72AIb/bW362n/G3BJIS1xLlIryxhU97gpEZS?=
 =?us-ascii?Q?gp+ZWjOTjnI5+/xdpH+kDQJXqVElUpJPCp3gPpSHGiuMqpiCk+zQVPe0B+2t?=
 =?us-ascii?Q?oNy0IC0Fzn/uy6PRmdhMNlpVstl5JrhdRHcrkxjjjZ3vj2BRNfuSno0cErww?=
 =?us-ascii?Q?2l3/5nae/vPcXtdacaR3YQ0Mj3nCZE2A3sVanf1ZkF4eDA8COU74+8HpnEsK?=
 =?us-ascii?Q?5oubG1jaP4GiInRc5K3k3ujl8cIOfweLT3lQk9FqeUdT28rO0N5FbS9nbmDX?=
 =?us-ascii?Q?qVkl9ylH3uIl38JnPVxcW/0tqz0hNK0+TRjBSxa6eduechdBVrfG5ZbRFJf8?=
 =?us-ascii?Q?tZ3spOA3V3z3Xo/7j9FgPUAw0W5ejhJXnONuEhhHoBcBWivdIlM/JCdn7sJw?=
 =?us-ascii?Q?vSkhrYcN2TW9HQH5+P+47H+Oaw0EGfwEpbUc/nN8423QRMwAPCmAGUhfXK/M?=
 =?us-ascii?Q?MwGRV6PyU9oOpW/a+kgDe74xV9HVi1xZwN9/OcUzpe76/2X3i0b6Xc3L/gxI?=
 =?us-ascii?Q?X0EKsF2txsm+G2+39a/7AntKo8rHaN3qz7Z36FJW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a0fe6eb-f1e3-4df5-bbe4-08daa1dfb8df
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2221.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 05:59:08.3264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nKxcBjKKuXPRMBvt3S5jSLBxOY+Salzewcs7oB8lMPaWFw38kEMeBeJiMs7PARpe4e+PFormH36NvAUICMogxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5539
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 28, 2022 at 07:16:03PM +0800, Chao Gao wrote:
>@@ -10538,6 +10547,17 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
> 
> 	vcpu->mode = OUTSIDE_GUEST_MODE;
> 	smp_wmb();
>+	/*
>+	 * Suppress notification when CPU is OUTSIDE_GUEST_MODE to avoid
>+	 * wasting time on handling interrupts. A notification to host/kvm
>+	 * just indicates some interrupts are posted for a vCPU. Since KVM
>+	 * always syncs pending interrupts in PIR to vAPIC IRR before guest
>+	 * entry (in ->sync_pir_to_irr()), notification isn't needed.
>+	 *
>+	 * Do this even if apicv is disabled for simplicity.
>+	 */
>+	if (kvm_lapic_enabled(vcpu))
>+		static_call_cond(kvm_x86_pi_suppress_notification)(vcpu, true);

I missed the other kvm's setting vcpu->mode to OUTSIDE_GUEST_MODE in
this function (a few lines above). Will fix it in v4.

> 
> 	/*
> 	 * Sync xfd before calling handle_exit_irqoff() which may
>
>base-commit: 372d07084593dc7a399bf9bee815711b1fb1bcf2
>-- 
>2.25.1
>