Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c63414d8-57e1-69d4-a180-746e415289c1@amd.com>
Date:   Thu, 29 Sep 2022 12:30:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/2] perf/x86/utils: fix uninitialized var in
 get_branch_type()
To:     Stephane Eranian <eranian@google.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        ananth.narayan@amd.com, ravi.bangoria@amd.com
References: <20220928184043.408364-1-eranian@google.com>
 <20220928184043.408364-2-eranian@google.com>
Content-Language: en-US
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <20220928184043.408364-2-eranian@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDhyTWpCdXVLQnpUYm1HdFJxZ01KRE5IY3FXQVgyT09MWFZXRTJsWDROek5G?=
 =?utf-8?B?U0xlUFplUTdDWXRmQ3JSdENWNG5GamJ6TVdOQXExYmVmenV0ckRKb3N2WXpY?=
 =?utf-8?B?QmY0KzJkU1JSN1A4dmpieEcveVdRWkY1Nm5jY09jS2cyTnNzejJXVTlKMm8r?=
 =?utf-8?B?NVlqTm5QaHBhaXdPY0RtRHdvSGpnOUZ4eE1SN1FLRGljcis1SG9UQ3IwK05i?=
 =?utf-8?B?OCt3c0xUVTlFVTRoZUFyK2F4dXhLUmE4SjExS2p2emF4MDU4SzU1em9NZytN?=
 =?utf-8?B?RGdPeFc5MnVST1N6UXVnSVloZ1MvQW12REVZWGVXcERIMjBsQi9nQ3B1TE5D?=
 =?utf-8?B?RjNNMkpCY0ErL1c1bSt0eEpPc3FZMWZsS2pSZjlGVkV3T3ZLNDlHaGsyQk43?=
 =?utf-8?B?cWJqSXNIVnNOcm80RGxlQzdZcDlQUVJMaFBKVS8wTUwyVncrUGN3U3dmMTg4?=
 =?utf-8?B?Z2VpU0hyRmMySUFiY1RLVzhQcHNaTy9KUzZhcit2a2J3Y1BuRlAvSEp1TGIz?=
 =?utf-8?B?VElJUU5QM2dNVEhEM0xPNkZiMk56NlRMZHQ3YlFZbzNOdWV4S01JZ25yQkVx?=
 =?utf-8?B?VU94cnZUbjVsVHJGU1c5Y0VVNFJmZDFKd1ZqMG5wZ3lvMkY3NHo2MjJWc2JN?=
 =?utf-8?B?dEtUUVg0Umw3T2o0MHlCQWk2ZDZpUERoczRGZXpuMGRSbld1bVlSNDlPMURO?=
 =?utf-8?B?NStsVHJHamU1U09ieGVlMFhZSlpiTllwWDFCanpHdUJZNUdybmhuZVl0dVVB?=
 =?utf-8?B?OFZrRnZOUW5xa2x5TnoxY3NidjYxNWZObTNRL1ZoMFJKT0ppazVCWnh5Ullz?=
 =?utf-8?B?d0JWSzA0cFIxNkdCWlJKaXZkeTdEMWptRXYxNWpMK3dsUlJodExLQTJkRHNr?=
 =?utf-8?B?Sy9VTm83NnJXeTVZbklwU1A0YmtuWmtoQmZQeWZMUWcwRDVQVENxUlRILzlw?=
 =?utf-8?B?N09TS3FYZVFncEI1bEE2YmE1ODZxTjE1MnJMRHpUVktNUjMwZmN6YU9ackd0?=
 =?utf-8?B?T0JoeDhZTm5QZHFySHhvVVNPUy8rUnk3SDFBRnRlLzRPVGpBaWRjcWRaL3E3?=
 =?utf-8?B?UHdLbjNkOHczMzdreDkwcGlHTkZMcHZZbjQ5dlJaOEdiaHFaYzJOSkdrbUdI?=
 =?utf-8?B?QXgzQk5CNk9NZmZVYlhJOC9kd2JPSGdnaEVWTC81V3g2UVViakdZYWhrajgz?=
 =?utf-8?B?aXoremxRTXF5a0xqK25kcmM2UXJGOUhReTdZYUthNlRrVkZDN085Y2w3TUJh?=
 =?utf-8?B?SUVoWmYzaXNQMjB4LzJNdk90WUpScmJnclpad1ZPMlRtVitnM1pOWE1jQXFI?=
 =?utf-8?B?a0lpdDZGcWc4QXdYdE9hQVcrcXZuZ3p1RHg2TVJnWFBrNHdKL2liaXF0Q2pC?=
 =?utf-8?B?R2NIUE4xVDBwMElyeHo4N2phb0xaYmNmbEtFQkV5YVFjdkFBeHBqUkdVSTFF?=
 =?utf-8?B?MFBVbWViRXVJUE1GZ1E5K1YrbFlrTkVxemJuZ094SEJJYnYwU3ZVNXRXd1JY?=
 =?utf-8?B?M3J6R1dsY2NsN3FpNWhoN0V0SS9IRVFqcDRGUTRVTEdub3VDZUYrRUt5Mito?=
 =?utf-8?B?d3FHQkVvZCtQVFMyaGFYVkdERlc3NGRwbTVsUWVzZU41SFFYWEkrd0FsOG1q?=
 =?utf-8?B?RmFqSnI3dWwxS0MzU1Qwd3l2RG1qWnphbDlUK1Y3bzdYdDdCUWcyQ1h1eFlK?=
 =?utf-8?B?NEhIaGhabUNFRTZTWGRVVlhNZnBrK3RDWmhRNGhuL1c0TGdWTzRUbEtKRmhQ?=
 =?utf-8?B?WUdsempPeCtJWFh2WFA1YnBQUTlHRHdYV2xTeDdqUlZnVVFDZzkrWG9kTTBq?=
 =?utf-8?B?N09yTnl3MVJtTThYd2NsK3U5QVltSU1mVXh4VHlYckJZVkhlUlRWSE5QRmo3?=
 =?utf-8?B?MkoxM3QyVGlFc09aWkhCbjVLbGpSNE1SWTdsa1lYWFc1cStaZUtJTFljL2g0?=
 =?utf-8?B?T2xDSDF6bnoxZDNtVzZvcFdtRDdnY0IrWFAwQk1VWnpYZXEyNlFNMm1XSzE5?=
 =?utf-8?B?Sm0vZjVBenM2QmhxcmtYNnMvNXhsZDhObDYvVm42K3NwMi80NTMycVFuMlFy?=
 =?utf-8?B?R2J1SXA3eWJhb1YzYk1EYmliZEQ5ZHRySFF1WXBoZ1A0bWd0dXppUmhJODdM?=
 =?utf-8?Q?GRqlI2LP+2cALYhHG9adkGhWQ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b321cf30-1797-4a26-fca7-08daa1e8471c
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 07:00:22.7675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V6+duoelqBilKG73MMorOpZeoc/vClbX87pKDJKAhpXfkm54bubmy6DO48ovJ+cs4AsnISeb59OogsNV6ABWfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6560
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/29/2022 12:10 AM, Stephane Eranian wrote:
> offset is passed as a pointer and on certain call path is not set by the
> function. If the caller does not re-initialize offset between calls, value
> could be inherited between calls. Prevent this by initializing offset on each
> call.
> This impacts the code in amd_pmu_lbr_filter() which does
>    for(i=0; ...) {
>        ret = get_branch_type_fused(..., &offset);
>        if (offset)
>           lbr_entries[i].from += offset;
>    }
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
>  arch/x86/events/utils.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/events/utils.c b/arch/x86/events/utils.c
> index 5f5617afde79..76b1f8bb0fd5 100644
> --- a/arch/x86/events/utils.c
> +++ b/arch/x86/events/utils.c
> @@ -94,6 +94,10 @@ static int get_branch_type(unsigned long from, unsigned long to, int abort,
>  	u8 buf[MAX_INSN_SIZE];
>  	int is64 = 0;
>  
> +	/* make sure we initialize offset */
> +	if (offset)
> +		*offset = 0;
> +
>  	to_plm = kernel_ip(to) ? X86_BR_KERNEL : X86_BR_USER;
>  	from_plm = kernel_ip(from) ? X86_BR_KERNEL : X86_BR_USER;
>  

Reviewed-by: Sandipan Das <sandipan.das@amd.com>