Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1712958rwb; Thu, 29 Sep 2022 00:49:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Mtf7R6CrBMELPqD/QsJ3wUYvUnR3k8utZLjJA4NSyIvkZkPGsR4va6F7VKkchpDNDAuDA X-Received: by 2002:a17:902:eed3:b0:17a:dd04:1eb8 with SMTP id h19-20020a170902eed300b0017add041eb8mr2127495plb.89.1664437784468; Thu, 29 Sep 2022 00:49:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664437784; cv=none; d=google.com; s=arc-20160816; b=qzygUgV3ABBJ3HWoCu16dHVdjUL6nLRnqnUfUJKzKm9EOsmpIJH+IdsHHrl/U2aNo5 B4Ke87JRETN+UrT1npCLEDkHb9donsJySHAHE87h2VcJagno/HHTfHBrarRV0O6fXTHd Hylii/2fOVzgIXaYOdi7PZVR79zDvDABtods3u7zQJdEHwEgD83QEW2kxP0ZynZTtLnC VtIE7r3t+WkdGdiBhWyQJtdU5/mEXs+GOKJcyQBMuLe+xL3Z3J/cCmEO9seT9DxGj19t w4T/QZU448rSLzQ9p7gbXQ1flsKzLTBCohlAds0+L9+SRILODXfiXQFGYA0vUG61OkWs rzzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=XOvSHmFJKeh5yRkDJlU1n6MZZmHObV6hSAVG20Km+VE=; b=EpMFEQnu6qFrvKhHK8G/emhDH6FMvQY8Qr8QzXE9QjlgksFhJ/x6ME6GsMRLUiRl5G r0NMlirv2hrMxIvZsuNj1UQ28Nmp5w4frFcb1xyfn80eJMTSDFlkNP3eGyogFEhKrwFQ JwaiWywq+W9/CDsWalcMjyaV+65yqqMcN2dO5MaiF8RMtdCE0BgUybblqM4A5SGuAmD1 6n7HZ1X6SWe2HCscImmAc5nw02mgrdl1/MXQX/6eTYe9FdIX5hHeM2kJ2t1iJhiaRagZ l4zxMZ8VpuB/B2HSKP75+dkiPFbOc9xQ4m9RVuOBWYIAjXFHZKSby0IMKeF8cqhV9yYB iv6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=If7jJbfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m2-20020a17090a3f8200b00200b5c30f73si4281414pjc.106.2022.09.29.00.49.32; Thu, 29 Sep 2022 00:49:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=If7jJbfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233335AbiI2HDP (ORCPT + 99 others); Thu, 29 Sep 2022 03:03:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235019AbiI2HCj (ORCPT ); Thu, 29 Sep 2022 03:02:39 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB266130704 for ; Thu, 29 Sep 2022 00:02:37 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id i26so850116lfp.11 for ; Thu, 29 Sep 2022 00:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=XOvSHmFJKeh5yRkDJlU1n6MZZmHObV6hSAVG20Km+VE=; b=If7jJbfMCHwm4H071OfjzvYgNquTh0WVRQ+kk4g0SIxFHdM2UApkmcsxC0++Y7MFMV uyRGlgUgMBiwlklRxUS2z+tLyTPhW/6masPNggNR2mCOZpuDV4i48P/So8pXoxQ+hLte jz8PQ3EXAPHiXMKLFCGycw0WtinBeV8dS6+17h0ELImTp5cDr/RHVNeK3SgJSbCXNtOd SrJiwpZ9sUdOWa0vHVp1TaTOfMZEnXmn/kQKECke9vf9j0E4Z+ghuDgCqvTew0oqyzIp V1yBdslbyFJFwT6ClHDwfJiZfBxyGdDFbC8so5cBVJrXTxlt+Du3NWVoRsQ1V+rdmLf2 CUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=XOvSHmFJKeh5yRkDJlU1n6MZZmHObV6hSAVG20Km+VE=; b=e0/rBajiX+Q8Lg+AI5NKoR+fVR1Gv8QeYWuAL9QO6JElKuR2mzBsDbLfEsw+e+hkLm 4LE4i8TUO7xzQESDz8XNIgJTYnK5LgLFZWlZkVh2lco6vmScyOutlFwpqQyop3jc7zMs Oc4hfWZT/pFUyON5qNjoi+mZ0IMlpwEwjMRR+0lXA1a7pS6G5lmnAqJtSUvvazzRQmlR QroWmgXd+E+wMhYztbL5Rw3na/IhrFqhcTsPZeTGmRRr5LEQ4FZqvh0lDKRYj1BNiRF6 vAS2zJKNCrVcrRxTn3voruCz4dFI/IL7g7Dhy8bkiYWO7hPhuWIEQMIYkjhiyjVwmL0y ELJA== X-Gm-Message-State: ACrzQf0BXQJY6uIn8H7FxxA24/o6JC6T081tjOtJ3g1V4i2q4kx88q0P GA3dmdgcyO9oHVuSpjBPisFFBw== X-Received: by 2002:a05:6512:3f29:b0:4a1:c920:ebad with SMTP id y41-20020a0565123f2900b004a1c920ebadmr758260lfa.574.1664434956034; Thu, 29 Sep 2022 00:02:36 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q16-20020a194310000000b004946bb30469sm697275lfa.82.2022.09.29.00.02.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 00:02:35 -0700 (PDT) Message-ID: Date: Thu, 29 Sep 2022 09:02:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/3] dt-bindings: gpio: Conver Unisoc GPIO controller binding to yaml Content-Language: en-US To: Chunyan Zhang Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Baolin Wang , Orson Zhai , LKML References: <20220928092937.27120-1-zhang.lyra@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2022 04:29, Chunyan Zhang wrote: > Hi Krzysztof, > > On Wed, 28 Sept 2022 at 19:31, Krzysztof Kozlowski > wrote: >> >> On 28/09/2022 11:29, Chunyan Zhang wrote: >>> From: Chunyan Zhang >>> >>> Convert the Unisoc gpio controller binding to DT schema format. >>> >> >> >> Thank you for your patch. There is something to discuss/improve. >> >>> diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml >>> new file mode 100644 >>> index 000000000000..c0cd1ed9809b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml >>> @@ -0,0 +1,70 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright 2022 Unisoc Inc. >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/gpio/sprd,gpio.yaml# >> >> Use compatible as filename, so sprd,sc9860-gpio.yaml > > Humm... This is not only for SC9860, also for other IPs, UMS512 as an > example which added in this patchset. > Then it's ok. It seems you have also typo in commit subject (Conver). Best regards, Krzysztof