Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <9b7fac69-265e-52f2-21e4-83d9da0f257b@amd.com>
Date:   Thu, 29 Sep 2022 09:08:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration
 support
Content-Language: en-US
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
        "Kannan, Arun Balaji" <arun.balaji.kannan@amd.com>,
        "Mutthareddyvari, Jyotheeswar Reddy" 
        <jyotheeswar.reddy.mutthareddyvari@amd.com>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <git@xilinx.com>,
        <saikrishna12468@gmail.com>
References: <1655462819-28801-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com>
 <YzRvEPUWUXP4x7+h@pendragon.ideasonboard.com>
 <YzR5ZoAbaYONnmPS@pendragon.ideasonboard.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <YzR5ZoAbaYONnmPS@pendragon.ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 07:09:12.5894
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e156bd2f-1305-4a1b-cc92-08daa1e98341
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT019.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6036
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent,

On 9/28/22 18:42, Laurent Pinchart wrote:
> 
> On Wed, Sep 28, 2022 at 06:58:10PM +0300, Laurent Pinchart wrote:
>> Hi Sai,
>>
>> On Fri, Jun 17, 2022 at 04:16:55PM +0530, Sai Krishna Potthuri wrote:
>>> This series update the Xilinx firmware, ZynqMP dt-binding and ZynqMP
>>> pinctrl driver to handle 'output-enable' and 'bias-high-impedance'
>>> configurations. As part of these configurations, ZynqMP pinctrl driver
>>> takes care of pin tri-state setting.
>>> Also fix the kernel doc warning in ZynqMP pinctrl driver.
>>
>> I'm afraid this causes a regression :-( With this series applied, boot
>> breaks with the following message being printed to the serial console:
>>
>> Received exception
>> MSR: 0x200, EAR: 0xFF180198, EDR: 0x0, ESR: 0x64
>>
>> I've traced that to the probe of the UART, when it calls into the
>> firmware to set pin MIO18 to high impedance. According to v1.7 of the
>> ZynqMP registers reference (UG1087), there is no register at address
>> 0xFF180198.
>>
>> I am using the VCU TRD 2021.1 for testing. Does this series require a
>> firmware update ? If so backward compatibility needs to be preserved.
>> It's very late in the v6.0-rc cycle for a fix, a revert may be best at
>> this point, to give us time to fix the issue properly.
> 
> I've now tested the VCU TRD 2022.1 (which AFAIK is the latest available
> version), and the problem doesn't occue then. It thus seems this depends
> on a firmware update, which is impractical at best for all old designs
> :-(

That's correct observation. Supporting these two properties requires newer pmufw 
or that message is received.
I will let Arun and Jyotheeswar to comment it. I don't think there is a way to 
detect which firmware has implementation for it available.

Thanks,
Michal