Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: hATq87EDRi8j2Y137o/8IUP2j5eK/Ho/BpHfWXpNii63WPDfMp9vr4pkAEUtwAMBGB1MpmTKqp
 jQZWkLY3zJ/JbPxM96ISwWV+voEjlfVWzkgy5o3kUQIlIDBAzxKlx4r4xq7hlb9dqvNbR/fSvi
 YX8Y/BM96xrTMvFzEkqhY28WeKAmTMXwg7pJMG6Oe4Gh30yC5qW7yQNHPzog+i1YvGtYGHPllQ
 0OVVlxXubd50Wq58WgcVuzaFiy23/6qFIqMPbaBbaHgdwzIpj8MlxmkfMS4VmkSdJWKaDUDops
 EHw8GtJNcSTEUVLKvyAc7VVU
IronPort-SDR: PBy6aThaxixWiZeE4LanUxPjaCCbbT75/Hae6EzWQN+VSk3ZlLXQJslR677iwkxMtQvTdtrtW2
 oaDaso0MOaGNnx2T92cCKQBLMsVJ+N2iEMkxd2i5o8JOgzO1LSH5D7TftA6aymBs337oi82rh+
 YeQ1CVFnQiSNAcd3b1MKJ5ztg3p5SuztZB1BURyXuEIQ1ogcG9ZlVN8EdVUMonJp4Mxgp4tXIm
 6zc0+TzMJye6IndQC9OhbJysI5syWBPWz60LidDy7T9ucU4S55sRHhNG++6FUVeBjVBGCI9Ofw
 G0o=
WDCIronportException: Internal
Message-ID: <d938ff8d-caaf-9221-e598-62e7e04aa907@opensource.wdc.com>
Date:   Thu, 29 Sep 2022 16:56:28 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/6] scsi: libsas: Add sas_task_find_rq()
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com,
        damien.lemoal@wdc.com
Cc:     hare@suse.de, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com,
        ipylypiv@google.com, changyuanl@google.com, hch@lst.de
References: <1664368034-114991-1-git-send-email-john.garry@huawei.com>
 <1664368034-114991-2-git-send-email-john.garry@huawei.com>
 <0c0306d7-2645-874a-9745-8aa5dcfeede1@opensource.wdc.com>
 <1356c5b0-5cd7-b006-1b34-a66a34e23fb4@huawei.com>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1356c5b0-5cd7-b006-1b34-a66a34e23fb4@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/29/22 16:33, John Garry wrote:
> On 29/09/2022 03:09, Damien Le Moal wrote:
>> On 9/28/22 21:27, John Garry wrote:
>>> blk-mq already provides a unique tag per request. Some libsas LLDDs - like
>>> hisi_sas - already use this tag as the unique per-IO HW tag.
>>>
>>> Add a common function to provide the request associated with a sas_task
>>> for all libsas LLDDs.
>>>
>>> Signed-off-by: John Garry <john.garry@huawei.com>
>>> ---
>>>   include/scsi/libsas.h | 22 ++++++++++++++++++++++
>>>   1 file changed, 22 insertions(+)
>>>
>>> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
>>> index f86b56bf7833..bc51756a3317 100644
>>> --- a/include/scsi/libsas.h
>>> +++ b/include/scsi/libsas.h
>>> @@ -644,6 +644,28 @@ static inline bool sas_is_internal_abort(struct sas_task *task)
>>>   	return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT;
>>>   }
>>>   
>>> +static inline struct request *sas_task_find_rq(struct sas_task *task)
>>> +{
>>> +	struct scsi_cmnd *scmd;
>>> +
>>> +	if (!task || !task->uldd_task)
>>> +		return NULL;
>>> +
>>> +	if (task->task_proto & SAS_PROTOCOL_STP_ALL) {
>>> +		struct ata_queued_cmd *qc;
>>> +
>>> +		qc = task->uldd_task;
>>
>> I would change these 2 lines into a single line:
>>
>> 		struct ata_queued_cmd *qc = task->uldd_task;
>>
>> And no cast as suggested.
>>
>>> +		scmd = qc->scsicmd;
> 
> So do you prefer:
> 
>   scmd = ((struct ata_queued_cmd *)task->uldd_task)->scsicmd

Not a fan of the cast approach suggested by Jason. I prefer my above
suggestion, but no strong feeling about it. Either way will be OK.

> 
> As Jason suggested?
> 
> Thanks,
> John

-- 
Damien Le Moal
Western Digital Research