Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ceefc4c1-128b-6582-6074-378ad3ae7e0a@gmail.com>
Date:   Thu, 29 Sep 2022 09:35:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH -next] tty: serial: atmel: driver depends on COMMON_CLK
Content-Language: fr
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     Sergiu Moga <sergiu.moga@microchip.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>
References: <20220929054851.7723-1-rdunlap@infradead.org>
From:   Richard Genoud <richard.genoud@gmail.com>
In-Reply-To: <20220929054851.7723-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,
Le 29/09/2022 à 07:48, Randy Dunlap a écrit :
> Since atmel_serial.c uses interfaces that are provided by
> the COMMON_CLK Kconfig symbol, the driver should depend on
> COMMON_CLK to prevent build errors.
> 
> ld: drivers/tty/serial/atmel_serial.o: in function `atmel_serial_pm':
> atmel_serial.c:(.text+0x1553): undefined reference to `__clk_is_enabled'
> ld: drivers/tty/serial/atmel_serial.o: in function `atmel_set_termios':
> atmel_serial.c:(.text+0x1dfe): undefined reference to `__clk_is_enabled'
> 
> Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sergiu Moga <sergiu.moga@microchip.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Richard Genoud <richard.genoud@gmail.com>
> Cc: linux-serial@vger.kernel.org
> Cc: Jiri Slaby <jirislaby@kernel.org>

There's already a patch fixing this, acked by Nicolas :
https://lkml.org/lkml/2022/9/26/1587

> ---
>   drivers/tty/serial/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -128,6 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
>   config SERIAL_ATMEL
>   	bool "AT91 on-chip serial port support"
>   	depends on ARCH_AT91 || COMPILE_TEST
> +	depends on COMMON_CLK
>   	select SERIAL_CORE
>   	select SERIAL_MCTRL_GPIO if GPIOLIB
>   	select MFD_AT91_USART

Thanks !

Regards,
Richard