Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Randy Dunlap <rdunlap@infradead.org>,
        Wolfram Sang <wsa@kernel.org>, Corey Minyard <minyard@acm.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>
Cc:     Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com,
        Quan Nguyen <quan@os.amperecomputing.com>
Subject: [PATCH v9 3/3] i2c: aspeed: Assert NAK when slave is busy
Date:   Thu, 29 Sep 2022 15:03:26 +0700
Message-Id: <20220929080326.752907-4-quan@os.amperecomputing.com>
In-Reply-To: <20220929080326.752907-1-quan@os.amperecomputing.com>
References: <20220929080326.752907-1-quan@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I3xAM2ng10qs5iuCu8+l0sNkf265/sPTxKXGKS3p8Yh+SNr1I9PtkrQOT6Rx?=
 =?us-ascii?Q?CaE7/pkI6suONwY1zqOpKVSw8FztHlHEsr6qApQZkN1gSedEeaqYxgRbi1h8?=
 =?us-ascii?Q?TtGLA3W56M8U2Saire/TwioltqGFYcXQFjXe0AjFGuwUk2sdB5FLyS7QJYvJ?=
 =?us-ascii?Q?7Lj+8/VBnNMKpPsbXsyaufnoDSjvZBy43vFlYWpIB3g947y5yymP16QB9J9S?=
 =?us-ascii?Q?kmUGkWWI03wKRuXCTjqmWEArJ+PEeyszcckfXTcLpcS/Eqqr4FCzFFZyw3Vf?=
 =?us-ascii?Q?QomenKi5/A3rfs66FlZ3KfPDSBq5oTI1tx0kpy+LiyglntRDShQYfRwGEN2d?=
 =?us-ascii?Q?xcgWqYGgUxUsF850OQyiotm+H94HiImUpK0k7cJoP2a332TMy6xFlJpceUzn?=
 =?us-ascii?Q?Cd0X3nDN6xA3HPRgNXg3Nt2tqdMueW6sdtpQnol8gk9g5vI7HfUO/MdofXHc?=
 =?us-ascii?Q?ZMH6hBSgLHjnIsFDhtwANV69JiLWdQoy/FPOyYA7kIoA5KJwgkrJxHSQ4bty?=
 =?us-ascii?Q?vNBQxIkLYv7NxkTfcCksOGTWDmapTTkKugZMq27xx1b8GBG0B1XQJCMUoET7?=
 =?us-ascii?Q?GmOrLYKgGl00RF20kCUbzZzJonafMQwELpE/rhb9SUbwtX0g/I2slakd6ZGK?=
 =?us-ascii?Q?1xgmaXzLG3J/4lM62bQ7nuvtBh9c+pZ2m0+PwL1P8sH8zUYc2z0qiWqDgzDD?=
 =?us-ascii?Q?zyE84gL9iH1nNV0hUPbyqbyOJoddPuB6Mv3wW9fA0fVQd93EefhFirhVOPZL?=
 =?us-ascii?Q?3D6EVieQw3C9WAf1SVW1jtEyVE/j4btRN2eZRvx3RfxFzzH8+SC4GWQFa9bB?=
 =?us-ascii?Q?iCFAYvyjBo84woCY1lK7tt1lh/dNmYqRWAgi6617jy/msc89/rtqqE9tzHJO?=
 =?us-ascii?Q?qRULI1OnnkwdIVcusJ+8PDEm54uPkBIoadrGpzqbH/qRVgp49zg0mPeoU2k+?=
 =?us-ascii?Q?GeNHwpdDGxkzTmBwQqL7ZAgGWFUq4EZXBUcRtOoM2hNZL1omU+my5hmv1GUc?=
 =?us-ascii?Q?XaTzvVe1q5jF6kz+/ttgtFLHv4P0S6huSTpdtmDtdAwmb3ZfEv4lx8okUN49?=
 =?us-ascii?Q?MvFEwG5mCkGGrvgMDWVQ0u35ukeX0Y2aA8cvv1PdUYYTNuhod/IsPEkFRKRe?=
 =?us-ascii?Q?pv5dCEF6cZx11nxJA+QYselLENjiZ7RCnFaTAxgsvheBceVFUnMxZEj8Vfb9?=
 =?us-ascii?Q?nxfMHrNVTEqKOZkIPa/GScTcUwr0/ytvkig+0ytd01aNe26FnK2XdXhnjuLp?=
 =?us-ascii?Q?1sCdGfgPQxNHas/cfLRyGRDMcQelXYKsZ4q8i8zXrco9dcQxHtPAjprKgTDx?=
 =?us-ascii?Q?RcyuAwvMWKRh043udLNHh0rOHrY/f4N1/V92QRQNAaLHdXfrHaAzyKtqVWsg?=
 =?us-ascii?Q?E/f0iRcxAw1WunVRxz5VjW872haBm9ZTXsLdDGgIgVtl7u3A7jBhT0vHaCHi?=
 =?us-ascii?Q?nBWQmc618ov7+A1SsO1CfoapOuIq+EBvQyPd5UHb9Nik7vyDV9jbd4Jg4dP7?=
 =?us-ascii?Q?ktxcgkb/VYk7M0eCfuJD6weq90VpCJq88UTugp49FCOVMPZJr32ZL0VRU2VZ?=
 =?us-ascii?Q?+v6OPnCwQoi3NwUqVfUlggRRnRhkzr/CeqFlEVn0ZP/fYRhlwb7wRYlG2ewl?=
 =?us-ascii?Q?2n/gJExPPebE4Y0KT1mJyjg=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d3a2bbf-9b77-43a6-b866-08daa1f12f21
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 08:04:07.9087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lTYurY18aZlSlaf38HWKrI0i1TdHXImBAKW8mo14Vj5pFO87CUvgNw+ioUa+K26EQF7Aod7EPXON5MohbOCEReQNWmr24yl79h64pRfIoAs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7885
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On I2C_SLAVE_WRITE_REQUESTED event, Slave already ACK'ed on the address
phase. But as the backend driver is busy and unable to process any
request from Master, issue RxCmdLast for Slave to auto send NACK on
next incoming byte.

Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
---
v9:
  + Update commit message and add comment to explain
    the effect of issuing RxCmdLast when Slave busy [Quan]

v7 -> v8:
  + None

v6:
  + New introduced in v6                            [Quan]

 drivers/i2c/busses/i2c-aspeed.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 185dedfebbac..3d70f1ce6c6a 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -244,6 +244,7 @@ static u32 aspeed_i2c_slave_irq(struct aspeed_i2c_bus *bus, u32 irq_status)
 	u32 command, irq_handled = 0;
 	struct i2c_client *slave = bus->slave;
 	u8 value;
+	int ret;
 
 	if (!slave)
 		return 0;
@@ -311,7 +312,13 @@ static u32 aspeed_i2c_slave_irq(struct aspeed_i2c_bus *bus, u32 irq_status)
 		break;
 	case ASPEED_I2C_SLAVE_WRITE_REQUESTED:
 		bus->slave_state = ASPEED_I2C_SLAVE_WRITE_RECEIVED;
-		i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
+		ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
+		/*
+		 * Slave ACK's on this address phase already but as the backend driver insists it
+		 * is busy, turn on RxCmdLast for Slave to NACK on the next Rx byte.
+		 */
+		if (ret == -EBUSY)
+			writel(ASPEED_I2CD_M_S_RX_CMD_LAST, bus->base + ASPEED_I2C_CMD_REG);
 		break;
 	case ASPEED_I2C_SLAVE_WRITE_RECEIVED:
 		i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED, &value);
-- 
2.35.1