Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1776fe36-b954-b2c9-a2c1-157363f25ce2@xen0n.name>
Date:   Thu, 29 Sep 2022 17:06:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101
 Thunderbird/107.0a1
Subject: Re: [PATCH V3] LoongArch: Fix cpu name after s3/s4
To:     Jianmin Lv <lvjianmin@loongson.cn>,
        Huacai Chen <chenhuacai@kernel.org>
Cc:     linux-kernel@vger.kernel.org, loongarch@lists.linux.dev
References: <20220929085530.8742-1-lvjianmin@loongson.cn>
Content-Language: en-US
From:   WANG Xuerui <kernel@xen0n.name>
In-Reply-To: <20220929085530.8742-1-lvjianmin@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/29/22 16:55, Jianmin Lv wrote:
> On coming back from s3/s4, the cpu name will be overwritten
> in cpu_probe path of seconary cpu, so we don't overwrite it
> if it has been initialized.

The sentences are confusing, first "the CPU name will be overwritten" 
then "don't overwrite it if initialized" -- seems the CPU name will get 
overwritten despite the patch's clear intent.

Better to keep it simple: "Don't overwrite the CPU name on coming back 
from S3/S4 if it is already initialized."

>
> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
>
> diff --git a/arch/loongarch/kernel/cpu-probe.c b/arch/loongarch/kernel/cpu-probe.c
> index 529ab8f44ec6..255a09876ef2 100644
> --- a/arch/loongarch/kernel/cpu-probe.c
> +++ b/arch/loongarch/kernel/cpu-probe.c
> @@ -187,7 +187,9 @@ static inline void cpu_probe_loongson(struct cpuinfo_loongarch *c, unsigned int
>   	uint64_t *vendor = (void *)(&cpu_full_name[VENDOR_OFFSET]);
>   	uint64_t *cpuname = (void *)(&cpu_full_name[CPUNAME_OFFSET]);
>   
> -	__cpu_full_name[cpu] = cpu_full_name;
> +	if (!__cpu_full_name[cpu])
> +		__cpu_full_name[cpu] = cpu_full_name;
> +
>   	*vendor = iocsr_read64(LOONGARCH_IOCSR_VENDOR);
>   	*cpuname = iocsr_read64(LOONGARCH_IOCSR_CPUNAME);
>   

Otherwise LGTM.

Reviewed-by: WANG Xuerui <git@xen0n.name>

-- 
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/