Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0007218f-96f0-c348-0dfb-7cb54f014b1c@arm.com>
Date:   Thu, 29 Sep 2022 11:21:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.1
Subject: Re: [PATCH linux-next] coresight: use sysfs_emit() to instead of
 scnprintf()
To:     James Clark <james.clark@arm.com>, zhangsongyi.cgel@gmail.com
Cc:     mike.leach@linaro.org, leo.yan@linaro.org,
        alexander.shishkin@linux.intel.com, mcoquelin.stm32@gmail.com,
        alexandre.torgue@foss.st.com, coresight@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-kernel@vger.kernel.org,
        zhang songyi <zhang.songyi@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
References: <20220927115136.259926-1-zhang.songyi@zte.com.cn>
 <b8ad73ea-a20e-0e74-766e-eeb4cdeb1890@arm.com>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <b8ad73ea-a20e-0e74-766e-eeb4cdeb1890@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28/09/2022 15:56, James Clark wrote:
> 
> 
> On 27/09/2022 12:51, zhangsongyi.cgel@gmail.com wrote:
>> From: zhang songyi <zhang.songyi@zte.com.cn>
>>
>> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
>> should only use sysfs_emit() or sysfs_emit_at() when formatting the value
>> to be returned to user space.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>


>> ---
>>   drivers/hwtracing/coresight/coresight-stm.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
> 
> Reviewed-by: James Clark <james.clark@arm.com>


I have queued this locally for now, will push it once the next
cycle is out.

Suzuki