Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Thread-Topic: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Thread-Index: AQHY006sqGpD/PA5gEmZiYlRlE0jhK31oHQAgAC4dcA=
Date:   Thu, 29 Sep 2022 12:40:02 +0000
Message-ID: <PAXPR04MB9185141B58499FD00C43BB6889579@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20220928152509.141490-1-shenwei.wang@nxp.com>
 <YzT2An2J5afN1w3L@lunn.ch>
In-Reply-To: <YzT2An2J5afN1w3L@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pCOAP2SfafRfXJMNX/M9+Fledfq2rDbwmtLUV9cYDuQlI/d1MCsbKFd1z33l?=
 =?us-ascii?Q?RoLMcJLZhogg4GI2M4rj3qOzucK9p+y0KSG7tKUs+XRgDd0gNYypoOyHajCg?=
 =?us-ascii?Q?A0HaBNxWQuvhseYgm8v+snbegUV+nyeKxhLf5IvjjQg6tBwF4+zBeu3Ph5fR?=
 =?us-ascii?Q?hYmdtfjVnDZa/reyfXmiBt9ao4KBGfA/6hjGTbnhLwzM+1qvafFfSEsEiF+Y?=
 =?us-ascii?Q?ZPdIQ/YPO93ZOtzq4GdKvpvOXIIrdqvv5uWy1obXfzpbn/BjhmyR5uTPCkUc?=
 =?us-ascii?Q?3MYBJmHco+OfFhLZkLPaNTFrtlzZJUudV9xxsnCsPi5N1UknMBkVzfAFL2RE?=
 =?us-ascii?Q?HI9CM/RvZTcP0+iCcNxXRGaoo7/a17rblVCIIXIlvn877Fvfai3R3xYedXvC?=
 =?us-ascii?Q?S4JNhvEtCDMioPTS4jKW+G7BOy0vSlBzlMBCRu0WwCcgq6/pl65NTvsKN0d4?=
 =?us-ascii?Q?FVMExIA/GDlp+OswxOajJjJYbl1PA35TczwD6Fh6Kv54iPsa4hKAO0PjUfqJ?=
 =?us-ascii?Q?s/0tnq/+yyXQvlvwriIr6B8db6vHOg0Lh7bceBJXKjXLg9/Vmz30IEf1g77e?=
 =?us-ascii?Q?NRlTnWd2JcLV5738nzmMJG4vQC3kRnfP6h5XGxf/XfiJJaLtTcM13GdX4yh8?=
 =?us-ascii?Q?MflbXpZh3+D8sIq2/cBdhECeireZkp4J7HmdzBkV7x/DHy2ZgQ2pPCQwDNlP?=
 =?us-ascii?Q?aXxB3Plnz/3+elX1Yw8VePF2wWqR9lfMsLJHoB6EekwYIZszvHkWTZ6BWT2W?=
 =?us-ascii?Q?VIurBebIBgcSzKBf/rSDEnl8SlwApHXbJa3CekRK9X30Uv23/2gY3Ix5invn?=
 =?us-ascii?Q?Ty+vLtgNC4xjmIxlzWfEAstbt/xM/mtcTHvvm3Ku/08bShc0cKxSnRuW+aag?=
 =?us-ascii?Q?UCNXLWwNJ18GyC3mQASYhQN98Uyo/OiQRONGBf/QVVA44xlRisYvPTAUeyFD?=
 =?us-ascii?Q?EmjVOYpBHLs4sl/H7S8aTHMi4gzMqviFKAvTyCH/Gc5D7ll3LSAepp7UeZwJ?=
 =?us-ascii?Q?ALfy9QOc3m5wU8CNufwslh5qp4dWgpsufrRdLs/4kULCkpV+TFhLtPm5uZJj?=
 =?us-ascii?Q?zXrJk88czr18LN9I3EZDGStVBZg+WAAD1SnRmjV99H9dnMznnn2SsfWZa3+k?=
 =?us-ascii?Q?dy+ugaM+fdPEJkCoTl1OxOHKmvWfQTiWsueQvh2Gx/9AYJN6VfsUf60GijaK?=
 =?us-ascii?Q?TjgU59FtysuEJOhnbe0+L48DZ0pYJ5DDZSmAXBblzrKlYFhC5zpqVeS4qXfs?=
 =?us-ascii?Q?+JiY/msySXRBLMHb8AZ5vs4fo6piVIJbAurNlBWm9er2cJQwYMj9s0nRFwQ8?=
 =?us-ascii?Q?ZyWTq4+AbRXqqxg+yETF9ZS4/eXspGkrUpuzvaiPkCjF4DILZcv26caouxLt?=
 =?us-ascii?Q?BqXmnyANttB2/pVNahgh5HHoCd6dOjzHVHcNwmELwT76C9d5gHY3i0aZhM+y?=
 =?us-ascii?Q?RVArQUpHrYTFwCW+lk/ND60C6mdrY/1Gw+FUdUg5PZ8C1By1GOI61ozeo7/U?=
 =?us-ascii?Q?/J6qb3QpDhxNydWSUycAaGXuTDHPwlPvlOVGXYYvKKH/o6Pa3+BDL0g7d5Xb?=
 =?us-ascii?Q?AT5KbZHMQuzUZrPuswXZb6UIRUE85Y+JMhil4+cK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9b61a33-9585-40b8-e877-08daa217ba85
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 12:40:02.3319
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: deQMpgdUVpzxgHF1X9Ey2fxIvBWDgb8NTl0duB4Dsu2QPpaGjNJOosHSy14WrxRdj+PXuzyGztj/u98nvVPk8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8753
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, September 28, 2022 8:34 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Joakim Zhang <qiangqing.zhang@nxp.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
>=20
> Caution: EXT Email
>=20
> On Wed, Sep 28, 2022 at 10:25:09AM -0500, Shenwei Wang wrote:
> > This patch adds the initial XDP support to Freescale driver. It
> > supports XDP_PASS, XDP_DROP and XDP_REDIRECT actions. Upcoming
> patches
> > will add support for XDP_TX and Zero Copy features.
> >
> > This patch also optimizes the RX buffers by using the page pool, which
> > uses one frame per page for easy management. In the future, it can be
> > further improved to use two frames per page.
>=20
> Please could you split this patch up. It is rather large and hard to revi=
ew. I think
> you can first add support for the page pool, and then add XDP support, fo=
r
> example.
>=20

Will do it in the next version. Thanks for the review.

> I would be interesting to see how the page pool helps performance for nor=
mal
> traffic, since that is what most people use it for. And for a range of de=
vices,
> since we need to make sure it does not cause any regressions for older de=
vices.
>=20

I actually did some compare testing regarding the page pool for normal traf=
fic.=20
So far I don't see significant improvement in the current implementation. T=
he performance for large packets improves a little, and the performance for=
 small packets get a little worse.

Thanks,
Shenwei

>             Andrew