Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Thread-Topic: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Thread-Index: AQHY006sqGpD/PA5gEmZiYlRlE0jhK31pSmAgAC11xA=
Date:   Thu, 29 Sep 2022 12:46:29 +0000
Message-ID: <PAXPR04MB91859C7C1F1C4FE94611D5A789579@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20220928152509.141490-1-shenwei.wang@nxp.com>
 <YzT59R+zx4dA5G5Q@lunn.ch>
In-Reply-To: <YzT59R+zx4dA5G5Q@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OEHGkJLnBHzmMB/SKGECg5yNrSzO5+zk85/0hlJHXd9lHBwHVnCIDzYTVwi6?=
 =?us-ascii?Q?ZnOxo1ELhOCLDxqpqy0ea7HC9D9hCJ0x7u3KClH027Kw3/a+mbXfCwOH6l6Y?=
 =?us-ascii?Q?5TYmqglxF+kasP4nV+OX44lsOwHgSDki7U4dxeqqXu59AUJg81elWhYE5yXm?=
 =?us-ascii?Q?hTW13nMRLIxMxEKmnUjPkS+NyNvEhltDz51mlniTnNsgiG1HG1LcDVdm2u0D?=
 =?us-ascii?Q?Raps0k/XMVx+mnsH3thtq7c7q0khV1u9O5/ksHPwrtD7NS+R48qrdPXmkdZm?=
 =?us-ascii?Q?fhCspDieIKYBvE7cvuUvzuui2kWWXRuYuSQJlYp3OCSzBHRuEpEX6m7evkBk?=
 =?us-ascii?Q?AOnRsXvmbNkPt2m1nGc9ZNhzRvkGd4Ok4qInQtbG7PewzRm8kE7cgtTVFRVH?=
 =?us-ascii?Q?A7BN2qfkI8qfqqLoSmYBbBkAlvF87MB8C308GTTyHKsMzk4fO83sH+zI/z/+?=
 =?us-ascii?Q?dCrA0Yh4tbGWJYUTkU7ZgfBjVh1FVjUEIKpbGm0HFFSNGx4Vnmq6cZHaLUH+?=
 =?us-ascii?Q?Uo/YYynPGbtvyUVsRQeWENhuR7QkZhugVFA9np+T7WBynDTh8kpXt7VCcD+U?=
 =?us-ascii?Q?YYjxTDPj8lxJ+JQKNVGqxjwvesHVNYpi9xDICDaMr5JETYGXCfHl6/tignSW?=
 =?us-ascii?Q?9dQt2tT2ZujG8GYf7CgWjBxStp2eE4HL+QEIIpvZw438qX3gEGIMY3Vsr6r5?=
 =?us-ascii?Q?VjTyv5R0aji4CadYrSnGtaE8GiOu3bJFGFMtR4JJCuiv7RBcTaSndDsTrhvx?=
 =?us-ascii?Q?nJRGwQvi4pCJWUjBhVNrwY8GHw9YO9QPQAUQHGV+WLbzUE3CcpTUHYS5gNLA?=
 =?us-ascii?Q?WsgPbuzymhYYbd3wnE2HPJ54t6LHyMNlAalVIf3gsTgIGo4GA0khp5XXNn1t?=
 =?us-ascii?Q?htp0lH5uQxPGPBUDFxLAVFd5NcIejWmFIFm3opnPVUBOQWVecYRHLOkFsKZQ?=
 =?us-ascii?Q?POfchJOXPJ14/5UcBIAjNFDdK1IjFGI+6Mgeb5Z+mc7ASLOj3p5SNzB2g3SE?=
 =?us-ascii?Q?+AIpINqZ3Eyl2PA2Da4N+0bTPsr3UmsmSydsqtzm07yZpH40rHXyIq8NAObI?=
 =?us-ascii?Q?cXQ6RAN7HLr6qsVZ/5/iaikblWHpbQXaszpvmY0ForulA5YC1PT0TtuWw+Kg?=
 =?us-ascii?Q?aTfyXsnJE7ZOB1qKVTWG9XrEwzkNR/TmKdyrzgjYgiBVVeXbc3xUbu2fbhiz?=
 =?us-ascii?Q?8hmMSgh6PMJD60OcL2NbfK8FU9OZuULRU/AmzTv9jaaTn2e0eG3xQ7oCEwja?=
 =?us-ascii?Q?FnGTRnkuYX4chXbxGH4SXc3W7JNcyXfs2GhLVT4UDZAB49VpPG6jyJx/lN1D?=
 =?us-ascii?Q?JNN8rz7O3SwucPfLnzFzptcGztCpWm0nAOqskWYQfW41R33LM6p02CqC8F+T?=
 =?us-ascii?Q?pQjzcZUVTljvIhxJXfHUIRRDzrb6UxY53p4uigtYrCRdDXnUo6PNgyeC2/Yi?=
 =?us-ascii?Q?C0BhEcNMwmWZQHMXlETJ2ErgQJERFO1XKGN8Bla3S+hnNin9Wvyw+zIa0TJt?=
 =?us-ascii?Q?oEnbfZqRruZWh2EHADJjw9FdJAM+gFs68z/Knv2VepH/IccsuGcfq5g1+be4?=
 =?us-ascii?Q?EjMUE0mfmHIyPJUWA4YoNLKRrouLoS4s9cAmng1G?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02fb5de1-c259-4b0c-3a03-08daa218a13d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 12:46:29.4249
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8UnSMaY81YW2lMlT4ZqRFZ2QZIzjCiU7G1kCDNK52cnMwnnsfUB1Ne7VkmcDJpfadbj2RP436qYjzZyVTOoBFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, September 28, 2022 8:51 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Joakim Zhang <qiangqing.zhang@nxp.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
>=20
> Caution: EXT Email
>=20
> > +struct fec_enet_xdp_stats {
> > +     u64     xdp_pass;
> > +     u64     xdp_drop;
> > +     u64     xdp_xmit;
> > +     u64     xdp_redirect;
> > +     u64     xdp_xmit_err;
> > +     u64     xdp_tx;
> > +     u64     xdp_tx_err;
> > +};
> > +
> > +     switch (act) {
> > +     case XDP_PASS:
> > +             rxq->stats.xdp_pass++;
>=20
> Since the stats are u64, and most machines using the FEC are 32 bit, you =
cannot
> just do an increment. Took a look at u64_stats_sync.h.
>=20

As this increment is only executed under the NAPI kthread context,  is the =
protection still required?

> > -#define FEC_STATS_SIZE               (ARRAY_SIZE(fec_stats) * sizeof(u=
64))
> > +static struct fec_xdp_stat {
> > +     char name[ETH_GSTRING_LEN];
> > +     u32 count;
> > +} fec_xdp_stats[] =3D {
> > +     { "rx_xdp_redirect", 0 },
> > +     { "rx_xdp_pass", 0 },
> > +     { "rx_xdp_drop", 0 },
> > +     { "rx_xdp_tx", 0 },
> > +     { "rx_xdp_tx_errors", 0 },
> > +     { "tx_xdp_xmit", 0 },
> > +     { "tx_xdp_xmit_errors", 0 },
> > +};
> > +
> > +#define FEC_STATS_SIZE       ((ARRAY_SIZE(fec_stats) + \
> > +                     ARRAY_SIZE(fec_xdp_stats)) * sizeof(u64))
>=20
> The page pool also has some stats. See page_pool_get_stats(),
> page_pool_ethtool_stats_get_strings() etc.
>=20

Will add those stats in the next version.

Thanks,
Shenwei

>       Andrew