Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2162588rwb;
        Thu, 29 Sep 2022 07:02:18 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5jYcUuE9TzD88EgcFuGaY0lecoPHr5OYaeNGRkv2THsp5Mkz7wpqWf7b6wz25ZbbeprGGe
X-Received: by 2002:a17:902:7294:b0:178:a2be:ac13 with SMTP id d20-20020a170902729400b00178a2beac13mr3577969pll.59.1664460138653;
        Thu, 29 Sep 2022 07:02:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1664460138; cv=none;
        d=google.com; s=arc-20160816;
        b=x8rleXuIiO0JWHDj+9AWJ1zkGJMivlpMLwPNXElmUYyOzWXdH3OtdX0KNlNjZP9fmH
         J2d5OD2zSPTUvTCOsaKQoRujbrqHpmBmVJD906tkUUxw1++7JxT+5mABvIUUoE2G+RhM
         GwJ1iWU8pWGQ8E7lsQ13l3NSYMlGe6dWAUARDWo1YdLRxiWBao2nqsEV374cRIEwZKrk
         BoI0OPwlhyPvK/G99ZmQJfvx1o+WCOsC+BtmO9hCWPF9zykQ+vTKwmr8dJqPdfinu3Bh
         kLZYbOH8S1vxrSASSjj9FjGxxWEfUx0g3M96gwNjMHHssrT0HL4CHNiNKcUYES6THrxi
         GBjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=0+1nUta2pVXe4Nepuxyz02WZlUvq7DHS9Z6e3kiv/no=;
        b=LWa0MpzEEVPB0Fz4XxpNLFdVt/9QVOSa3CZgDHl5mV8XZt5tNn9E43lkar6VvCjb7i
         HF0YRL7tYBGju7z0zNbsxzDmlBXUggju+YtL+dc4U9hlxHjozZjSwqoscYLBF4aixPZz
         IHeBiakrWsTGYYa/BaNi30pZrXR9o14fZfkcZASuSIgjBFY69G/38KGFwmN4nKWNYRR7
         Efzn2cSbStsxEzbpq7flyH/zA1bag3EZuh4xtJIN80YiY7qCSisKNHWLqUjqYh4mJucx
         JhGea2l719OVx2pWOlW1J1eIDEywd7DeAGxmVkSIjGGUuPD/SMfOUn6jVaxlwk/7ttDa
         JK3Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bEcj0OpK;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id q6-20020a17090311c600b0016db0d4f4c9si9531468plh.65.2022.09.29.07.02.03;
        Thu, 29 Sep 2022 07:02:18 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bEcj0OpK;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235039AbiI2NXJ (ORCPT <rfc822;andy.bettisworth@gmail.com>
        + 99 others); Thu, 29 Sep 2022 09:23:09 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49730 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234916AbiI2NXA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Sep 2022 09:23:00 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F1CEB774F;
        Thu, 29 Sep 2022 06:22:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=0+1nUta2pVXe4Nepuxyz02WZlUvq7DHS9Z6e3kiv/no=; b=bEcj0OpKViIgw16wtP99ObezXR
        7ypjXPzngzdnT6Kau0fp0/7PShtnL+062fmnUA+gVXUlFxAwDi1VmgJCvZtFtceDMD3cUlNV6gLva
        RBFYj42lZONUA980PX9oUN/4OrH2iCnGxyLZYlSM7vRQvU9w3PiSW5aTnToMgnl30iM4=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1odtUx-000cNT-Dt; Thu, 29 Sep 2022 15:22:43 +0200
Date:   Thu, 29 Sep 2022 15:22:43 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Shenwei Wang <shenwei.wang@nxp.com>
Cc:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Message-ID: <YzWcI+U1WYJuZIdk@lunn.ch>
References: <20220928152509.141490-1-shenwei.wang@nxp.com>
 <YzT2An2J5afN1w3L@lunn.ch>
 <PAXPR04MB9185141B58499FD00C43BB6889579@PAXPR04MB9185.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PAXPR04MB9185141B58499FD00C43BB6889579@PAXPR04MB9185.eurprd04.prod.outlook.com>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I actually did some compare testing regarding the page pool for
> normal traffic.  So far I don't see significant improvement in the
> current implementation. The performance for large packets improves a
> little, and the performance for small packets get a little worse.

What hardware was this for? imx51? imx6? imx7 Vybrid? These all use
the FEC.

By small packets, do you mean those under the copybreak limit?

Please provide some benchmark numbers with your next patchset.

       Andrew