Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Thread-Topic: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
Thread-Index: AQHY006sqGpD/PA5gEmZiYlRlE0jhK31oHQAgAC4dcCAAA2WgIAAADZw
Date:   Thu, 29 Sep 2022 13:26:31 +0000
Message-ID: <PAXPR04MB918545B92E493CB57CDE612B89579@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20220928152509.141490-1-shenwei.wang@nxp.com>
 <YzT2An2J5afN1w3L@lunn.ch>
 <PAXPR04MB9185141B58499FD00C43BB6889579@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <YzWcI+U1WYJuZIdk@lunn.ch>
In-Reply-To: <YzWcI+U1WYJuZIdk@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aKap9MH5QRDLHIYolexmV0t9V+ry6Pz3EsuPpMzVaA7ga7OrNQeYLDQbXAGP?=
 =?us-ascii?Q?9QQgll+LR/vCfCHg64Qq2z0sbJi5KOYB8snh+5xkBODB67y5GGoMoxJAURwL?=
 =?us-ascii?Q?Ky61ZI8UAW875eFMqR/zuWl/yJzYu1XEYL31dhH+wXkLanerExX4W2Hbc24e?=
 =?us-ascii?Q?KLUdzeXD4iu2QBWtmSiYfJeUjIDtKXGQorgqJyHBUrmpy6jykvOXEozW4VEx?=
 =?us-ascii?Q?da2YoDxuP5xOK4/Wr4LiGw5RKBePP7SIeXG6jYpfUxuPvthUAsg8rsXTfAUi?=
 =?us-ascii?Q?A/fSFRR1f+u45Kvit2wDzdEgy/fkzvaG7hXeiBZEEzAul00JbPIkaLlqVLHB?=
 =?us-ascii?Q?PHU+6kXPa6j6gCDPKdbAHCmAxb/c+K8zqtT4yV/Aopyn95orYBDheYlmGHu6?=
 =?us-ascii?Q?X+bhMrNRc8mVk3lc43IOA3EWMQxh+oyIXAaIqjvWCAbGjxyfZwkAUMuMDzuv?=
 =?us-ascii?Q?baVOqZEpBpsCjq2j17XMug9lXkY/NsnuCb7JFE9jbSITd3SSryyJ0OdfQ6Kk?=
 =?us-ascii?Q?UMO0p2OQeNe2a1wReNKp90U217tjdwq10fKLeMNQkIAY3Vlnr1bRW27paAtE?=
 =?us-ascii?Q?5EzEAAI0KUQMsteq/DS9j3KN7LqE2c3yUmo03k8SVCFdlHEqzNIt3n5PnLBF?=
 =?us-ascii?Q?JhnyWZvkFkmvEUFX9DR8nCdbFad78I1iQMOD5Rqz/dO77s+CnZwTemWlWjPa?=
 =?us-ascii?Q?LS5w8MaQOMNrwX19eRes7r0dO2g9/7jggS3zddg8UOMzkeN+NgrMw7IlF2G2?=
 =?us-ascii?Q?nJ3h3+gcerhf/MlSIhXvKAzTZvO6QkzkewC8IAgMOPo+MQFwcWFjZ6FJTlFA?=
 =?us-ascii?Q?u89QjgRj95d++3VVWaDIbKTvz7T7w8YXHArpbMe2cS9G2kbrDsmeqcRs0wsj?=
 =?us-ascii?Q?5EXGBAoBtI4EEpI03plyFTlSwv6SfK2xkrYZk+QAaUiO2KIxx4JW0shibZ0S?=
 =?us-ascii?Q?eUw9nRxhYctk1hsJejZg3kGnwT9XCKQXcOujvRV6k8+sE4mR249UGWzpeIEm?=
 =?us-ascii?Q?aEjcCRwYSAVjL/2U8aLpjOvuaOT1kdKhH6sR4wtUuJUMO1rfeDByg1xDyagU?=
 =?us-ascii?Q?w3u6UFUgRE3mHDrTZldekWz6+axZlE3ZmnJQu0cnHgfzKVpjdt5bL2uku63A?=
 =?us-ascii?Q?F7wlyy/hWSHbfy0dey1fXw4ZP7DM3I8pcWS6uYU2mL1IHWma4lK520MT90aS?=
 =?us-ascii?Q?6dNRoApRR9mAqV1u1OMrqn4w7t5RcCzoKvO19ncqOGpgWCbtj5W79Uds5rEU?=
 =?us-ascii?Q?VYNJlKc5K5mo7D7lEJjw+t8cZqarUqEvr4RrhT2EC76XL2LrlJY1OGz6v47l?=
 =?us-ascii?Q?/Ih4rZkGTC5fsbKJfbViWNbjjv5ZqoRJsLeOMUXmC94rLhBWbwnS7BIUQoJg?=
 =?us-ascii?Q?BaGuII0agcnhgv0Ysx4IkKWcsmmBrEOfXBWVgXcw3iyEUSgiv3Vhw/vAMcuH?=
 =?us-ascii?Q?ILwDYlIM0NLFowuS3YU6Yad7HaXtJwQVJaFAba5JnBRI2glIPFMbguQH45hb?=
 =?us-ascii?Q?edc+pqYfX5IWem59c9HoT58gUFdqEjLxKkWc/POL03m63Y5x8yDrfFz64xnW?=
 =?us-ascii?Q?WneI94XwBau4JoTd/p1NcWmmdyXu5cM6iBf7gT5B?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c05beec-24e0-4bd1-0a9e-08daa21e394d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 13:26:31.9790
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VPtCexkAxyrePqrW4keWKmaz7cgFX+B25TgHuLirQHemU1cJjnwbnT0V1zZiZGvkRmoJLgM7yjb8ImOZmaXdeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9336
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, September 29, 2022 8:23 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Joakim Zhang <qiangqing.zhang@nxp.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: Re: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support
>=20
> Caution: EXT Email
>=20
> > I actually did some compare testing regarding the page pool for normal
> > traffic.  So far I don't see significant improvement in the current
> > implementation. The performance for large packets improves a little,
> > and the performance for small packets get a little worse.
>=20
> What hardware was this for? imx51? imx6? imx7 Vybrid? These all use the F=
EC.

I tested on imx8qxp platform. It is ARM64.
=20
>=20
> By small packets, do you mean those under the copybreak limit?
>=20
> Please provide some benchmark numbers with your next patchset.

Yes, the packet size is 64 bytes and it is under the copybreak limit. As th=
e impact is not significant, I would prefer to remove the copybreak logic.

Thanks,
Shenwei

>=20
>        Andrew