Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220928210059.891387-1-daniel.lezcano@linaro.org> <d0be3159-8094-aed1-d9b1-c4b16d88d67c@linaro.org>
In-Reply-To: <d0be3159-8094-aed1-d9b1-c4b16d88d67c@linaro.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 29 Sep 2022 15:58:11 +0200
Message-ID: <CAJZ5v0hOFoe0KqEimFv9pgmiAOzuRoLjdqoScr53ErNFU4AAPA@mail.gmail.com>
Subject: Re: [PATCH v7 00/29] Rework the trip points creation
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, rui.zhang@intel.com,
        Raju Rangoju <rajur@chelsio.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Peter Kaestle <peter@piie.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Amit Kucheria <amitk@kernel.org>,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Support Opensource <support.opensource@diasemi.com>,
        Lukasz Luba <lukasz.luba@arm.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        =?UTF-8?Q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,
        Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Keerthy <j-keerthy@ti.com>,
        Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Antoine Tenart <atenart@kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Dmitry Osipenko <digetx@gmail.com>, netdev@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-omap@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Sep 29, 2022 at 2:26 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi Rafael,
>
> are you happy with the changes?

I'll have a look and let you know.

> I would like to integrate those changes with the thermal pull request

Sure, but it looks like you've got only a few ACKs for these patches
from the driver people.

Wouldn't it be prudent to give them some more time to review the changes?

> On 28/09/2022 23:00, Daniel Lezcano wrote:
> > This work is the pre-requisite of handling correctly when the trip
> > point are crossed. For that we need to rework how the trip points are
> > declared and assigned to a thermal zone.
> >
> > Even if it appears to be a common sense to have the trip points being
> > ordered, this no guarantee neither documentation telling that is the
> > case.
> >
> > One solution could have been to create an ordered array of trips built
> > when registering the thermal zone by calling the different get_trip*
> > ops. However those ops receive a thermal zone pointer which is not
> > known as it is in the process of creating it.
> >
> > This cyclic dependency shows we have to rework how we manage the trip
> > points.
> >
> > Actually, all the trip points definition can be common to the backend
> > sensor drivers and we can factor out the thermal trip structure in all
> > of them.
> >
> > Then, as we register the thermal trips array, they will be available
> > in the thermal zone structure and a core function can return the trip
> > given its id.
> >
> > The get_trip_* ops won't be needed anymore and could be removed. The
> > resulting code will be another step forward to a self encapsulated
> > generic thermal framework.
> >
> > Most of the drivers can be converted more or less easily. This series
> > does a first round with most of the drivers. Some remain and will be
> > converted but with a smaller set of changes as the conversion is a bit
> > more complex.
> >
> > Changelog:
> >   v7:
> >      - Added missing return 0 in the x86_pkg_temp driver
> >   v6:
> >      - Improved the code for the get_crit_temp() function as suggested by Rafael
> >      - Removed inner parenthesis in the set_trip_temp() function and invert the
> >        conditions. Check the type of the trip point is unchanged
> >      - Folded patch 4 with 1
> >      - Add per thermal zone info message in the bang-bang governor
> >      - Folded the fix for an uninitialized variable in int340x_thermal_zone_add()
> >   v5:
> >      - Fixed a deadlock when calling thermal_zone_get_trip() while
> >        handling the thermal zone lock
> >      - Remove an extra line in the sysfs change
> >      - Collected tags
> > v4:
> >     - Remove extra lines on exynos changes as reported by Krzysztof Kozlowski
> >     - Collected tags
> >   v3:
> >     - Reorg the series to be git-bisect safe
> >     - Added the set_trip generic function
> >     - Added the get_crit_temp generic function
> >     - Removed more dead code in the thermal-of
> >     - Fixed the exynos changelog
> >     - Fixed the error check for the exynos drivers
> >     - Collected tags
> >   v2:
> >     - Added missing EXPORT_SYMBOL_GPL() for thermal_zone_get_trip()
> >     - Removed tab whitespace in the acerhdf driver
> >     - Collected tags
> >
> > Cc: Raju Rangoju <rajur@chelsio.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: Paolo Abeni <pabeni@redhat.com>
> > Cc: Peter Kaestle <peter@piie.net>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Mark Gross <markgross@kernel.org>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Amit Kucheria <amitk@kernel.org>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
> > Cc: Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Cc: Ray Jui <rjui@broadcom.com>
> > Cc: Scott Branden <sbranden@broadcom.com>
> > Cc: Support Opensource <support.opensource@diasemi.com>
> > Cc: Lukasz Luba <lukasz.luba@arm.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Cc: Thara Gopinath <thara.gopinath@linaro.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
> > Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > Cc: Eduardo Valentin <edubezval@gmail.com>
> > Cc: Keerthy <j-keerthy@ti.com>
> > Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > Cc: Antoine Tenart <atenart@kernel.org>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Cc: Dmitry Osipenko <digetx@gmail.com>
> > Cc: netdev@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: platform-driver-x86@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-rpi-kernel@lists.infradead.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-arm-msm@vger.kernel.org
> > Cc: linux-renesas-soc@vger.kernel.org
> > Cc: linux-samsung-soc@vger.kernel.org
> > Cc: linux-tegra@vger.kernel.org
> > Cc: linux-omap@vger.kernel.org
> >
> > Daniel Lezcano (29):
> >    thermal/core: Add a generic thermal_zone_get_trip() function
> >    thermal/sysfs: Always expose hysteresis attributes
> >    thermal/core: Add a generic thermal_zone_set_trip() function
> >    thermal/core/governors: Use thermal_zone_get_trip() instead of ops
> >      functions
> >    thermal/of: Use generic thermal_zone_get_trip() function
> >    thermal/of: Remove unused functions
> >    thermal/drivers/exynos: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/exynos: of_thermal_get_ntrips()
> >    thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by
> >      thermal_zone_get_trip()
> >    thermal/drivers/tegra: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/uniphier: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/hisi: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/qcom: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/armada: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/rcar_gen3: Use the generic function to get the number
> >      of trips
> >    thermal/of: Remove of_thermal_get_ntrips()
> >    thermal/of: Remove of_thermal_is_trip_valid()
> >    thermal/of: Remove of_thermal_set_trip_hyst()
> >    thermal/of: Remove of_thermal_get_crit_temp()
> >    thermal/drivers/st: Use generic trip points
> >    thermal/drivers/imx: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/rcar: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/da9062: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() /
> >      ti_thermal_trip_is_valid()
> >    thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function
> >    thermal/drivers/cxgb4: Use generic thermal_zone_get_trip() function
> >    thermal/intel/int340x: Replace parameter to simplify
> >    thermal/drivers/intel: Use generic thermal_zone_get_trip() function
> >
> >   drivers/net/ethernet/chelsio/cxgb4/cxgb4.h    |   2 -
> >   .../ethernet/chelsio/cxgb4/cxgb4_thermal.c    |  41 +----
> >   drivers/platform/x86/acerhdf.c                |  73 +++-----
> >   drivers/thermal/armada_thermal.c              |  39 ++---
> >   drivers/thermal/broadcom/bcm2835_thermal.c    |   8 +-
> >   drivers/thermal/da9062-thermal.c              |  52 +-----
> >   drivers/thermal/gov_bang_bang.c               |  39 +++--
> >   drivers/thermal/gov_fair_share.c              |  18 +-
> >   drivers/thermal/gov_power_allocator.c         |  51 +++---
> >   drivers/thermal/gov_step_wise.c               |  22 ++-
> >   drivers/thermal/hisi_thermal.c                |  11 +-
> >   drivers/thermal/imx_thermal.c                 |  72 +++-----
> >   .../int340x_thermal/int340x_thermal_zone.c    |  33 ++--
> >   .../int340x_thermal/int340x_thermal_zone.h    |   4 +-
> >   .../processor_thermal_device.c                |  10 +-
> >   drivers/thermal/intel/x86_pkg_temp_thermal.c  | 120 +++++++------
> >   drivers/thermal/qcom/qcom-spmi-temp-alarm.c   |  39 ++---
> >   drivers/thermal/rcar_gen3_thermal.c           |   2 +-
> >   drivers/thermal/rcar_thermal.c                |  53 +-----
> >   drivers/thermal/samsung/exynos_tmu.c          |  57 +++----
> >   drivers/thermal/st/st_thermal.c               |  47 +----
> >   drivers/thermal/tegra/soctherm.c              |  33 ++--
> >   drivers/thermal/tegra/tegra30-tsensor.c       |  17 +-
> >   drivers/thermal/thermal_core.c                | 161 +++++++++++++++---
> >   drivers/thermal/thermal_core.h                |  24 +--
> >   drivers/thermal/thermal_helpers.c             |  28 +--
> >   drivers/thermal/thermal_netlink.c             |  21 +--
> >   drivers/thermal/thermal_of.c                  | 116 -------------
> >   drivers/thermal/thermal_sysfs.c               | 133 +++++----------
> >   drivers/thermal/ti-soc-thermal/ti-thermal.h   |  15 --
> >   drivers/thermal/uniphier_thermal.c            |  27 ++-
> >   include/linux/thermal.h                       |  10 ++
> >   32 files changed, 560 insertions(+), 818 deletions(-)
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog