Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 14:30:18 +0000
From:   Stafford Horne <shorne@gmail.com>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonas Bonn <jonas@southpole.se>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        openrisc@lists.librecores.org
Subject: Re: [PATCH] openrisc: update config files
Message-ID: <YzWr+mmtLy2DRYEA@oscomms1>
References: <20220929101458.32434-1-lukas.bulwahn@gmail.com>
 <YzWp+p+1V1UmCAb3@oscomms1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzWp+p+1V1UmCAb3@oscomms1>
Precedence: bulk

Hello,


On Thu, Sep 29, 2022 at 02:21:46PM +0000, Stafford Horne wrote:
> On Thu, Sep 29, 2022 at 12:14:58PM +0200, Lukas Bulwahn wrote:
> > Clean up config files by:
> >   - removing configs that were deleted in the past
> >   - removing configs not in tree and without recently pending patches
> >   - adding new configs that are replacements for old configs in the file

Not all of these apply to this patch.  Can you on mention what you changes you
are doing here?

> > For some detailed information, see Link.
> > 
> > Link: https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulwahn@gmail.com/
> > 

This extra newline is not need.

> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> 
> Hello,
> 
> Thanks for the patch this looks fine to me.  Usually I just generate this
> defcnfigs using make savedefconfig.  If there is some better way which
> doesn't generate the file with the # comment's I haven't found it.
> 
> I will queue this.

Actually..

About the subject 'openrisc: update config files' and description.  Can you be
more specific about what updates you are making for this patch?

For example: remove comments from config files.

-Stafford

> > ---
> >  arch/openrisc/configs/or1ksim_defconfig    | 5 -----
> >  arch/openrisc/configs/simple_smp_defconfig | 4 ----
> >  2 files changed, 9 deletions(-)
> > 
> > diff --git a/arch/openrisc/configs/or1ksim_defconfig b/arch/openrisc/configs/or1ksim_defconfig
> > index 6e1e004047c7..af1164807206 100644
> > --- a/arch/openrisc/configs/or1ksim_defconfig
> > +++ b/arch/openrisc/configs/or1ksim_defconfig
> > @@ -19,9 +19,6 @@ CONFIG_NET=y
> >  CONFIG_PACKET=y
> >  CONFIG_UNIX=y
> >  CONFIG_INET=y
> > -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> > -# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> > -# CONFIG_INET_XFRM_MODE_BEET is not set
> >  # CONFIG_INET_DIAG is not set
> >  CONFIG_TCP_CONG_ADVANCED=y
> >  # CONFIG_TCP_CONG_BIC is not set
> > @@ -34,7 +31,6 @@ CONFIG_DEVTMPFS=y
> >  CONFIG_DEVTMPFS_MOUNT=y
> >  # CONFIG_PREVENT_FIRMWARE_BUILD is not set
> >  # CONFIG_FW_LOADER is not set
> > -CONFIG_PROC_DEVICETREE=y
> >  CONFIG_NETDEVICES=y
> >  CONFIG_ETHOC=y
> >  CONFIG_MICREL_PHY=y
> > @@ -52,4 +48,3 @@ CONFIG_SERIAL_OF_PLATFORM=y
> >  # CONFIG_DNOTIFY is not set
> >  CONFIG_TMPFS=y
> >  CONFIG_NFS_FS=y
> > -# CONFIG_ENABLE_MUST_CHECK is not set
> > diff --git a/arch/openrisc/configs/simple_smp_defconfig b/arch/openrisc/configs/simple_smp_defconfig
> > index ff49d868e040..84ca3203af9c 100644
> > --- a/arch/openrisc/configs/simple_smp_defconfig
> > +++ b/arch/openrisc/configs/simple_smp_defconfig
> > @@ -27,9 +27,6 @@ CONFIG_NET=y
> >  CONFIG_PACKET=y
> >  CONFIG_UNIX=y
> >  CONFIG_INET=y
> > -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> > -# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> > -# CONFIG_INET_XFRM_MODE_BEET is not set
> >  # CONFIG_INET_DIAG is not set
> >  CONFIG_TCP_CONG_ADVANCED=y
> >  # CONFIG_TCP_CONG_BIC is not set
> > @@ -60,5 +57,4 @@ CONFIG_SERIAL_OF_PLATFORM=y
> >  CONFIG_TMPFS=y
> >  CONFIG_NFS_FS=y
> >  CONFIG_XZ_DEC=y
> > -# CONFIG_ENABLE_MUST_CHECK is not set
> >  # CONFIG_RCU_TRACE is not set
> > -- 
> > 2.17.1
> >