Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220929101458.32434-1-lukas.bulwahn@gmail.com>
 <YzWp+p+1V1UmCAb3@oscomms1> <YzWr+mmtLy2DRYEA@oscomms1>
In-Reply-To: <YzWr+mmtLy2DRYEA@oscomms1>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 29 Sep 2022 17:07:40 +0200
Message-ID: <CAMuHMdWx5RKP8WfNAyOofGFTGQNfOtDYMOJmvPgPhtyvRPG1Bw@mail.gmail.com>
Subject: Re: [PATCH] openrisc: update config files
To:     Stafford Horne <shorne@gmail.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Jonas Bonn <jonas@southpole.se>, openrisc@lists.librecores.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Stafford,

On Thu, Sep 29, 2022 at 4:30 PM Stafford Horne <shorne@gmail.com> wrote:
> On Thu, Sep 29, 2022 at 02:21:46PM +0000, Stafford Horne wrote:
> > On Thu, Sep 29, 2022 at 12:14:58PM +0200, Lukas Bulwahn wrote:
> > > Clean up config files by:
> > >   - removing configs that were deleted in the past
> > >   - removing configs not in tree and without recently pending patches
> > >   - adding new configs that are replacements for old configs in the file

> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >
> > Thanks for the patch this looks fine to me.  Usually I just generate this
> > defcnfigs using make savedefconfig.  If there is some better way which
> > doesn't generate the file with the # comment's I haven't found it.
> >
> > I will queue this.
>
> Actually..
>
> About the subject 'openrisc: update config files' and description.  Can you be
> more specific about what updates you are making for this patch?
>
> For example: remove comments from config files.

These are not comments, but options that default to y or m, and
are overriden to n by "commenting them out".

This syntax dates back to the days Kconfig was a collection of
shell scripts. Nowadays, switching to "CONFIG_<FOO>=n" would
perhaps make sense, as Kconfig already recognizes that syntax.

> > > --- a/arch/openrisc/configs/or1ksim_defconfig
> > > +++ b/arch/openrisc/configs/or1ksim_defconfig
> > > @@ -19,9 +19,6 @@ CONFIG_NET=y
> > >  CONFIG_PACKET=y
> > >  CONFIG_UNIX=y
> > >  CONFIG_INET=y
> > > -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> > > -# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> > > -# CONFIG_INET_XFRM_MODE_BEET is not set
> > >  # CONFIG_INET_DIAG is not set
> > >  CONFIG_TCP_CONG_ADVANCED=y
> > >  # CONFIG_TCP_CONG_BIC is not set

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds