Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760984AbXFWRQb (ORCPT ); Sat, 23 Jun 2007 13:16:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760706AbXFWRQW (ORCPT ); Sat, 23 Jun 2007 13:16:22 -0400 Received: from mail.screens.ru ([213.234.233.54]:53744 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760608AbXFWRQU (ORCPT ); Sat, 23 Jun 2007 13:16:20 -0400 Date: Sat, 23 Jun 2007 21:17:00 +0400 From: Oleg Nesterov To: Steven Rostedt Cc: LKML , Linus Torvalds , Ingo Molnar , Andrew Morton , Thomas Gleixner , Christoph Hellwig , john stultz , "Paul E. McKenney" , Dipankar Sarma , "David S. Miller" , kuznet@ms2.inr.ac.ru Subject: Re: [RFC PATCH 5/5 v2] Convert tasklets to work queues Message-ID: <20070623171700.GB2346@tv-sign.ru> References: <20070622182051.859570787@goodmis.org> <20070622182315.571740041@goodmis.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070622182315.571740041@goodmis.org> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 554 Lines: 21 minor nitpick, On 06/22, Steven Rostedt wrote: > > +void takeover_tasklets(unsigned int cpu) > +{ > +} Since you don't use config option any longer, I think it is better to just kill this function and fix it's only caller. You can also kill the declaration of tasklet_kill_immediate() in tasklet.h. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/