Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c1ab0387-ff56-a7a5-bfd5-93e53293a97b@intel.com>
Date:   Thu, 29 Sep 2022 08:28:50 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.3.0
Subject: Re: [PATCH 3/5] selftests/resctrl: Remove duplicate codes that clear
 each test result file
Content-Language: en-US
To:     "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
References: <20220914015147.3071025-1-tan.shaopeng@jp.fujitsu.com>
 <20220914015147.3071025-5-tan.shaopeng@jp.fujitsu.com>
 <bdb19cf6-dd4b-2042-7cda-7f6108e543aa@intel.com>
 <TYAPR01MB6330988D96E4CD00C9A03DAA8B559@TYAPR01MB6330.jpnprd01.prod.outlook.com>
 <a0841d1f-fcc1-f307-7e2d-b9cce534455d@intel.com>
 <TYAPR01MB6330E178F0D86ED8ACE075378B579@TYAPR01MB6330.jpnprd01.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <TYAPR01MB6330E178F0D86ED8ACE075378B579@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFNJWGx6RlhUdm1xZGx6dTFzQmYzekVmQktLeit4SmJGMHpiaElxUUEraTd3?=
 =?utf-8?B?NEhHekF6U29VTXkxbmhCcmMwc2E0V3gra3hTc3REM2dBMURZV0lzaFFlSUsz?=
 =?utf-8?B?a3BUSE1Eam5YaE5OUHY0WGcrTEFnR3Q5bnVUeEJhZGNIM3JXVXB5RDB2MHhu?=
 =?utf-8?B?bDhFaXlZemYrNW1aYVo1S2FsQklQbHVXWmh0cmkwOVZ4OFFtV2E5bEErZG9M?=
 =?utf-8?B?SHorSlpQUitBRVFXMUM5ZmViamZrUTlEVzZzRnBDTXMxb1RTRkFPcmZDTVd4?=
 =?utf-8?B?aG82WFliS1NuSmtsMFgxYXZ2eDZPREZTNWpSOFp2VXVvMTIwdGRTRDNKUUc5?=
 =?utf-8?B?Q0NHYVUwamFKVUZqc3lXNHUwcXo4SVJZeW91a3NQTUduMkRzKzg5d2p5anJC?=
 =?utf-8?B?aXoxMGpJVzZhVTFmc0pIUUlZQm5zUnVzS0NRVnVBWXYreXNrQkszbWRjSWFS?=
 =?utf-8?B?eHo1Y3d6a0hhLzlIblVHOWR0S3JHclBTeWozMDBCU1JIdnk1eG5jYWlJazNh?=
 =?utf-8?B?RHBveUJra1J2UlVUV2cyRGFveXVsbnNJdlRFc0YrMUMzNlU3eWk1YVNGZzJQ?=
 =?utf-8?B?VXZNR0k4M0RSd3RmTUR4VUNPbjV2cXRKRHhIZ2dZOStPcHZMNVRoSkN1bEp4?=
 =?utf-8?B?SU80aHFlakJHdE9oejB0OFpJbk5mQ3RpTFo2dFNkRFlaMTlaeDNkM3pYSHEz?=
 =?utf-8?B?aUIwTXJub0htcFF5MUNROFNObHFkaFhMb0k1ejhMcVNxWDE4MjFVbmJSNmdQ?=
 =?utf-8?B?UjdNQlRuVGlMaGl5S0wzbE1naXpyaHF4azdIV0pmQkIybnlKMnlpd010VUZ0?=
 =?utf-8?B?WXdvTGRBamp0U0dkY3NtU1pJazZoei9OZDdpVEdGYzlqMEFma1JudmE3K1cr?=
 =?utf-8?B?MWk1SUsvSnJYYWtoUjlNaWtqYU9FVVdjbWtIYUU1ZDhaeUgySlVsaWxoMW9Y?=
 =?utf-8?B?L2hzYU9MVVlOZVNHbjJXVlY1M3orTVh0eFpLcmFYcnBDUXFDUWhoYmJzNGU5?=
 =?utf-8?B?U3NIT3UzYSs2R1FySXJjQmpGZkxOU2VJUDk2WFpFMkJ5K3JvZW5yUUllTkx0?=
 =?utf-8?B?NmowK3JubUwyWGRqbTBPRkFDL3FBKzlweFgrV0xySDRFMXBWekZLTENwUmJT?=
 =?utf-8?B?L29YNU5VdTd0b1NucDk0ajhwMmlUZDVCVDY2TTFuNmY4ODVXdVZYRHUzeVBx?=
 =?utf-8?B?WkovZENTbXg5R0NRdDQ4SU9pcUVQT1FnSW1qTWZiQWpsQjg1NHNOMHI3ZUgw?=
 =?utf-8?B?RHA3VlgwQlMxVElRVXVXTGUvVFQzLzl6TjROYm1odU9sQVZYQWNaR0ZZbmlC?=
 =?utf-8?B?ck9OcjBYTjhZbENVYWRZVlFNbnpzMnVTbzlvZVBWU0d3MVQ4bmJDU3g2dHlN?=
 =?utf-8?B?TG5UUEg4bUZyNzhWQitsc2lsTVpubVlYT0N0ck1XckgxOEd2OTdraUhiQ3Zp?=
 =?utf-8?B?TE5ndi95WjhWR0lOMkdlaUxxZnAybTljcGdRbld4Vk5LTTlxSkxJUWdUQk5H?=
 =?utf-8?B?Tk9wZ21LNGxOczBHRGltZFRKNkF4SFNDZXJPUDdOcUpqbjNZcHJaOXcvWUg2?=
 =?utf-8?B?Ym9KdklLOXFyQkFXK1d5V3JuVW53K1EvZ0xPZmFyMm02ckZFRUF2T2I1WUJK?=
 =?utf-8?B?UVl2V01HMmN1ODcyK1BOSUNsQ1R4Q2tucXQvWTN6ak5IWVRsa25PdE90Ullr?=
 =?utf-8?B?cnBtZFBlSDV6Nlg1ZVFvNHRYNVFVN2lyU3pDbjdwNEw2akNuVzFSemcvbmNY?=
 =?utf-8?B?ZW1BRkx5bFB2cXUvZ2t2a0FLNlJHd1RPY3grL3dtc2doNHdHbTh5cWV0RHBL?=
 =?utf-8?B?UmZjR2RTRFIwbld3VzhJRVFHNE5qY1pTVitzb0dqUXV5ZzRhYmJGT2dXVEdt?=
 =?utf-8?B?VnlUWjRyd1ZGek8zbE5XS1FPQnE0T25sTFZpQkVlV1ljOU85eHl0TmVKTFFG?=
 =?utf-8?B?Y0ZjNWtNOG56ZnAwZWNQT0JxL2tvUWE1WDhpWUN2ZTVmMWw1QWJFd1ZFOFFV?=
 =?utf-8?B?VlpNQ1lNbEZzTTNVbS9rdkFhZk5Vcnl3ejd3bW81NXpQR1BKaDlxZGRHTWhW?=
 =?utf-8?B?Y2hpdlNtZFhZVzA3M29NamJWU1YwYWV4b3VHM2w0THBMUkNmTG9ac2N6Z1ZC?=
 =?utf-8?B?cnlJT3JwVy9QVWNmWTdLSkJnb29ualJIaUtMTndqUVFmMml2cUtuN29ZT1Yv?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d883bacd-f9e0-42a5-57a5-08daa22f50b9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 15:28:52.9707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MDQ3Zmb1OMH8Jlt9Yq/qdlHvYxKiyfZhrmVwACSC9JBZUUlQpE94ZWJiF5d6PZWu5xzstt0LmIQfGTwnfK1hXtHq+iMg4SBdKXSpjqYQYMg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7191
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 9/28/2022 10:28 PM, tan.shaopeng@fujitsu.com wrote:
>> On 9/27/2022 2:01 AM, tan.shaopeng@fujitsu.com wrote:
>>>> On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
>>>>> Before exiting each test function(run_cmt/cat/mbm/mba_test()),
>>>>> test results are printed by ksft_print_msg() and then temporary
>>>>> result files are cleaned by function cmt/cat/mbm/mba_test_cleanup().
>>>>> However, before running ksft_print_msg(), function
>>>>
>>>> before -> after?
>>>
>>> I think it is "before".
>>
>> hmmm ... if cmt/cat/mbm/mba_test_cleanup() was run before
>> ksft_print_msg() then there would be no test results to print, no?
>> The current implementation runs cmt/cat/mbm/mba_test_cleanup() after
>> ksft_print_msg() ... albeit twice.
> 
> 
> I am sorry I made a mistake in changelog.
> It should be ksft_test_result() instead of ksft_print_msg().
> 
> Changelog:
> Before exiting each test function(run_cmt/cat/mbm/mba_test()),
> test results (“ok”/”not ok”) are printed by ksft_test_result() and then temporary result
> files are cleaned by function cmt/cat/mbm/mba_test_cleanup().
> However, before running ksft_test_result(), function cmt/cat/mbm/mba_test_cleanup()
> has been run in each test function as follows:
>   cmt_resctrl_val()
>   cat_perf_miss_val()
>   mba_schemata_change()
>   mbm_bw_change()
> 
> Remove duplicate codes that clear each test result file.

This is clear, thank you very much.

Reinette