Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 13:24:05 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>, iommu@lists.linux.dev,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] iommu/s390: Fix potential s390_domain aperture
 shrinking
Message-ID: <YzXGpQkSG4cw3ahm@nvidia.com>
References: <20220929153302.3195115-1-schnelle@linux.ibm.com>
 <20220929153302.3195115-4-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220929153302.3195115-4-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cCTFdXdHdfQ4xCz/t+xY7PTOgMPchxngIL0nxXsH4vg8kp+QbIHhbmFifucT?=
 =?us-ascii?Q?4EevUiscXMBrHiyBetjlzuyWDVorUBFvDqQvoPUc7VAKzQ/G9Lx0ALlF5YIr?=
 =?us-ascii?Q?29gAi4ID2oiyFFGuO6FG92iKZh7KJKCytB5W2SK3a9rXFMLf3BmKL19FTR2L?=
 =?us-ascii?Q?YcWJZRp2NpjwWxuXUMbaaEWlDkYhdvaC5FdJ2EJHOhweMtYsLhfekVDUzOFM?=
 =?us-ascii?Q?yUD4sFVXq11/ZZ0zWU25qrDm4tKvYFqpCIFPIIoK+oKPW0Wyptrc46xW0ajR?=
 =?us-ascii?Q?X7ooUo8b1sSVEJ3yAjM5a86Oy6riltmQTW5FdPWVhFvKY7LyvlANGoTZwagS?=
 =?us-ascii?Q?+GGef3XS260Kl4bez7vXyPDKUHj+J8fYZsu4dbowwMrZOkgK+MYmGxujfNy1?=
 =?us-ascii?Q?GE1FdmjANYhjcum6d4a+B93vsdJ7aqklxn4s+cO8jEU/PNvvtLpjv9zAtBrF?=
 =?us-ascii?Q?dUYO2q23UR+4GgDSELqczBISm9zj5EnJDJt8IxSnCsWti8fr2UYd8O1tBgfo?=
 =?us-ascii?Q?skmq7y29rSqLudM7ixV3NzYP6U2PqVs1IjsOZafCZIXEYMc+2aGNa0c8GdZ+?=
 =?us-ascii?Q?lUfqHaRsnW7gHXDoekMu8mDmTT6N3M6j6jqhn+vqESr3gKB/QkfZkBsSXuJu?=
 =?us-ascii?Q?6+Gq3SBkrj6nI4xIvQhS4OvzmCxU3X6Rf4MHQQPO7OU0xf5Zk1LetfpwXu6a?=
 =?us-ascii?Q?HEB+f1/2YR0vBQ4OIUF8n+vKoxHB4439uRMeOGwnLEYCXtRtZvQyVwVg2TYE?=
 =?us-ascii?Q?dvHzOCvMtIuwX81Cr+ypg92UkG0m5aig10p8rNx1zI2vvrgLOhFqvhkF+dDA?=
 =?us-ascii?Q?fZVCBRzAHJxe/CiKTB7g9xjv8LxM/QcOXtTR9//xLItQ7SrXScddo951f837?=
 =?us-ascii?Q?dajHbZ/BrUATb1UEuSW8fHc0dRsxuacRXtgkAhtIJiOqUd2Pk+YOTJsK9PGF?=
 =?us-ascii?Q?zwhlFG/2PP+sspjmGHOATA+aHpVfhcB1FJnx8ttfSPohoOjg2mDRl6IShxW4?=
 =?us-ascii?Q?Vftfgnc197vBH8K7aPoL0FOa9RlrhItOdfrF+7pn+7QMeyA0w01r6m2F2sYM?=
 =?us-ascii?Q?SP4M4fk1oGddxqt6uib81uTaL97sJGp5SSiDaduScZIhymncZqW313X9hdWl?=
 =?us-ascii?Q?3TK1gWvnWKzwnoYQwk1z9mM2W5XHiBcn+wCSkFol0VdbU1SUbhxTM5Z0/QUi?=
 =?us-ascii?Q?w2/7HqBgH7lTe5X9jr4Pdx+oXERz9beRKUithny4xWgxeBxd2HGfWvEUQEPL?=
 =?us-ascii?Q?kpxlQaSu8hcqkRB+j7rdwJA5jTfJf2Ue4RSMwZUUjDeWfM6mHXNhpk/n3CRS?=
 =?us-ascii?Q?tMoBLYwBp4Yz25pZMbTWFT2HYdTVGo10oE4EkwRhWgxBXfADeuWMy4cjXD72?=
 =?us-ascii?Q?jTJ+PHTFrEytvQQjvBgFcggh3402J1gC67WcnA0ISoCWZJkRI2YHEoaP4rkl?=
 =?us-ascii?Q?5xr/tCkyMRO4ZIfD1qjLkZ7S3pvBOMH8WXZ2ARJY/5vOk0YyC+Ibex+Bqb80?=
 =?us-ascii?Q?S44aSCP0D0j/yazMblITtM0ICcASLx9BoCchg5KxJWQ+zjrmR18JmqteU5/M?=
 =?us-ascii?Q?2KlKV7YeNiFykc+x01Q=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e87bbfe7-73a0-4697-9c1c-08daa23707f7
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 16:24:06.8477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmgYpjnGC0C81ePPsS3rzNLOCMzKyQLuEuZHl2R19pkH11Hm7zBVc5wTtOoA30fk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4135
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 29, 2022 at 05:33:00PM +0200, Niklas Schnelle wrote:
> The s390 IOMMU driver currently sets the IOMMU domain's aperture to
> match the device specific DMA address range of the device that is first
> attached. This is not ideal. For one if the domain has no device
> attached in the meantime the aperture could be shrunk allowing
> translations outside the aperture to exist in the translation tables.
> Also this is a bit of a misuse of the aperture which really should
> describe what addresses can be translated and not some device specific
> limitations.
> 
> Instead of misusing the aperture like this we can instead create
> reserved ranges for the ranges inaccessible to the attached devices
> allowing devices with overlapping ranges to still share an IOMMU domain.
> This also significantly simplifies s390_iommu_attach_device() allowing
> us to move the aperture check to the beginning of the function and
> removing the need to hold the device list's lock to check the aperture.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
>  drivers/iommu/s390-iommu.c | 50 +++++++++++++++++++++++++++-----------
>  1 file changed, 36 insertions(+), 14 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason